Re: Cygwin patches

[Ken Brown <kbrown@cornell.edu>]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On 11/22/2009 12:25 AM, Davis Herring wrote:
>> +  (if (eq system-type 'cygwin)
>> +      (let ((winfile (shell-command-to-string (concat
>> +			  "cygpath -m " (shell-quote-argument file)))))
>> +	(setq file (concat "file://" (substring winfile 0 -1)))))
> 
> I would instead bind winfile to
> 
> (with-output-to-string
>   (call-process "cygpath" nil standard-output nil "-m" file))
> 
> (using, like `shell-command-to-string' does, the undocumented feature that
> `with-output-to-string' causes `standard-output' to be a temporary
> buffer).  Then you don't have to worry with `shell-quote-argument'.

Thanks for the suggestion.  My revised patch is attached.  If it looks 
OK, could someone please check it in?

Thanks.

Ken

[-- Attachment #2: browse-url.el.patch --]
[-- Type: text/plain, Size: 638 bytes --]

--- browse-url.el.orig	2009-11-21 12:33:40.000000000 -0500
+++ browse-url.el	2009-11-22 07:38:25.890761600 -0500
@@ -699,6 +699,10 @@
 (defun browse-url-file-url (file)
   "Return the URL corresponding to FILE.
 Use variable `browse-url-filename-alist' to map filenames to URLs."
+  (if (eq system-type 'cygwin)
+      (let ((winfile (with-output-to-string
+              (call-process "cygpath" nil standard-output nil "-m" file))))
+	(setq file (concat "file://" (substring winfile 0 -1)))))
   (let ((coding (and (default-value 'enable-multibyte-characters)
 		     (or file-name-coding-system
 			 default-file-name-coding-system))))