From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tobias =?UTF-8?Q?Ringstr=C3=B6m?= Newsgroups: gmane.emacs.bugs Subject: bug#4992: Invalid use of strcpy() in etags Date: Fri, 20 Nov 2009 16:43:05 +0100 Message-ID: <4B06B909.30402@ringis.se> Reply-To: Tobias =?UTF-8?Q?Ringstr=C3=B6m?= , 4992@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080708050901050001010604" X-Trace: ger.gmane.org 1258841519 31831 80.91.229.12 (21 Nov 2009 22:11:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2009 22:11:59 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 21 23:11:52 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NByAV-0003SB-1U for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Nov 2009 23:10:59 +0100 Original-Received: from localhost ([127.0.0.1]:60919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBuP0-00056v-CQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Nov 2009 13:09:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBWDK-0001P3-9u for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:20:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBWDF-0001MJ-Aa for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:20:01 -0500 Original-Received: from [199.232.76.173] (port=44677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBWDF-0001MG-5O for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:19:57 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47943) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBW1I-0008Sx-KL for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 11:07:36 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAKG7LIJ025306; Fri, 20 Nov 2009 08:07:21 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAKFo4WS023025; Fri, 20 Nov 2009 07:50:04 -0800 Resent-Date: Fri, 20 Nov 2009 07:50:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Tobias =?UTF-8?Q?Ringstr=C3=B6m?= Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 20 Nov 2009 15:50:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4992 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125873180522530 (code B ref -1); Fri, 20 Nov 2009 15:50:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 20 Nov 2009 15:43:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAKFhMMU022527 for ; Fri, 20 Nov 2009 07:43:25 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBVdq-0005nS-L4 for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 10:43:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBVdk-0005lt-R9 for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 10:43:21 -0500 Original-Received: from [199.232.76.173] (port=48348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBVdk-0005lq-Mb for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 10:43:16 -0500 Original-Received: from proxy2.bredband.net ([195.54.101.72]:50213) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBVdk-0004ww-83 for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 10:43:16 -0500 Original-Received: from ipb2.telenor.se (195.54.127.165) by proxy2.bredband.net (7.3.140.3) id 4AD3E1BC01136D77 for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 16:43:13 +0100 X-SMTPAUTH-B2: X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsRDAOVHBktT4+75PGdsb2JhbACBToJ3lzUBAQEBN6drkF+DaFQE X-IronPort-AV: E=Sophos;i="4.44,777,1249250400"; d="scan'208";a="5746208" Original-Received: from ua-83-227-238-249.cust.bredbandsbolaget.se (HELO ringis.se) ([83.227.238.249]) by ipb2.telenor.se with ESMTP; 20 Nov 2009 16:43:13 +0100 Original-Received: from ext-gw3.swedot.se ([194.17.162.110] helo=tobiaspc.swedot.se) by ringis.se with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1NBVda-0002qr-PK for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2009 16:43:07 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 20 Nov 2009 11:20:01 -0500 X-Mailman-Approved-At: Sat, 21 Nov 2009 13:09:34 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32806 Archived-At: This is a multi-part message in MIME format. --------------080708050901050001010604 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The function absolute_filename() lib-src/etags.c has two invalid calls to strcpy() with overlapping arguments. It's undefined C that often happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 2.11 on x86_64, which is default for Fedora 12. The attached patch replaces the bogus strcpy() calls with calls to memmove(). /Tobias --------------080708050901050001010604 Content-Type: text/plain; name="emacs-23.1-strcpy-bug.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="emacs-23.1-strcpy-bug.patch" ZGlmZiAtcnUgZW1hY3MtMjMuMS5vcmlnL2xpYi1zcmMvZXRhZ3MuYyBlbWFjcy0yMy4xL2xp Yi1zcmMvZXRhZ3MuYwotLS0gZW1hY3MtMjMuMS5vcmlnL2xpYi1zcmMvZXRhZ3MuYwkyMDA5 LTA2LTIxIDA2OjM3OjM0LjAwMDAwMDAwMCArMDIwMAorKysgZW1hY3MtMjMuMS9saWItc3Jj L2V0YWdzLmMJMjAwOS0xMS0yMCAxNjozNTowOS42MzgyMDAxOTIgKzAxMDAKQEAgLTY2OTUs MTMgKzY2OTUsMTMgQEAKIAkgICAgICBlbHNlIGlmIChjcFswXSAhPSAnLycpCiAJCWNwID0g c2xhc2hwOwogI2VuZGlmCi0JICAgICAgc3RyY3B5IChjcCwgc2xhc2hwICsgMyk7CisJICAg ICAgbWVtbW92ZSAoY3AsIHNsYXNocCArIDMsIHN0cmxlbiAoc2xhc2hwICsgMikpOwogCSAg ICAgIHNsYXNocCA9IGNwOwogCSAgICAgIGNvbnRpbnVlOwogCSAgICB9CiAJICBlbHNlIGlm IChzbGFzaHBbMl0gPT0gJy8nIHx8IHNsYXNocFsyXSA9PSAnXDAnKQogCSAgICB7Ci0JICAg ICAgc3RyY3B5IChzbGFzaHAsIHNsYXNocCArIDIpOworCSAgICAgIG1lbW1vdmUgKHNsYXNo cCwgc2xhc2hwICsgMiwgc3RybGVuIChzbGFzaHAgKyAxKSk7CiAJICAgICAgY29udGludWU7 CiAJICAgIH0KIAl9Ck9ubHkgaW4gZW1hY3MtMjMuMS9saWItc3JjOiBldGFncy5jLm9yaWcK T25seSBpbiBlbWFjcy0yMy4xL2xpYi1zcmM6IGV0YWdzLmMucmVqCg== --------------080708050901050001010604--