From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#4951: 23.1.50; browse-url-default-windows-browser bug + patch Date: Wed, 18 Nov 2009 13:54:21 +0800 Message-ID: <4B038C0D.8020707@f2s.com> References: Reply-To: Jason Rumney , 4951@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1258524788 12517 80.91.229.12 (18 Nov 2009 06:13:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Nov 2009 06:13:08 +0000 (UTC) To: Lennart Borgman , 4951@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 18 07:13:01 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NAdmm-0006s0-MG for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Nov 2009 07:13:01 +0100 Original-Received: from localhost ([127.0.0.1]:49698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAdml-0008Nv-F1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Nov 2009 01:12:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAdhR-0005N7-AI for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2009 01:07:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAdhM-0005Kj-88 for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2009 01:07:28 -0500 Original-Received: from [199.232.76.173] (port=34685 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAdhL-0005KW-Qp for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2009 01:07:24 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43921) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAdhL-0004EO-8c for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2009 01:07:23 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAI67Kwn009523; Tue, 17 Nov 2009 22:07:20 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAI6046w008147; Tue, 17 Nov 2009 22:00:04 -0800 Resent-Date: Tue, 17 Nov 2009 22:00:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 18 Nov 2009 06:00:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4951 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4951-submit@emacsbugs.donarmstrong.com id=B4951.12585237228069 (code B ref 4951); Wed, 18 Nov 2009 06:00:04 +0000 Original-Received: (at 4951) by emacsbugs.donarmstrong.com; 18 Nov 2009 05:55:22 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-yx0-f190.google.com (mail-yx0-f190.google.com [209.85.210.190]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAI5tK1Z008066 for <4951@emacsbugs.donarmstrong.com>; Tue, 17 Nov 2009 21:55:22 -0800 Original-Received: by yxe28 with SMTP id 28so766395yxe.19 for <4951@emacsbugs.donarmstrong.com>; Tue, 17 Nov 2009 21:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=2QzYCRBU0Tki0KDEMpHQDIWoBztZ4B4F9gKk7KrpsXA=; b=qiC1tXdWYWmjadhbOUFPb3q3vrqFZjD+Gero+kAwAUevZcBbGy6Oq5pbDs+2xxItOB Lz4UkJbjuXQ5IBkk6FJgOILTRNFQXuoVyKP/vZN8giZgq/n3L5WKkglj/5h7YS+TG07r /LsP6AH2HwnD/mAnJnL66rbf4EN2y9eQV/4QA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=gx+MNSNL9UFrNdfMlM5FHknPJKfjpqGFaAeNBAL1wMHfqfnHQnIuQ/847SkN2Cf5xg Vx9rYLHOh6FpVRFCoA1iAgsJRnc2iBDWHZjBOxvfO+ZlO1EURbUwIOtBwxYVU1DaAQbi TyaXDDq8oSZpXhJDANWnnsyMFNYtHI311JJaA= Original-Received: by 10.150.246.10 with SMTP id t10mr1556561ybh.226.1258523715429; Tue, 17 Nov 2009 21:55:15 -0800 (PST) Original-Received: from ?10.1.1.113? ([61.4.103.130]) by mx.google.com with ESMTPS id 5sm188182ywd.38.2009.11.17.21.55.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 17 Nov 2009 21:55:14 -0800 (PST) User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 18 Nov 2009 01:07:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32681 Archived-At: Lennart Borgman wrote: > On Wed, Nov 18, 2009 at 4:35 AM, Stefan Monnier > wrote: > >>> browse-url-default-windows-browser does not work any longer. I am >>> unsure when it stopped working, but on at least Windows XP the >>> attached patch seems necessary. Could we please apply this as soon as >>> possible so it will get tested? >>> >> Could you explain why it's necessary? I mean I understand you say that >> the current doesn't work, but I'd like to understand why it doesn't work. >> > > No, I do not understand why it is necessary ... ;-) > > There are two changes: > > 1) file: => file:/// > > This was discussed some time ago (a yr or two?) and it looks like this > is a more correct syntax for the file URL. > Is it actually needed, or is this purely an aesthetic thing? The RFCs are not clear whether either is more correct, as the file: scheme is not explicitly defined, and not all URL schemes require a server to be specified before the file path. As far as I can tell, either option is accepted by Windows itself, but if the association passes the URL intact rather than after converting to a file argument by Windows, then there may be applications that accept one but not the other. IIRC the main reason for using file: rather than file:/// was that if the same code is used on all platforms, then the former works, while the latter does not (too many / when combined with posix paths). But as this is now in a (windows-nt msdos cygwin) conditional, that is not really important, and we should use what works. > 2) Changing the verb to w32-shell-execute (ShellExecute) from "open" > to nil is for some reason I do not know necessary. The answer to why > hides deep within the w32 registry and maybe some knowledgeable > persons at MS... It might be a mismatch of some kind, I don't know. I > believe the verbs are not that well thought out and used all the time. > Probably the registry entry has taken over from the program code > (which give users and other programs better possibilities). > It is likely a misconfiguration on your system. "open" is the standard verb for opening files, and should avoid the security problems associated with using nil for executable file types where the system's default action is something other than "open".