From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#2282: Bug#2282: rmail-summary splits frame into three parts Date: Thu, 12 Nov 2009 09:19:35 +0100 Message-ID: <4AFBC517.40605@gmx.at> References: <4gmy2vxh8z.fsf@fencepost.gnu.org> <19skckxl28.fsf@fencepost.gnu.org> Reply-To: martin rudalics , 2282@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1258014461 7466 80.91.229.12 (12 Nov 2009 08:27:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Nov 2009 08:27:41 +0000 (UTC) Cc: ams@gnu.org To: Glenn Morris , 2282@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 12 09:27:34 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N8V1h-00006b-UY for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Nov 2009 09:27:34 +0100 Original-Received: from localhost ([127.0.0.1]:49083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8V1h-000883-2d for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Nov 2009 03:27:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8V1b-00087o-3M for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2009 03:27:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8V1V-00081s-F4 for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2009 03:27:25 -0500 Original-Received: from [199.232.76.173] (port=40934 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8V1V-00081Y-9D for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2009 03:27:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54909) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N8V1U-0006G7-Od for bug-gnu-emacs@gnu.org; Thu, 12 Nov 2009 03:27:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAC8RIHN007946; Thu, 12 Nov 2009 00:27:18 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAC8P5IZ007678; Thu, 12 Nov 2009 00:25:05 -0800 Resent-Date: Thu, 12 Nov 2009 00:25:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , Rmail Maintainers 2Resent-Date: Thu, 12 Nov 2009 08:25:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2282 X-Emacs-PR-Package: emacs,rmail X-Emacs-PR-Keywords: Original-Received: via spool by 2282-submit@emacsbugs.donarmstrong.com id=B2282.12580139857203 (code B ref 2282); Thu, 12 Nov 2009 08:25:05 +0000 Original-Received: (at 2282) by emacsbugs.donarmstrong.com; 12 Nov 2009 08:19:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id nAC8Jgqg007199 for <2282@emacsbugs.donarmstrong.com>; Thu, 12 Nov 2009 00:19:44 -0800 Original-Received: (qmail invoked by alias); 12 Nov 2009 08:19:36 -0000 Original-Received: from 62-47-61-218.adsl.highway.telekom.at (EHLO [62.47.61.218]) [62.47.61.218] by mail.gmx.net (mp056) with SMTP; 12 Nov 2009 09:19:36 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX198gAs91yF8zLpQ8zBjA3ejo5xQyLTmdPVTAacPPm ctiUGYh+VkSqqV User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <19skckxl28.fsf@fencepost.gnu.org> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 12 Nov 2009 03:27:25 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32559 Archived-At: > I'm tempted to just replace all pop-to-buffers in rmail*.el with > > (defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord) > (let (split-width-threshold) > (pop-to-buffer buffer-or-name other-window norecord))) I suppose the following code in `rmail-new-summary' is responsible for the behavior described earlier. (if (and (one-window-p) pop-up-windows (not pop-up-frames)) ;; If there is just one window, put the summary on the top. (progn (split-window (selected-window) rmail-summary-window-size) (select-window (next-window (frame-first-window))) (pop-to-buffer rmail-summary-buffer) ;; If pop-to-buffer did not use that window, delete that ;; window. (This can happen if it uses another frame.) (if (not (eq rmail-summary-buffer (window-buffer (frame-first-window)))) (delete-other-windows))) (pop-to-buffer rmail-summary-buffer)) What is that code supposed to do what a simple `pop-to-buffer' cannot accomplish? If it's to display the summary on top of the frame, then splitting horizontally obviously won't make sense here. martin