all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Glenn Morris <rgm@gnu.org>, 2282@emacsbugs.donarmstrong.com
Cc: ams@gnu.org
Subject: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 09:19:35 +0100	[thread overview]
Message-ID: <4AFBC517.40605@gmx.at> (raw)
In-Reply-To: <19skckxl28.fsf@fencepost.gnu.org>

 > I'm tempted to just replace all pop-to-buffers in rmail*.el with
 >
 > (defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord)
 >   (let (split-width-threshold)
 >     (pop-to-buffer buffer-or-name other-window norecord)))

I suppose the following code in `rmail-new-summary' is responsible for
the behavior described earlier.

       (if (and (one-window-p)
	       pop-up-windows
	       (not pop-up-frames))
	  ;; If there is just one window, put the summary on the top.
	  (progn
	    (split-window (selected-window) rmail-summary-window-size)
	    (select-window (next-window (frame-first-window)))
	    (pop-to-buffer rmail-summary-buffer)
	    ;; If pop-to-buffer did not use that window, delete that
	    ;; window.  (This can happen if it uses another frame.)
	    (if (not (eq rmail-summary-buffer
			 (window-buffer (frame-first-window))))
		(delete-other-windows)))
	(pop-to-buffer rmail-summary-buffer))

What is that code supposed to do what a simple `pop-to-buffer' cannot
accomplish?  If it's to display the summary on top of the frame, then
splitting horizontally obviously won't make sense here.

martin





  reply	other threads:[~2009-11-12  8:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  2:09 bug#2282: Bug#2282: rmail-summary splits frame into three parts Glenn Morris
2009-11-10  7:48 ` Juri Linkov
2009-11-10 17:59   ` Stefan Monnier
2009-11-11 17:22 ` Alfred M. Szmidt
2009-11-12  7:24   ` Glenn Morris
2009-11-12  8:19     ` martin rudalics [this message]
2009-11-12 15:42       ` Stefan Monnier
2009-11-12 15:41     ` Stefan Monnier
2009-11-12 17:40       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFBC517.40605@gmx.at \
    --to=rudalics@gmx.at \
    --cc=2282@emacsbugs.donarmstrong.com \
    --cc=ams@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.