bug#3928: 23.1.50; compilation-mode not matching perl and more [regression]

bug#3928: 23.1.50; compilation-mode not matching perl and more [regression]

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

Running "emacs -Q etc/compilation.txt" and scrolling down to the perl
section shows none of the sample perl errors matched at all, where I
hoped they would be.

I think the "^" anchor added by compilation-mode-font-lock-keywords
means perl and some other more obscure patterns need a ".*", like they
had back in Emacs 21, to work in the middle of a line.

I noticed this on the perl one.  I thought it was working fine not so
long ago, so I don't know what/when/how it went bad.  (The looseness of
Emacs 22 not anchoring reverted, but the patterns not put back at the
same time too??)


2009-07-25  Kevin Ryde  <user42@zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	In aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*" so
	as to match in the middle of a line, now that there's a "^" anchor is
	again enforced by compilation-mode-font-lock-keywords.  These patterns
	were otherwise failing to match anything at all.
	In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
	it's now unnecessary and since inside a group it isn't recognised by
	the omake indentation hack in compilation-mode-font-lock-keywords
	(meaning it wouldn't work with indentation).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: compile.el.cope-with-anchoring.diff --]
[-- Type: text/x-diff, Size: 3227 bytes --]

*** compile.el	11 Jul 2009 07:12:48 +1000	1.495
--- compile.el	25 Jul 2009 21:55:50 +1000	
***************
*** 173,179 ****
       "\\(warning: .*\\)? at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      " in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
--- 173,179 ----
       "\\(warning: .*\\)? at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      ".* in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
***************
*** 207,213 ****
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
--- 207,213 ----
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(Warning\\)?.* line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
***************
*** 284,292 ****
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      " (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      " in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
--- 284,292 ----
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      ".* (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      ".* in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
***************
*** 308,314 ****
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      " at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
--- 308,314 ----
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      "XXXXXXXXXX.* at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
***************
*** 332,338 ****
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ": \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
--- 332,338 ----
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ".*: \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
***************
*** 345,351 ****
       1 2 nil (4))
  
      (4bsd
!      "\\(?:^\\|::  \\|\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file
--- 345,351 ----
       1 2 nil (4))
  
      (4bsd
!      "^\\(?:\\|.*::  \\|.*\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file

[-- Attachment #3: Type: text/plain, Size: 537 bytes --]




In GNU Emacs 23.1.50.4 (i586-pc-linux-gnu, GTK+ Version 2.16.4)
 of 2009-07-24 on blah.blah
configured using `configure  'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

bug#3928: compilation-mode not matching perl and more [regression]

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

The ada entry is afflicted too (it's supposed to match the second part
of its compilation.txt, its first part is matched by the gnu pattern).
So,

2009-07-27  Kevin Ryde  <user42@zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	In ada, aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*"
	so as to match in the middle of a line, now that there's a "^" anchor
	is again enforced by compilation-mode-font-lock-keywords.  These
	patterns were otherwise failing to match anything at all.
	In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
	it's now unnecessary and since inside a group it isn't recognised by
	the omake indentation hack in compilation-mode-font-lock-keywords
	(meaning it wouldn't work with indentation).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: compile.el.cope-with-anchoring-2.diff --]
[-- Type: text/x-diff, Size: 3370 bytes --]

*** compile.el	11 Jul 2009 07:12:48 +1000	1.495
--- compile.el	26 Jul 2009 14:43:04 +1000	
***************
*** 170,179 ****
  of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
  
      (ada
!      "\\(warning: .*\\)? at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      " in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
--- 170,179 ----
  of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
  
      (ada
!      "\\(warning:\\)?.* at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      ".* in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
***************
*** 207,213 ****
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
--- 207,213 ----
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(Warning\\)?.* line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
***************
*** 284,292 ****
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      " (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      " in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
--- 284,292 ----
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      ".* (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      ".* in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
***************
*** 308,314 ****
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      " at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
--- 308,314 ----
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      "XXXXXXXXXX.* at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
***************
*** 332,338 ****
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ": \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
--- 332,338 ----
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ".*: \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
***************
*** 345,351 ****
       1 2 nil (4))
  
      (4bsd
!      "\\(?:^\\|::  \\|\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file
--- 345,351 ----
       1 2 nil (4))
  
      (4bsd
!      "^\\(?:\\|.*::  \\|.*\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 3283 bytes --]

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:


- Installing emacs 23
- Loading perl-code with errors
- M-x mode-compile

- Effect: The errorlines, filenames and linenumbers are not recognized or
activated in *compilation*

No problem whatsoever with emacs 22 and the same configs!

The problem didn't occure while compiling sh or python files!!!

The problem was reproducible on different machines with Ubuntu 8.04 and 8.10
but not with Windows XP, all with default installation with German
localization.

It was reported NOT to happen with Ubuntu 9.04 on an american machine.

For detailed discussion including a WORKING REGEX-PATCH for mode-compile.el
please look at:

-->
http://groups.google.de/group/gnu.emacs.help/browse_thread/thread/c1a62e304177fefe/9a28488347dd77e7#9a28488347dd77e7

-->
http://groups.google.com/group/emacs-perl-intersection/browse_thread/thread/328823127d1f8b7/8adaceafa79cc216#8adaceafa79cc216

DIAGNOSIS: It seems like the handling of regexes in compile.el changed
considerably from
22 to 23, breaking compatibility with mode-compile.el!!!

A sample perl code to produce 4 error-lines is:
-------------------
use strict;
$a=A;
print $a;
$a=A;
$a=A;
$a=A;
--------------------

> If Emacs crashed ....

No crash!


In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-10-08 on nc10-ubuntu
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
configured using `configure  '--prefix=/home/lanx/lib/emacs-cvs''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Perl

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x m o d e - c o m p i l <tab> <return> <return> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report>

Recent messages:
loading debug.el
leaving debug.el
For information about GNU Emacs and the GNU system, type C-h C-a.
Use M-x make-directory RET RET to create the directory and its parents [2
times]
lade mode-compile.el
Loading cl-macs...done
Loading `mode-compile': old-style backquotes detected!
mode-compile: Compiling in Perl mode ... M-x mode-compile-kill to kill.
(No files need saving)
Compilation exited abnormally with code 255

Load-path shadows:
/home/lanx/lib/emacs-cvs/share/emacs/23.1.50/lisp/progmodes/cperl-mode hides
/home/lanx/.emacs.d/debug/cperl-mode

[-- Attachment #2: Type: text/html, Size: 4152 bytes --]

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

LanX wrote:

> - Installing emacs 23
> - Loading perl-code with errors
> - M-x mode-compile

mode-compile is not part of Emacs.

> - Effect: The errorlines, filenames and linenumbers are not recognized or
> activated in *compilation*
>
> No problem whatsoever with emacs 22 and the same configs!
[...]
> DIAGNOSIS: It seems like the handling of regexes in compile.el
> changed considerably from 22 to 23, breaking compatibility with
> mode-compile.el!!!

Then mode-compile probably needs updating.

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Glenn, as I showed, the behavior  of emacs 23 in this respect is very
inconsistent on different systems.

If mode-compile and cperl-mode need an update it would be only fair to know
to which specification it needs to be updated to!

Or do you think emacs 23 is not an example of consistent software???


2009/10/9 Glenn Morris <rgm@gnu.org>

> LanX wrote:
>
> > - Installing emacs 23
> > - Loading perl-code with errors
> > - M-x mode-compile
>
> mode-compile is not part of Emacs.
>
> > - Effect: The errorlines, filenames and linenumbers are not recognized or
> > activated in *compilation*
> >
> > No problem whatsoever with emacs 22 and the same configs!
> [...]
> > DIAGNOSIS: It seems like the handling of regexes in compile.el
> > changed considerably from 22 to 23, breaking compatibility with
> > mode-compile.el!!!
>
> Then mode-compile probably needs updating.
>

[-- Attachment #2: Type: text/html, Size: 1228 bytes --]

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

PS please don't cc the original authors when reporting bugs.

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

2009/10/9 Glenn Morris <rgm@gnu.org>

>
> PS please don't cc the original authors when reporting bugs.
>

OK, but I just replied to all recipients of your mail...

Sorry, I've spend much time to isolate that bug and I don't wanna be part of
any kind of  xemacs vs emacs flame war in response.

compile.el of emacs 23 acts inconsistently and I think if it's due to
different system or unicode settings it's only  one incarnation of a bigger
underlying bug, one could be worried of ...

[-- Attachment #2: Type: text/html, Size: 778 bytes --]

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

LanX wrote:

> OK, but I just replied to all recipients of your mail...

Yes, I first replied to your original report without noticing that you
had cc'd the authors of compile.el.

> Sorry, I've spend much time to isolate that bug and I don't wanna be
> part of any kind of xemacs vs emacs flame war in response.

Nobody has mentioned XEmacs. I was asking you not to bother the
blameless original authors of compile.el, one of whom has not touched
the code in over 12 years.

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

Glenn,

Neither mode-compile nor cperl-mode are necessary to reproduce the problem.

And after 12 years a maintainer might perhaps consider to delete his email
address.

Anyway I met Daniel Pfeiffer on the last German Perl Workshop,  I'm going to
provide him directly with more detailed infos in German.

No need to bother you longer...

Thanx for your help!
  Bye


2009/10/9 Glenn Morris <rgm@gnu.org>

> LanX wrote:
>
> > OK, but I just replied to all recipients of your mail...
>
> Yes, I first replied to your original report without noticing that you
> had cc'd the authors of compile.el.
>
> > Sorry, I've spend much time to isolate that bug and I don't wanna be
> > part of any kind of xemacs vs emacs flame war in response.
>
> Nobody has mentioned XEmacs. I was asking you not to bother the
> blameless original authors of compile.el, one of whom has not touched
> the code in over 12 years.
>

[-- Attachment #2: Type: text/html, Size: 1305 bytes --]

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

LanX wrote:

> Neither mode-compile nor cperl-mode are necessary to reproduce the problem.

OK. If you want someone on this list to help fix anything, then the
way to go about it is to provide a complete, self-contained recipe
starting from `emacs -Q'. This does not seem to exist anywhere in
either of the two linked threads which I took the trouble to read.

> And after 12 years a maintainer might perhaps consider to delete his email
> address.

We leave the original Author: header intact to respect people's
contribution. Note that the Maintainer: header says "FSF".

None of this is at all revelant though, because the documented
procedure for reporting an Emacs bug is to use M-x report-emacs-bug.
That is all. Do not cc every email address you might find in the
source files.

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Jason Rumney]

LanX wrote:
> compile.el of emacs 23 acts inconsistently
Then please file a bug report about that inconsistency, rather than 
reporting a bug in mode-compile, which is not part of Emacs.

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Heddy Boubaker]

hi guys

I'm the original developer of mode-compile but unfortunately I do not use it 
almost for years now, and I even forgot almost anything about elisp :) (my only 
use of emacs is to edit html & css files now).

If somebody have the courage to maintain it, it will be with great pleasure.

best

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Heddy

I doubt that mode-compile is to blame, neither of the following combination
succeeds in capturing and activating the error-lines, like it does with
emacs 22:

:~$ emacs-23.1.50 -Q -debug-init -no-site-file  ~/tst.pl -f cperl-mode
--eval='(compile "perl ~/tst.pl")'
:~$ emacs-23.1.50 -Q -debug-init -no-site-file  ~/tst.pl -f perl-mode
--eval='(compile "perl ~/tst.pl")'

Si tu cherche quelqun pour continuer mode-compile: A mon avis il sera mieux
de demander a gnu.emac.help. Ici en insiste seulment que c'est pas un part
integral de emacs.

De toute facon merci bien pour mode-compile!!! :-)

Bye
  Rolf

[-- Attachment #2: Type: text/html, Size: 813 bytes --]

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

merge 4689 3928
stop

LanX wrote:

> :~$ emacs-23.1.50 -Q -debug-init -no-site-file  ~/tst.pl -f cperl-mode
> --eval='(compile "perl ~/tst.pl")'

Thanks. If only we could have started here.

I guess this is a duplicate of bug#3928. (The patch in that report has
some issues, eg XXX in the perl part.)

Processed: Re: bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Emacs bug Tracking System]

Processing commands for control@emacsbugs.donarmstrong.com:

> merge 4689 3928
bug#3928: 23.1.50; compilation-mode not matching perl and more [regression]
bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken  for perl-files
Merged 3928 4689.

> stop
Stopping processing here.

Please contact me if you need assistance.

Don Armstrong
(administrator, Emacs bugs database)

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Juanma Barranquero]

On Mon, Oct 12, 2009 at 16:26, LanX <lanx.perl@googlemail.com> wrote:

> Ici en insiste seulment que c'est pas un part
> integral de emacs.

And for a good reason.

If you really think it is a bug in Emacs, please send precise,
complete instructions, starting from "emacs -Q" and including anything
needed to reproduce it.

    Juanma

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[Glenn Morris]

Oh, and it seems when you said "emacs 23", you meant "CVS trunk".

bug#4689: 23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files

[LanX]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

2009/10/12 Glenn Morris <rgm@gnu.org>

>
> Oh, and it seems when you said "emacs 23", you meant "CVS trunk".
>

Yes ... 23.1.50 is indeed not considered stable...

To be sure, I just installed GNU Emacs 23.1.1, which doesn't show any of
these problems.

Sorry, Googling for "emacs 23 install" predominantly leads to advices for
"CVS trunk" installations, even including complete ubuntu packages, which I
have trouble to find for the stable release...

[-- Attachment #2: Type: text/html, Size: 762 bytes --]

bug#3928: marked as done (23.1.50; compilation-mode not matching perl and more [regression])

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Your message dated Mon, 12 Oct 2009 23:39:58 -0400
with message-id <uy8wfgt10x.fsf_-_@fencepost.gnu.org>
and subject line Re: Bug#3928
has caused the Emacs bug report #3928,
regarding 23.1.50; compilation-mode not matching perl and more [regression]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3928: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3928
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7512 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1215 bytes --]

Running "emacs -Q etc/compilation.txt" and scrolling down to the perl
section shows none of the sample perl errors matched at all, where I
hoped they would be.

I think the "^" anchor added by compilation-mode-font-lock-keywords
means perl and some other more obscure patterns need a ".*", like they
had back in Emacs 21, to work in the middle of a line.

I noticed this on the perl one.  I thought it was working fine not so
long ago, so I don't know what/when/how it went bad.  (The looseness of
Emacs 22 not anchoring reverted, but the patterns not put back at the
same time too??)


2009-07-25  Kevin Ryde  <user42@zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	In aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*" so
	as to match in the middle of a line, now that there's a "^" anchor is
	again enforced by compilation-mode-font-lock-keywords.  These patterns
	were otherwise failing to match anything at all.
	In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
	it's now unnecessary and since inside a group it isn't recognised by
	the omake indentation hack in compilation-mode-font-lock-keywords
	(meaning it wouldn't work with indentation).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: compile.el.cope-with-anchoring.diff --]
[-- Type: text/x-diff, Size: 3227 bytes --]

*** compile.el	11 Jul 2009 07:12:48 +1000	1.495
--- compile.el	25 Jul 2009 21:55:50 +1000	
***************
*** 173,179 ****
       "\\(warning: .*\\)? at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      " in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
--- 173,179 ----
       "\\(warning: .*\\)? at \\([^ \n]+\\):\\([0-9]+\\)$" 2 3 nil (1))
  
      (aix
!      ".* in line \\([0-9]+\\) of file \\([^ \n]+[^. \n]\\)\\.? " 2 1)
  
      (ant
       "^[ \t]*\\[[^] \n]+\\][ \t]*\\([^: \n]+\\):\\([0-9]+\\):\\(?:\\([0-9]+\\):[0-9]+:[0-9]+:\\)?\
***************
*** 207,213 ****
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
--- 207,213 ----
       "^Error [0-9]+ at (\\([0-9]+\\):\\([^)\n]+\\))" 2 1)
  
      (ftnchek
!      "\\(Warning\\)?.* line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)"
       4 2 3 (1))
  
      (iar
***************
*** 284,292 ****
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      " (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      " in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
--- 284,292 ----
  
      ;; Should be lint-1, lint-2 (SysV lint)
      (mips-1
!      ".* (\\([0-9]+\\)) in \\([^ \n]+\\)" 2 1)
      (mips-2
!      ".* in \\([^()\n ]+\\)(\\([0-9]+\\))$" 1 2)
  
      (msft
       ;; AFAWK, The message may be a "warning", "error", or "fatal error".
***************
*** 308,314 ****
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      " at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
--- 308,314 ----
      ;; warnings" in recent perl when breaking circular references
      ;; during program or thread exit.
      (perl
!      "XXXXXXXXXX.* at \\([^ \n]+\\) line \\([0-9]+\\)\\(?:[,.]\\|$\\| \
  during global destruction\\.$\\)" 1 2)
  
      (php
***************
*** 332,338 ****
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ": \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
--- 332,338 ----
       nil 1 nil (3) nil (2 (compilation-face '(3))))
  
      (sun
!      ".*: \\(?:ERROR\\|WARNIN\\(G\\)\\|REMAR\\(K\\)\\) \\(?:[[:alnum:] ]+, \\)?\
  File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
       3 4 5 (1 . 2))
  
***************
*** 345,351 ****
       1 2 nil (4))
  
      (4bsd
!      "\\(?:^\\|::  \\|\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file
--- 345,351 ----
       1 2 nil (4))
  
      (4bsd
!      "^\\(?:\\|.*::  \\|.*\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))
  
      (gcov-file

[-- Attachment #2.1.3: Type: text/plain, Size: 537 bytes --]




In GNU Emacs 23.1.50.4 (i586-pc-linux-gnu, GTK+ Version 2.16.4)
 of 2009-07-24 on blah.blah
configured using `configure  'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

[-- Attachment #3: Type: message/rfc822, Size: 1889 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 3928-done@emacsbugs.donarmstrong.com
Subject: Re: Bug#3928
Date: Mon, 12 Oct 2009 23:39:58 -0400
Message-ID: <uy8wfgt10x.fsf_-_@fencepost.gnu.org>


Fixed by this change:

2009-10-12  Sam Steingold  <sds at gnu.org>

* progmodes/compile.el (compilation-mode-font-lock-keywords): Do not
  prepend "^ *" to non-anchored patterns, like the perl one (bug#3928).

bug#4689: marked as done (23.1.50; Matching of error lines in *compilation* buffer is broken for perl-files)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

Your message dated Mon, 12 Oct 2009 23:39:58 -0400
with message-id <uy8wfgt10x.fsf_-_@fencepost.gnu.org>
and subject line Re: Bug#3928
has caused the Emacs bug report #3928,
regarding 23.1.50; Matching of error lines in *compilation* buffer is broken  for perl-files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3928: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3928
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 10753 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 3283 bytes --]

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:


- Installing emacs 23
- Loading perl-code with errors
- M-x mode-compile

- Effect: The errorlines, filenames and linenumbers are not recognized or
activated in *compilation*

No problem whatsoever with emacs 22 and the same configs!

The problem didn't occure while compiling sh or python files!!!

The problem was reproducible on different machines with Ubuntu 8.04 and 8.10
but not with Windows XP, all with default installation with German
localization.

It was reported NOT to happen with Ubuntu 9.04 on an american machine.

For detailed discussion including a WORKING REGEX-PATCH for mode-compile.el
please look at:

-->
http://groups.google.de/group/gnu.emacs.help/browse_thread/thread/c1a62e304177fefe/9a28488347dd77e7#9a28488347dd77e7

-->
http://groups.google.com/group/emacs-perl-intersection/browse_thread/thread/328823127d1f8b7/8adaceafa79cc216#8adaceafa79cc216

DIAGNOSIS: It seems like the handling of regexes in compile.el changed
considerably from
22 to 23, breaking compatibility with mode-compile.el!!!

A sample perl code to produce 4 error-lines is:
-------------------
use strict;
$a=A;
print $a;
$a=A;
$a=A;
$a=A;
--------------------

> If Emacs crashed ....

No crash!


In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-10-08 on nc10-ubuntu
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
configured using `configure  '--prefix=/home/lanx/lib/emacs-cvs''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Perl

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x m o d e - c o m p i l <tab> <return> <return> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report>

Recent messages:
loading debug.el
leaving debug.el
For information about GNU Emacs and the GNU system, type C-h C-a.
Use M-x make-directory RET RET to create the directory and its parents [2
times]
lade mode-compile.el
Loading cl-macs...done
Loading `mode-compile': old-style backquotes detected!
mode-compile: Compiling in Perl mode ... M-x mode-compile-kill to kill.
(No files need saving)
Compilation exited abnormally with code 255

Load-path shadows:
/home/lanx/lib/emacs-cvs/share/emacs/23.1.50/lisp/progmodes/cperl-mode hides
/home/lanx/.emacs.d/debug/cperl-mode

[-- Attachment #2.1.2: Type: text/html, Size: 4152 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 1889 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 3928-done@emacsbugs.donarmstrong.com
Subject: Re: Bug#3928
Date: Mon, 12 Oct 2009 23:39:58 -0400
Message-ID: <uy8wfgt10x.fsf_-_@fencepost.gnu.org>


Fixed by this change:

2009-10-12  Sam Steingold  <sds at gnu.org>

* progmodes/compile.el (compilation-mode-font-lock-keywords): Do not
  prepend "^ *" to non-anchored patterns, like the perl one (bug#3928).