From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#4543: window-full-height-p Date: Sat, 26 Sep 2009 21:01:36 +0200 Message-ID: <4ABE6510.90508@gmx.at> References: <4ABB19F5.50908@gmx.at> <4ABC73DB.1060308@gmx.at> <83vdj7tlup.fsf@gnu.org> <4ABCBEC7.70901@gmx.at> <4ABDE2C5.2070808@gmx.at> <83vdj6rllk.fsf@gnu.org> <4ABE1A25.7050909@gmx.at> <83pr9dsmbd.fsf@gnu.org> Reply-To: martin rudalics , 4543@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1253993247 24917 80.91.229.12 (26 Sep 2009 19:27:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Sep 2009 19:27:27 +0000 (UTC) Cc: 4543@emacsbugs.donarmstrong.com, monnier@IRO.UMontreal.CA To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 26 21:27:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MrcvP-00055q-DM for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 21:27:19 +0200 Original-Received: from localhost ([127.0.0.1]:60448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrcvO-0002AM-RI for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 15:27:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrcvK-0002A6-DC for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 15:27:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrcvF-00025s-SF for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 15:27:13 -0400 Original-Received: from [199.232.76.173] (port=41260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrcvF-00025n-LB for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 15:27:09 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36975) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrcvE-00073H-Vr for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 15:27:09 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8QJR51A003054; Sat, 26 Sep 2009 12:27:06 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8QJA5Cs032749; Sat, 26 Sep 2009 12:10:05 -0700 Resent-Date: Sat, 26 Sep 2009 12:10:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 26 Sep 2009 19:10:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4543 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4543-submit@emacsbugs.donarmstrong.com id=B4543.125399170930771 (code B ref 4543); Sat, 26 Sep 2009 19:10:05 +0000 Original-Received: (at 4543) by emacsbugs.donarmstrong.com; 26 Sep 2009 19:01:49 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8QJ1lH5030768 for <4543@emacsbugs.donarmstrong.com>; Sat, 26 Sep 2009 12:01:48 -0700 Original-Received: (qmail invoked by alias); 26 Sep 2009 19:01:40 -0000 Original-Received: from 62-47-38-202.adsl.highway.telekom.at (EHLO [62.47.38.202]) [62.47.38.202] by mail.gmx.net (mp011) with SMTP; 26 Sep 2009 21:01:40 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+gpF11A0+grK91depmD34USJ0xAZR8j94vywSua6 Sf53uXuts5Zrfz User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <83pr9dsmbd.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 26 Sep 2009 15:27:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31536 Archived-At: >> > Why doesn't it make sense? The computed value of new_frame_total_cols >> > is used to enlarge only the frame's root window: >> > >> > if (new_frame_total_cols != FRAME_TOTAL_COLS (f)) >> > { >> > set_window_width (FRAME_ROOT_WINDOW (f), new_frame_total_cols, 2); >> > >> > And for the root window, FRAME_TOTAL_COLS is correct, I think. The >> > window configuration, however complex, does not affect the root >> > window, does it? >> >> With Emacs -Q I can evaluate >> >> (set-window-scroll-bars nil 0 nil) >> >> to remove the scroll bar from the *scratch* window keeping the window >> size unaltered. When I now evaluate >> >> (scroll-bar-mode -1) >> >> the width of the frame shrinks and with it the number of columns used >> for text in the *scratch* window. This doesn't make sense. > > Agreed. But I must be missing something because I don't see how this > behavior is related to the code you quoted above. Indeed. The above quotation should have started with >> The problem I see is that the value for new_frame_total_cols >> calculated by change_frame_size_1 as >> >> /* Compute width of windows in F. >> This is the width of the frame without vertical scroll bars. */ >> new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth); >> >> /* Round up to the smallest acceptable size. */ >> check_frame_size (f, &newheight, &newwidth); >> >> doesn't make sense for more complex window configurations. in order to make clear that the assignment to new_frame_total_cols is reponsible for the behavior I sketched. Or the fact that setting `scroll-bar-mode' may trigger frame-resizing in the first place. martin