From: Andreas Roehler <andreas.roehler@online.de>
To: XEmacs-Beta@xemacs.org
Cc: emacs-devel@gnu.org
Subject: simplifying beginning-of-defun
Date: Sat, 26 Sep 2009 19:52:57 +0200 [thread overview]
Message-ID: <4ABE54F9.7090107@online.de> (raw)
Hi,
simplifying forms as below should ease maintenance and speed up execution.
With var `beginning-of-defun-function' its not
necessary to fix all at once at a single place: progmodes
may write their own functions and M-x
`beginning-of-defun' will work with them.
Just to present the code for the moment. If agreed so
far, I'll send a patch next days.
Cheers
Andreas
--
https://code.launchpad.net/s-x-emacs-werkstatt/
http://bazaar.launchpad.net/~a-roehler/python-mode/python-mode.el/
;;;;;;;;;;;
;; Works with XEmacs as with GNU.
;; GNU-folks:
;; de-comment line below before checking. GNU's lisp.el
;; sets this var globally, which seems not useful for me...
;; (setq end-of-defun-function nil)
(setq defun-searchform '(if defun-prompt-regexp
(concat "^\\s(\\|"
"\\(" defun-prompt-regexp "\\)\\s(")
"^\\s("))
(defun beginning-of-defun (&optional arg)
"Move backward to the beginning of a functions definition. "
(interactive "P")
(or arg (setq arg 1))
(if beginning-of-defun-function
(funcall beginning-of-defun-function arg)
(beginning-of-defun-raw arg)))
(defun beginning-of-defun-raw (&optional arg)
"Called if progmodes didn't set beginning-of-defun-function. "
(when
(re-search-backward (eval defun-searchform) nil 'move (or arg 1))
(goto-char (match-beginning 0))))
(defun end-of-defun (&optional arg)
"Move backward to the end of a function. "
(interactive "P")
(or arg (setq arg 1))
(if end-of-defun-function
(funcall end-of-defun-function arg)
(end-of-defun-raw arg)))
(defun end-of-defun-raw (&optional arg)
"Called if progmodes didn't set end-of-defun-function. "
(unless (looking-at (eval defun-searchform))
(beginning-of-defun 1))
(forward-sexp 1)
(when (re-search-forward (eval defun-searchform) nil t arg)
(goto-char (match-beginning 0))
(forward-sexp 1)))
;;;;;;;
next reply other threads:[~2009-09-26 17:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 17:52 Andreas Roehler [this message]
2009-09-26 21:44 ` simplifying beginning-of-defun Stefan Monnier
2009-09-27 8:10 ` Andreas Roehler
2009-09-27 18:40 ` Stefan Monnier
2009-09-28 6:50 ` Andreas Roehler
2009-09-28 22:46 ` Stefan Monnier
2009-09-29 6:53 ` Andreas Roehler
2009-09-29 8:29 ` Andreas Roehler
2009-09-27 10:26 ` Andreas Roehler
2009-09-27 11:17 ` Eric M. Ludlam
2009-09-27 18:53 ` Stefan Monnier
2009-09-27 20:07 ` Eric M. Ludlam
2009-09-27 22:52 ` Stefan Monnier
2009-09-28 2:04 ` Eric M. Ludlam
2009-09-28 4:06 ` Stefan Monnier
2009-09-28 11:20 ` Eric M. Ludlam
2009-09-29 6:50 ` Alan Mackenzie
2009-09-27 19:06 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABE54F9.7090107@online.de \
--to=andreas.roehler@online.de \
--cc=XEmacs-Beta@xemacs.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.