all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 4534@emacsbugs.donarmstrong.com
Subject: bug#4534: assertion failure at window.c:grow_mini_window
Date: Thu, 24 Sep 2009 17:32:22 +0200	[thread overview]
Message-ID: <4ABB9106.1090306@gmx.at> (raw)
In-Reply-To: <f7ccd24b0909240558n3f1e1b25qaa06db7035459cf9@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

 >>              shrink_mini_window (w);
 >>              ... should resize the mini_window down to one line ...
 >
 > That's exactly what happens, except that shrink_mini_window (w) does
 > *not* resize the miniwindow; it's still 6 lines height. So

Too bad.  Anyway, this configuration is completely useless to get the
original sizes back when we're done with the miniwindow.  Could you try
brute force as in the untested patch attached?

martin

[-- Attachment #2: xdisp.c.diff --]
[-- Type: text/plain, Size: 1295 bytes --]

*** xdisp.c.~1.1295.~	2009-08-20 10:47:19.687500000 +0200
--- xdisp.c	2009-09-24 17:23:23.937500000 +0200
***************
*** 8789,8816 ****
  	}
        else
  	{
! 	  /* Always resize to exact size needed.  */
! 	  if (height > WINDOW_TOTAL_LINES (w))
! 	    {
! 	      int old_height = WINDOW_TOTAL_LINES (w);
! 	      freeze_window_starts (f, 1);
! 	      grow_mini_window (w, height - WINDOW_TOTAL_LINES (w));
! 	      window_height_changed_p = WINDOW_TOTAL_LINES (w) != old_height;
! 	    }
! 	  else if (height < WINDOW_TOTAL_LINES (w))
! 	    {
! 	      int old_height = WINDOW_TOTAL_LINES (w);
! 	      freeze_window_starts (f, 0);
! 	      shrink_mini_window (w);
! 
! 	      if (height)
! 		{
! 		  freeze_window_starts (f, 1);
! 		  grow_mini_window (w, height - WINDOW_TOTAL_LINES (w));
! 		}
! 
! 	      window_height_changed_p = WINDOW_TOTAL_LINES (w) != old_height;
! 	    }
  	}
  
        if (old_current_buffer)
--- 8789,8799 ----
  	}
        else
  	{
! 	  int old_height = WINDOW_TOTAL_LINES (w);
! 	  freeze_window_starts (f, 1);
! 	  shrink_mini_window (w);
! 	  grow_mini_window (w, height - WINDOW_TOTAL_LINES (w));
! 	  window_height_changed_p = WINDOW_TOTAL_LINES (w) != old_height;
  	}
  
        if (old_current_buffer)

  reply	other threads:[~2009-09-24 15:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b0910260305i10204d17hbdbfe72251d740f1@mail.gmail.com>
2009-09-23  3:02 ` bug#4534: assertion failure at window.c:grow_mini_window Juanma Barranquero
2009-09-23  7:28   ` martin rudalics
2009-09-23  9:50     ` Juanma Barranquero
2009-09-23 10:51       ` Juanma Barranquero
2009-09-23 12:21         ` martin rudalics
2009-09-23 13:42           ` Juanma Barranquero
2009-09-24  6:49             ` martin rudalics
2009-09-23 12:21       ` martin rudalics
2009-09-23 13:41         ` Juanma Barranquero
2009-09-24  6:49           ` martin rudalics
2009-09-24 12:58             ` Juanma Barranquero
2009-09-24 15:32               ` martin rudalics [this message]
2009-09-24 15:53                 ` Juanma Barranquero
2009-09-24 16:10                   ` martin rudalics
2009-09-24 16:22                     ` Juanma Barranquero
2009-09-24 17:35                       ` martin rudalics
2009-09-24 17:45                         ` Juanma Barranquero
2009-09-24 22:03                         ` Stefan Monnier
2009-09-25 18:02                           ` Juanma Barranquero
2009-10-16  8:32                             ` Juanma Barranquero
2009-10-24 15:37                               ` Juanma Barranquero
2009-09-24 17:36                   ` Stefan Monnier
2009-09-25  8:35               ` Eli Zaretskii
2009-09-25 11:30                 ` Juanma Barranquero
2009-09-25 13:14                   ` Eli Zaretskii
2009-09-25 14:08                     ` Juanma Barranquero
2009-10-26 10:10   ` bug#4534: marked as done (assertion failure at window.c:grow_mini_window) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABB9106.1090306@gmx.at \
    --to=rudalics@gmx.at \
    --cc=4534@emacsbugs.donarmstrong.com \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.