From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#4534: assertion failure at window.c:grow_mini_window Date: Wed, 23 Sep 2009 14:21:39 +0200 Message-ID: <4ABA12D3.3060507@gmx.at> References: <4AB9CE11.9040300@gmx.at> Reply-To: martin rudalics , 4534@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1253710705 20407 80.91.229.12 (23 Sep 2009 12:58:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Sep 2009 12:58:25 +0000 (UTC) Cc: 4534@emacsbugs.donarmstrong.com To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 23 14:58:18 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MqRQH-0006CT-L4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Sep 2009 14:58:17 +0200 Original-Received: from localhost ([127.0.0.1]:50871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqRQG-00006A-SR for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Sep 2009 08:58:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqRHe-0006tq-F3 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 08:49:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqRHX-0006sF-A0 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 08:49:21 -0400 Original-Received: from [199.232.76.173] (port=59135 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqRHX-0006s7-3D for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 08:49:15 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49754) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqRHW-0008LS-HF for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 08:49:14 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NCl3VM025610; Wed, 23 Sep 2009 05:47:03 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8NCU9Ww023223; Wed, 23 Sep 2009 05:30:09 -0700 Resent-Date: Wed, 23 Sep 2009 05:30:09 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 23 Sep 2009 12:30:09 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4534 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4534-submit@emacsbugs.donarmstrong.com id=B4534.125370850922114 (code B ref 4534); Wed, 23 Sep 2009 12:30:09 +0000 Original-Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 12:21:49 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8NCLl5m022110 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 05:21:49 -0700 Original-Received: (qmail invoked by alias); 23 Sep 2009 12:21:40 -0000 Original-Received: from 62-47-54-210.adsl.highway.telekom.at (EHLO [62.47.54.210]) [62.47.54.210] by mail.gmx.net (mp008) with SMTP; 23 Sep 2009 14:21:40 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/rp+5uwyfrU1cGctB5c53mqwPonLBE3cvDu4/1/9 q9c1iYQmbcsZah User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.57 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 23 Sep 2009 08:49:19 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31402 Archived-At: > FWIW, commenting out this chunk from shrink_mini_window, it works as expected. > > Juanma > > > > diff --git a/src/window.c b/src/window.c > index 08fd8c8..c892436 100644 > --- a/src/window.c > +++ b/src/window.c > @@ -4677,17 +4677,18 @@ void > shrink_mini_window (w) > struct window *w; > { > - struct frame *f = XFRAME (w->frame); > - struct window *root = XWINDOW (FRAME_ROOT_WINDOW (f)); > - > - if (save_restore_orig_size (root, CHECK_ORIG_SIZES)) > - { > - save_restore_orig_size (root, RESTORE_ORIG_SIZES); > - adjust_glyphs (f); > - FRAME_WINDOW_SIZES_CHANGED (f) = 1; > - windows_or_buffers_changed = 1; > - } > - else if (XFASTINT (w->total_lines) > 1) This would make the whole save/restore code obsolete. Unfortunately, the resulting alternative (enlarge_window) is even worse because it might delete windows (when it tries to enlarge them) :-( martin