bug#3174: "italic" is underlined now (NS?)

[David Reitter <david.reitter@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

On Jun 14, 2009, at 11:53 AM, Adrian Robert wrote:
>
> OK, but the behavior makes the way I set up ns_attribute_value()  
> pretty much useless, so does the below work on your system?  (Sorry  
> I have no Leopard to test.)

OK, this seems to work for Monaco.

However...

I identified (using Font Book) a font (Garamond) that seems to have  
its own Italic variant.

I then did M-x customize-face RET default RET and switched to Garamond  
14pt.

Looking at some italic text (\emph{...} in a latex-mode buffer), C-u C- 
x = gives me:

           display: by this font (glyph code)
     nil:-apple-Garamond-medium-italic-normal-synthItal-14-*-*-*-p-0- 
iso10646-1 (#x57)
There are text properties here:
   charset              iso-8859-1
   face                 (italic)
   fontified            t


Why is this synthItal?
Shouldn't it use the provided font?

Some debugging reveals that it can't see the italics because your  
[-0.25;0.25] bracket is too strict (that's +-7.5 degrees - a  
reasonable minimum).

     #<font-entity ns apple Garamond nil iso10646-1 medium italic  
normal 0 nil 0 0 ((:name))>
2009-06-14 13:31:42.779 Aquamacs[40351:813] no ital found - 0.06944444
created font_entity:
     #<font-entity ns apple Garamond nil iso10646-1 medium italic  
normal 0 nil 0 0 ((:name))>
2009-06-14 13:31:42.779 Aquamacs[40351:813] no ital found - 0.06944444
created font_entity:
     #<font-entity ns apple Garamond nil iso10646-1 medium italic  
normal 0 nil 0 0 ((:name))>
2009-06-14 13:31:42.780 Aquamacs[40351:813] no ital found - 0.06944444

So I'm changing this to

static BOOL
ns_has_attribute (NSFontDescriptor *fdesc, NSString *trait)
{
     float v = ns_attribute_fvalue (fdesc, trait);
     return v < -0.05 || v > 0.05;
}

How I get

  nil:-apple-Garamond-medium-italic-normal-*-14-*-*-*-p-0-iso10646-1  
(#x4C)


and Garamond italic looks noticeably better.  The synthetic italic  
slant was quite a bit too slanted.

Hope we've got it nailed now.

- David

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]