From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: face-remap.el patch to resize window Date: Mon, 10 Aug 2009 10:00:24 -0700 Message-ID: <4AA53AB1A08C45E694CE138273DE59E8@us.oracle.com> References: <7D6750DD60204DB082A761ECEE706CEA@us.oracle.com><2DD5D9B518394F17A3AA77158B671255@us.oracle.com> <871vnkfee9.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1249923741 7288 80.91.229.12 (10 Aug 2009 17:02:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Aug 2009 17:02:21 +0000 (UTC) Cc: 'Stefan Monnier' , emacs-devel@gnu.org To: "'Miles Bader'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 10 19:02:14 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MaYGD-0005Iu-LK for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2009 19:02:13 +0200 Original-Received: from localhost ([127.0.0.1]:41495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaYGC-0007jo-Sj for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2009 13:02:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaYEg-0007Ov-Oj for emacs-devel@gnu.org; Mon, 10 Aug 2009 13:00:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaYEc-0007LY-8P for emacs-devel@gnu.org; Mon, 10 Aug 2009 13:00:38 -0400 Original-Received: from [199.232.76.173] (port=49136 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaYEb-0007LN-Un for emacs-devel@gnu.org; Mon, 10 Aug 2009 13:00:33 -0400 Original-Received: from acsinet12.oracle.com ([141.146.126.234]:17299) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MaYEZ-0004A6-CZ; Mon, 10 Aug 2009 13:00:31 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7AH00bT017593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Aug 2009 17:00:01 GMT Original-Received: from abhmt003.oracle.com (abhmt003.oracle.com [141.146.116.12]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7AH0vN9017715; Mon, 10 Aug 2009 17:00:57 GMT Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2009 10:00:24 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcoZeFn8tq9BINzLRdy/iAx53/HDkAAW1Jzg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 In-Reply-To: <871vnkfee9.fsf@catnip.gol.com> X-Source-IP: abhmt003.oracle.com [141.146.116.12] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010206.4A805229.00E6:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113981 Archived-At: > What do you think of the following patch, which is an alternative > approach based on hooks? > > Basically to get the behavior you want, you can do: > (add-hook 'text-scale-mode-hook > 'text-scale-mode-adjust-window-size) If that's what it takes to get such a feature added, fine; please go for it. I don't, however see any advantage of your hook hack over the patch I sent. And you didn't cite any. On the contrary, I see disadvantages of your approach: 1. The means of changing the setting (say from vertical to horizontal size adjustment) is, well, removing and adding hook functions. Why make users do that? With my patch, you can easily change the option value on the fly using, say, `set-variable'. 2. What's more, a user could make the option buffer-local, and so have window-resizing behavior be buffer-specific: don't resize, resize horizontally, vertically, or both. At any rate, for my personal use I already have what I need, so if you want to add your patch to Emacs, I'm in favor.