all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>,
	"'martin rudalics'" <rudalics@gmx.at>
Cc: 8853@debbugs.gnu.org
Subject: bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame'
Date: Wed, 29 Jun 2011 09:58:00 -0700	[thread overview]
Message-ID: <4AA39217E3614221A83B57889B1DF7EE@us.oracle.com> (raw)
In-Reply-To: <yyxboxtod57.fsf@fencepost.gnu.org>

> >> This regression was introduced in release 23.1.  Prior to 
> >> that release, the doc string said, correctly,
> >> "If ARGS is a list whose car is a symbol, use (car ARGS) 
> >> as a function to do the work.  Pass it BUFFER as first arg,
> >> and (cdr ARGS) as the rest of its args."

What's important here is "as the _rest_ of its args".

> >> Now it says, incorrectly, "If ARGS is a list whose car
> >> is a symbol, use (car ARGS) as a function to do the work.
> >> Pass it BUFFER as first argument, and (cdr ARGS) as second."
> >>
> >> If ARGS is a list whose car is a symbol `f', then
> >> `special-display-popup-frame' invokes `f', passing it as
> >> arguments, BUFFER followed by all of the elements in
> >> (cdr ARGS).  The arity of `f' is the length of ARGS, not
> >> just 2.  We do not pass `f' (cdr ARGS) as a second argument.
> >
> > Indeed.  Could someone please restore the old doc-string in 
> > Emacs 23?
> 
> Fixed.

No, I do not see this fixed in the latest Windows build of Emacs 24:

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-06-27 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'

It still says: "Pass it BUFFER as first argument, and (cdr ARGS) as second."

The point of the bug fix should be to replace "as second" by "as the rest of its
args" or equivalent.  Thx.






  reply	other threads:[~2011-06-29 16:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13 17:11 bug#8853: 24.0.50; regression: doc string of `special-display-popup-frame' Drew Adams
2011-06-14  9:15 ` martin rudalics
2011-06-19 19:05   ` Chong Yidong
2011-06-29 16:58     ` Drew Adams [this message]
2011-06-29 23:16       ` Glenn Morris
2012-08-10 16:47         ` Drew Adams
2012-09-16  4:45       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA39217E3614221A83B57889B1DF7EE@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=8853@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.