From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 4310@emacsbugs.donarmstrong.com
Subject: bug#4310: Flymake standardizing(slightly) patch
Date: Thu, 03 Sep 2009 08:23:31 -0400 [thread overview]
Message-ID: <4A9FB543.10708@gmail.com> (raw)
In-Reply-To: <4pljkwbm76.fsf@fencepost.gnu.org>
Ah right. I missed that part of the documentation. Noob mistake.
However, this brings me to a question, since all the initialization is
essentially done before flymake finally runs syntax check at the end of
the minor mode definition. If I want to run the minor mode hook before
syntax check, but not after, what should I do?
Also, I'd imagine some people might want to do something after syntax
check is done too, like echoing to the minibuffer, or automatically jump
to the first line of error etc. That means I should probably add a
post-syntax-check hook. But it seems rather complicated due to the
number of cases in which it may fail. Any suggestions?
Glenn Morris wrote:
> Jimmy Yuen Ho Wong wrote:
>
>> I've added a default keymap and a minor-mode hook to flymake
>
> With regards to the hook part, it already runs flymake-mode-hook, as
> you can see eg by:
>
> (add-hook 'flymake-mode-hook (lambda () (error "foo")))
>
> The define-minor-mode macro takes care of this. There is no need for a
> hook to be defvar'd before use.
next prev parent reply other threads:[~2009-09-03 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 5:25 bug#4310: Flymake standardizing(slightly) patch Jimmy Yuen Ho Wong
2009-09-03 6:02 ` Glenn Morris
2009-09-03 12:23 ` Jimmy Yuen Ho Wong [this message]
2009-09-03 13:43 ` Stefan Monnier
2009-09-04 5:13 ` Kevin Rodgers
2016-02-28 6:44 ` Lars Ingebrigtsen
2019-06-27 17:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9FB543.10708@gmail.com \
--to=wyuenho@gmail.com \
--cc=4310@emacsbugs.donarmstrong.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.