shell-quote-argument seems quoting backup files incorrectly

shell-quote-argument seems quoting backup files incorrectly

[Jin Huang]

Dear All,

I just set my emacs (GNU Emacs 23.0.91.1) to use the system (Ubuntu
9.04) trash.  It works fine for most of the file, however cannot move
backup files (with ~ in the end of the file name) into trash, even
cannot delete it.

I followed the instruction from
http://www.emacswiki.org/emacs/SystemTrash.  Then I shrunk the code
for the minimal set to reproduce the problem:

========== Code A ==========
(setq delete-by-moving-to-trash t)
(defun system-move-file-to-trash (filename)
    (call-process "gvfs-trash" nil nil nil filename))

========== Code B ==========
(setq delete-by-moving-to-trash t)
(defun system-move-file-to-trash (filename)
    (call-process "gvfs-trash" nil nil nil (shell-quote-argument filename)))

Code A can move the backup file into trash correctly, however Code B
cannot.

One possible reason is that the backup suffix "~" mixes up with the
notation for home directory.

Is there any solution?

Best regards.

Jin Huang

Re: shell-quote-argument seems quoting backup files incorrectly

[Kevin Rodgers]

Jin Huang wrote:
> 
> Dear All,
> 
> I just set my emacs (GNU Emacs 23.0.91.1) to use the system (Ubuntu
> 9.04) trash.  It works fine for most of the file, however cannot move
> backup files (with ~ in the end of the file name) into trash, even
> cannot delete it.
> 
> I followed the instruction from
> http://www.emacswiki.org/emacs/SystemTrash.  Then I shrunk the code
> for the minimal set to reproduce the problem:
> 
> ========== Code A ==========
> (setq delete-by-moving-to-trash t)
> (defun system-move-file-to-trash (filename)
>    (call-process "gvfs-trash" nil nil nil filename))
> 
> ========== Code B ==========
> (setq delete-by-moving-to-trash t)
> (defun system-move-file-to-trash (filename)
>    (call-process "gvfs-trash" nil nil nil (shell-quote-argument filename)))
> 
> Code A can move the backup file into trash correctly, however Code B
> cannot.
> 
> One possible reason is that the backup suffix "~" mixes up with the
> notation for home directory.
> 
> Is there any solution?

call-process does not invoke the shell, so you should not use
shell-quote-argument with it (cf. call-process-shell-command
and shell-command).

-- 
Kevin Rodgers
Denver, Colorado, USA