all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Changes 2009-07-15/16 in branch?
@ 2009-07-23 11:22 Adrian Robert
  2009-07-23 12:46 ` YAMAMOTO Mitsuharu
                   ` (2 more replies)
  0 siblings, 3 replies; 80+ messages in thread
From: Adrian Robert @ 2009-07-23 11:22 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu; +Cc: Emacs-Devel devel

Hello Yamamoto-san,

Did you mean to check the changes below into the branch?  I *think*  
these are pretty safe, but it seems a bit close to release for such  
feature changes, even in the name of standardization.  My vote would  
be to do these on trunk only for now.

Also:

ns_get_color(): Shouldn't the description comment for ns_get_color()  
be updated further?  It looks like something was just chopped off,  
leaving the rest making little sense.  What is the bug or problem this  
change fixes?

ns_color_to_lisp(): The function could be simplified now that you have  
eliminated a special case.

nsfont_draw(): Would setting the foreground instead of the background  
color to the bitmap constitute a corrected implementation?

ns-set-background-alpha: The implementation you just removed was  
superior to that for (set-frame-parameter nil 'alpha ##): it does not  
alter the alpha of the titlebar, scrollbars, modeline, or text.  This  
makes it usable, instead of a curiosity.  It also provides access via  
an interactive function.  The correct fix would be to improve the (set- 
frame-parameter) version, not remove this while no alternative exists  
for users.


2009-07-16  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

         * nsfns.m (Fns_set_alpha): Remove function.
         (syms_of_nsfns): Don't defsubr it.

         * nsterm.m (ns_get_color): Remove incompatible color formats.
         (ns_color_to_lisp): Generate #rrggbb color format string.

2009-07-15  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

         * nsfont.m (nsfont_draw): Remove code for stippling, which  
actually
         does tiling.

         * nsterm.m (ns_maybe_dumpglyphs_background): Likewise.

2009-07-16  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

	* term/ns-win.el (ns-set-alpha): Don't declare.
	(ns-set-background-alpha): Remove function.






^ permalink raw reply	[flat|nested] 80+ messages in thread

end of thread, other threads:[~2009-08-03 20:03 UTC | newest]

Thread overview: 80+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-23 11:22 Changes 2009-07-15/16 in branch? Adrian Robert
2009-07-23 12:46 ` YAMAMOTO Mitsuharu
2009-07-23 15:30   ` Stefan Monnier
2009-07-24  0:23     ` YAMAMOTO Mitsuharu
2009-07-24  1:09       ` Stefan Monnier
2009-07-24  1:27         ` YAMAMOTO Mitsuharu
2009-07-24  1:37           ` Stefan Monnier
2009-07-24  2:20             ` YAMAMOTO Mitsuharu
2009-07-24  3:17               ` Stefan Monnier
2009-07-24  3:35                 ` YAMAMOTO Mitsuharu
2009-07-24  3:44                   ` Jason Rumney
2009-07-24  4:12                     ` YAMAMOTO Mitsuharu
2009-07-25  2:13                       ` YAMAMOTO Mitsuharu
2009-07-26  2:22                         ` Richard Stallman
2009-07-26  2:35                           ` YAMAMOTO Mitsuharu
2009-07-26  3:31                             ` Miles Bader
2009-07-26  3:45                               ` YAMAMOTO Mitsuharu
2009-07-27  2:44                             ` Richard Stallman
2009-07-27  3:20                               ` YAMAMOTO Mitsuharu
2009-07-27 17:41                                 ` Richard Stallman
2009-07-27 18:41                                   ` Clifford Wulfman
2009-07-28  4:37                                     ` Richard Stallman
2009-07-28 13:18                                       ` Clifford Wulfman
2009-07-28 17:14                                         ` Richard Stallman
2009-07-28 18:39                                           ` Alfred M. Szmidt
2009-07-28 20:31                                             ` Ian Eure
2009-08-01  3:21                                               ` Richard Stallman
2009-08-01  4:10                                                 ` Ian Eure
2009-08-01  6:28                                                   ` Stephen J. Turnbull
2009-08-02  4:44                                                   ` Richard Stallman
2009-07-28 22:05                                           ` James Cloos
2009-07-29 20:13                                             ` Richard Stallman
2009-07-29 22:05                                               ` YAMAMOTO Mitsuharu
2009-07-30  7:53                                               ` YAMAMOTO Mitsuharu
2009-07-30 14:01                                                 ` Chong Yidong
2009-07-31  1:56                                                   ` YAMAMOTO Mitsuharu
2009-07-27 20:14                                   ` David De La Harpe Golden
2009-07-28  6:10                                     ` YAMAMOTO Mitsuharu
     [not found]                                     ` <EFBC3E4E-8739-4B16-8797-D9CA8BC290CD@gmail.com>
2009-07-28 20:33                                       ` David De La Harpe Golden
2009-07-28  0:53                                   ` YAMAMOTO Mitsuharu
2009-07-28 17:14                                     ` Richard Stallman
2009-07-24 19:25                   ` Stefan Monnier
2009-07-29  0:22         ` YAMAMOTO Mitsuharu
2009-07-29  1:12           ` Chong Yidong
2009-07-29  1:18             ` YAMAMOTO Mitsuharu
2009-07-29  4:48               ` YAMAMOTO Mitsuharu
2009-07-29  1:29             ` YAMAMOTO Mitsuharu
2009-07-24 14:34   ` Adrian Robert
2009-07-25  1:15     ` YAMAMOTO Mitsuharu
2009-07-25  4:55     ` Richard Stallman
2009-07-25 16:59       ` Adrian Robert
2009-07-27  2:43         ` Richard Stallman
2009-07-27  3:22           ` Adrian Robert
     [not found]             ` <E1MW1sm-0000lL-4K@fencepost.gnu.org>
2009-07-29 14:08               ` Harald Hanche-Olsen
2009-07-29 17:18                 ` Stefan Monnier
2009-07-30  7:35                 ` David Kastrup
2009-07-30 13:31                   ` Harald Hanche-Olsen
2009-07-28 18:25           ` Harald Hanche-Olsen
2009-07-29  2:34             ` Stephen J. Turnbull
2009-07-29  2:41               ` Lennart Borgman
2009-07-29  2:56                 ` Harald Hanche-Olsen
2009-07-29  3:33                 ` Stephen J. Turnbull
2009-07-29 20:14               ` Richard Stallman
2009-07-29 20:26                 ` Chad Brown
2009-07-30 15:35                   ` Richard Stallman
2009-07-30 16:37                     ` Harald Hanche-Olsen
2009-07-29 20:31                 ` Harald Hanche-Olsen
2009-07-30 15:35                   ` Richard Stallman
2009-07-30 16:22                     ` Harald Hanche-Olsen
2009-08-01  3:21                       ` Richard Stallman
2009-08-01  7:45                         ` CHENG Gao
2009-08-01  9:36                           ` CHENG Gao
2009-08-02  4:43                           ` Richard Stallman
2009-08-02  7:06                             ` CHENG Gao
2009-08-03 16:17                               ` Richard Stallman
2009-08-03 20:03                                 ` CHENG Gao
2009-07-29 14:12           ` Stefan Monnier
2009-07-27  0:35 ` YAMAMOTO Mitsuharu
2009-07-27  3:12   ` Adrian Robert
2009-07-29  3:23 ` Sean O'Rourke

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.