From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel,gmane.emacs.cedet Subject: RE: cedet-called-interactively-p hangs on emacs 24.3.50.1 Date: Thu, 20 Dec 2012 08:03:19 -0800 Message-ID: <4A67B44FED76429D875023613978D1DA@us.oracle.com> References: <87obhsxz7s.fsf@fimbulvetr.bsc.es><87623x1yv8.wl%andres.ramirez@kipuamutay.com><87bodou8c3.fsf_-_@fimbulvetr.bsc.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1356019415 8617 80.91.229.3 (20 Dec 2012 16:03:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2012 16:03:35 +0000 (UTC) Cc: 'Alex Ott' , emacs-devel@gnu.org, =?iso-8859-1?Q?'Llu=EDs'?= , 'CEDET Devel' , "'andres.ramirez'" To: , "'Stefan Monnier'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 20 17:03:49 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tlib6-0007k4-UJ for ged-emacs-devel@m.gmane.org; Thu, 20 Dec 2012 17:03:49 +0100 Original-Received: from localhost ([::1]:45664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tliat-0006Z6-A5 for ged-emacs-devel@m.gmane.org; Thu, 20 Dec 2012 11:03:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tliar-0006Yk-2k for emacs-devel@gnu.org; Thu, 20 Dec 2012 11:03:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tliap-0006JX-Rf for emacs-devel@gnu.org; Thu, 20 Dec 2012 11:03:32 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:51002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tliap-0006JP-Kl for emacs-devel@gnu.org; Thu, 20 Dec 2012 11:03:31 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBKG3PC5029687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Dec 2012 16:03:27 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBKG3Ogm022262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 20 Dec 2012 16:03:24 GMT Original-Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBKG3NOD020854; Thu, 20 Dec 2012 10:03:23 -0600 Original-Received: from dradamslap1 (/10.159.237.61) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 20 Dec 2012 08:03:23 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac3ewPbXJCYFCHg8R2+39unkq+krEgACGKaw X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155690 gmane.emacs.cedet:6220 Archived-At: > I have the exact same issue... > so, the problem seems to be a change in emacs core for > called-interactively-p. I haven't run into the problems mentioned (I don't use CEDET or advise `called-interactively' or `interactive-p'). But FWIW I have noticed that the behavior has recently changed in the debugger. Now you definitely want to hit `c' and not `d', to skip over the evaluation, because it takes you on a little tour around Robinson's barn. BTW, in the debugger I see this: * advice--called-interactively-skip(4 (t #[...] ... And in nadvice.el I see this: ;; When code is advised, called-interactively-p needs to be taught to skip ;; the advising frames. ;; FIXME: This Major Ugly Hack won't handle calls to called-interactively-p ;; done from the advised function if the deepest advice is an around advice! ;; In other cases (calls from an advice or calls from the advised function when ;; the deepest advice is not an around advice), it should hopefully get ;; it right. It does indeed seem like we are making Emacs jump through hoops backward. No doubt there is some thorny problem that the code solves, but the comments don't indicate what that might be.