all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: <joakim@verona.se>, "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: "'Alex Ott'" <alexott@gmail.com>,
	emacs-devel@gnu.org, 'Lluís' <xscript@gmx.net>,
	"'CEDET Devel'" <cedet-devel@lists.sourceforge.net>,
	"'andres.ramirez'" <andres.ramirez@kipuamutay.com>
Subject: RE: cedet-called-interactively-p hangs on emacs 24.3.50.1
Date: Thu, 20 Dec 2012 08:03:19 -0800	[thread overview]
Message-ID: <4A67B44FED76429D875023613978D1DA@us.oracle.com> (raw)
In-Reply-To: <m3zk18wzkm.fsf@chopper.vpn.verona.se>

> I have the exact same issue... 
> so, the problem seems to be a change in emacs core for
> called-interactively-p.

I haven't run into the problems mentioned (I don't use CEDET or advise
`called-interactively' or `interactive-p'). 

But FWIW I have noticed that the behavior has recently changed in the debugger.
Now you definitely want to hit `c' and not `d', to skip over the evaluation,
because it takes you on a little tour around Robinson's barn.

BTW, in the debugger I see this:
* advice--called-interactively-skip(4 (t #[...] ...

And in nadvice.el I see this:

;; When code is advised, called-interactively-p needs to be taught to skip
;; the advising frames.
;; FIXME: This Major Ugly Hack won't handle calls to called-interactively-p
;; done from the advised function if the deepest advice is an around advice!
;; In other cases (calls from an advice or calls from the advised function when
;; the deepest advice is not an around advice), it should hopefully get
;; it right.

It does indeed seem like we are making Emacs jump through hoops backward.  No
doubt there is some thorny problem that the code solves, but the comments don't
indicate what that might be.




      parent reply	other threads:[~2012-12-20 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87obhsxz7s.fsf@fimbulvetr.bsc.es>
     [not found] ` <CALV1_=+T-2tJbyFQn-9o2LtoazQRk9p_5K5BY=4CRkXdULYFsA@mail.gmail.com>
     [not found]   ` <87623x1yv8.wl%andres.ramirez@kipuamutay.com>
2012-12-20 14:06     ` cedet-called-interactively-p hangs on emacs 24.3.50.1 Lluís
2012-12-20 14:25       ` Stefan Monnier
2012-12-20 14:47         ` joakim
2012-12-20 14:58           ` Lluís
2012-12-20 16:03           ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A67B44FED76429D875023613978D1DA@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=alexott@gmail.com \
    --cc=andres.ramirez@kipuamutay.com \
    --cc=cedet-devel@lists.sourceforge.net \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    --cc=monnier@iro.umontreal.ca \
    --cc=xscript@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.