all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Caldwell <david@porkrind.org>
To: David Reitter <david.reitter@gmail.com>
Cc: 2836@emacsbugs.donarmstrong.com
Subject: bug#2836:
Date: Thu, 16 Jul 2009 16:49:33 -0700	[thread overview]
Message-ID: <4A5FBC8D.5000208@porkrind.org> (raw)
In-Reply-To: <E1D24BFC-5DE5-4C1B-AAEB-EC28D1D2A16F@gmail.com>

On 4/27/09 3:52 PM, David Reitter wrote:

>> Reintroducing line spacing (which was removed for a reason) not only
>> fixes this bug, but has global consequences.

I'm curious what the reasons are since it wasn't really explained in the
check-in comments. I've been running with my patch now for 3 months and
haven't seen any visual oddities. But perhaps my anti-aliasing settings
are masking what the original change was for...

>> So I don't think this is the right way to fix this bug.  I think we
>> have to look at the code that draws the non-antialiased text.
>>
>> For now, the workaround for this is
>>
>> (set-frame-parameter nil 'line-spacing 2)
>> (or setting defaut-frame-alist accordingly).

This does fix the descenders being chopped off, but ends up making the
block cursor not cover the whole glyph it's highlighting--it's really ugly.

Any idea if we'll get a real fix (or one our workarounds) into CVS
before emacs 23.1 is released?

-David





  parent reply	other threads:[~2009-07-16 23:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 21:08 bug#2836: David Reitter
     [not found] ` <E1D24BFC-5DE5-4C1B-AAEB-EC28D1D2A16F@gmail.com>
2009-07-16 23:49   ` David Caldwell [this message]
2009-07-16 23:54     ` bug#2836: David Reitter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5FBC8D.5000208@porkrind.org \
    --to=david@porkrind.org \
    --cc=2836@emacsbugs.donarmstrong.com \
    --cc=david.reitter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.