From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.bugs Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Date: Fri, 29 May 2009 10:46:51 -0400 Message-ID: <4A1FF55B.4040202@genarts.com> Reply-To: Gary Oberbrunner , 3418@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1243634668 22129 80.91.229.12 (29 May 2009 22:04:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 May 2009 22:04:28 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 30 00:04:23 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MAABZ-00010h-Jj for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 May 2009 00:04:21 +0200 Original-Received: from localhost ([127.0.0.1]:33679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAABZ-0007an-1o for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 May 2009 18:04:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MA3WU-00014i-Cx for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:57:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MA3WO-00012M-FD for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:57:29 -0400 Original-Received: from [199.232.76.173] (port=32813 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MA3WL-00011m-Rv for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:57:22 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48990) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MA3WK-000461-BT for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:57:21 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4TEvHv9006816; Fri, 29 May 2009 07:57:18 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n4TEt6gr006212; Fri, 29 May 2009 07:55:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Gary Oberbrunner Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 29 May 2009 14:55:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3418 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12436084255179 (code B ref -1); Fri, 29 May 2009 14:55:06 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 29 May 2009 14:47:05 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4TEkxah005172 for ; Fri, 29 May 2009 07:47:01 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MA3MJ-0003dK-Ag for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:46:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MA3MG-0003cL-Gz for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:46:57 -0400 Original-Received: from [199.232.76.173] (port=33876 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MA3ME-0003be-D3 for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:46:54 -0400 Original-Received: from hq.genarts.com ([173.9.65.1]:43386 helo=mail.hq.genarts.com) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MA3MD-0001Nj-Ns for bug-gnu-emacs@gnu.org; Fri, 29 May 2009 10:46:54 -0400 Original-Received: from mail.hq.genarts.com (mail.hq.genarts.com [10.102.202.62]) by penguin (Postfix) with SMTP id 8846712D861B for ; Fri, 29 May 2009 10:46:52 -0400 (EDT) Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.hq.genarts.com (Postfix) with ESMTP id 7C3E514B4002 for ; Fri, 29 May 2009 10:46:52 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.hq.genarts.com Original-Received: from mail.hq.genarts.com ([127.0.0.1]) by localhost (mail.hq.genarts.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QuvOBusoyIaA for ; Fri, 29 May 2009 10:46:51 -0400 (EDT) Original-Received: from [10.101.201.42] (noise.hq.genarts.com [10.101.201.42]) by mail.hq.genarts.com (Postfix) with ESMTP id 1077C14B4001 for ; Fri, 29 May 2009 10:46:51 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081218 Lightning/1.0pre Shredder/3.0b2pre Mnenhy/0.7.6.0 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 29 May 2009 10:57:29 -0400 X-Mailman-Approved-At: Fri, 29 May 2009 18:01:05 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28306 Archived-At: Hi emacs folks. I submitted a patch to compilation-get-file-structure in compile.el in 2001, introducing this stanza: ;; If compilation-parse-errors-filename-function is ;; defined, use it to process the filename. (when compilation-parse-errors-filename-function (setq filename (funcall filename))) At some point since then, the filename was changed to not always be absolute; there's now a variable spec-directory in that function. This means that implementations of compilation-parse-errors-filename-function can't always work correctly since it doesn't know the full path of the file. I'm happy to work on a fix, but I see a few issues. Solution 1: add 2nd arg SPEC-DIRECTORY to compilation-parse-errors-filename-function. Problem: existing implementations will get an incorrect number of args error and will have to change. Solution 2: make filename absolute before passing to compilation-parse-errors-filename-function. Problem: the rest of the code is pretty careful not to absolutize the filename; this would change the behavior in ways I don't completely understand. Of course I am personally happy with solution 1, but since it affects compatibility I thought I should bring it up on this list. I am not on the list, so please cc me with any replies, thanks! -- . . . . . . . . . . . . . . . . . . . . . . . . . Gary Oberbrunner garyo@genarts.com GenArts, Inc. Tel: 617-492-2888 955 Mass. Ave Fax: 617-492-2852 Cambridge, MA 02139 USA www.genarts.com