From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73768: 'read-passwd-mode' can clobber user defined mode lines Date: Mon, 14 Oct 2024 16:56:29 +0200 Message-ID: <49fca25a-d5aa-4f14-ae09-52923eb5ce85@gmx.at> References: <1d3172d5-3704-40c6-92af-8888b0657871@gmx.at> <87v7xxsj4l.fsf@gmx.de> <87wmicqe5a.fsf@gmx.de> <877cacvv0r.fsf@gmx.de> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------eIA7p0jFnMGMNnhdg2B2CBec" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73768@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 14 16:58:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0MWI-0005wZ-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Oct 2024 16:58:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0MW2-0005b6-UR; Mon, 14 Oct 2024 10:57:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0MW1-0005al-4n for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 10:57:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0MW0-0005og-Sz for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 10:57:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=xMh11i/TrqgkWJ8krxPfckxwkSUsfzeUTB0blisHYZo=; b=eWxOjCsx4lmug3A8GMmGOWvs/WrR3SvRroT4aR6r58DNea2KaxKn+H5pU8N6QxqseH6Fwt+itvmnX00RpGt1TFmLhQrB8zTP+vCmslWKi3d3rft6zKTGHfcJ1EXjZrApyhq9jLemDJTT3QyZGdhyo/XoabjqO2YBoQuuXkWODR/gUpiydehDJzzEVpC6Fs5h5JqfRpTyF4+i4PPfIL7elxBUnCy9URIz9YImKQ3WOSA5U4Gb2szKNmyzy3Z++SmfmmBy24M1BR9vrWr5yf3tAkkK7ReruAuARNlhFNdmH+vkPB4zEzjp2bX5U6n2vdgaRrXT0tEmMObgvLP0k79YWw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0MWH-0008DL-Nr for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 10:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2024 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73768 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 73768@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172891782931391 (code B ref -1); Mon, 14 Oct 2024 14:58:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Oct 2024 14:57:09 +0000 Original-Received: from localhost ([127.0.0.1]:39999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0MVQ-0008AF-LA for submit@debbugs.gnu.org; Mon, 14 Oct 2024 10:57:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0MVO-0008A6-TZ for submit@debbugs.gnu.org; Mon, 14 Oct 2024 10:57:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0MV7-0005VQ-Ge for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 10:56:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0MV5-0005jK-QG for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 10:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1728917794; x=1729522594; i=rudalics@gmx.at; bh=xMh11i/TrqgkWJ8krxPfckxwkSUsfzeUTB0blisHYZo=; h=X-UI-Sender-Class:Content-Type:Message-ID:Date:MIME-Version: Subject:To:Cc:References:From:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=QbZjw9lnMifAncligsGpB3GgttQjpLTxS1rsRjVLu9PHeG0ZKOONbxp+JQT2sIKB yVkmpPAk62PGpDiML3/tx6Y95J8+1cCPNvuYX+jEHbzSfgHb75Jq9zpozWfsWW+tZ JM1U49It8wZnnBkQYVpRGtjuFkk1VL8fUpQd4PptKu5JCqlc7FHKPHTfihYAHNEcO D90t9BDp12cYsd/7HbV1Vu6WSpCPYAy+4bLrwkxjDbBhnQrXCdQWhv3oGHngkdcJf oWBOICyetEpzKOcavMNHa9gpdfvPRRn5Fs9xG3eKYp8a4cZxUraG7eiTMZD7SuDpM oPFRhj5VVpPBR/h7lw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([213.142.97.14]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1poA-1syAdl424e-0022gn; Mon, 14 Oct 2024 16:56:34 +0200 Content-Language: en-US In-Reply-To: <877cacvv0r.fsf@gmx.de> X-Provags-ID: V03:K1:o4CGrFaQLNKb6kDJOZFQIjQxZW7pRMpFAFp9y3V91wgfpFnULGR iFpTbMzJqvc9GE+/LNPo9eu0SMZ45LDAb7QQ1hd4qOpxHAoDy5y7l1x4CeBrlaVXS/7CXbe R/zK5aEFxenbekazZ+qgZ4rEhLoXaiYYJNU5CIuiKKLK0ReO6gBPEZU+6SeSrp4Q27Mlhf+ lh+smsotEmrxUnlE7X00A== UI-OutboundReport: notjunk:1;M01:P0:rShxtDXy5fg=;uArxljjjBocc7r54BNZaltqeQTK CH+DD++XhheAaal5/zxCXOD/NQ3kVnvutOHH2svH+EIcZ+x0epNYpOfu5jTRN6je+OHV+7tvy /8Kf6AczPzwcAIqCTkBJlA2j0Vjfq4du7TceGiafXhJOOkbikCzqQnAjYsd5LywIll+9OdHN9 NIqWfgM+/jhFS2dPW4WL3HUq/y8GtFmDU/91TxZO7IWTpMjtb62jkvbwC8xM5gJrZuQZTOq3a 9WTnneVhnl2XcPYUDcaQLSupOlMq50Du/MwO7Uo+VZIWMYX8VTJ9UAWc9EUkTZ/20Elk7la+y mxgH3qKsOdsGOXIVPsopsAsaVzzzgbj8Cz2sIfE9FHpqMgVFHIvsO+ySpMoYbido1LE2voY6B 7JEyHyHHRimO/yI8bJD3agV5+a1OjcirTzdOkIX1euFPOfWlsRD1UNmUiNG+iSGuF15K5exMj sNnctXz3vehlt+E0zIkfLYp16sBxOQjaGKdBKbu+yBUPzqC1OIfDB1LINDNYhAIoz1Uoj6hYr bDim8iRqBF8l0FBBZUSYSpX540JXh5TsB29q8yrnqljFRDa4exYeA5yude2l+alCKMYF0QQmK Des2QrxWaMqkTzvdofaeZ40F1cVdiKYzIXl6Z5ANMqW/CstZU2k9Px7h7BJVVWoXwSdDiRzhc hsG5es5pIFHg3fh6XLggXtWpwpTJeJYbUlyhwv/qQg2TtC2azPIBFRBPYAGRWMm53AHbtypi1 6HFPHKW1OxNtMPNwJGhHTKPOBF2Uaxeert89wiQ0hZKiDc0A1dV1vQQ6sV+uy3Y0AllqE+I4 Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293577 Archived-At: This is a multi-part message in MIME format. --------------eIA7p0jFnMGMNnhdg2B2CBec Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Thanks! With this recipe, I can reproduce the problem. And your patch > fixes it :-) > > Please install in the emacs-30 branch. Hold your horses. First try another recipe: With emacs -Q do C-x 5 2 followed by C-x b to show *Messages* in either of the frames, read a password, do C-x 5 o and type C-g. One of the two buffers has the eye icon the other has the botched mode line. I'm using the more accurate patch attached now to hopefully fix that too. Note that whenever one switches frames, the mode line showing the eye will always stay with the initially chosen buffer and not the one where the minibuffer window is. But there are other scenarios that don't seem right. While reading one password ask for reading another one. You now should see two eye icons which, however, cannot be attributed to any of the two read operations. Clicking on either of them will toggle visibility of the password. If you don't want to show the password for the first operation but you do want to show it for the second operation, then when the second operation terminates you will see the password for the first one. Same for typing TAB in the minibuffer. Resetting 'read-passwd--hide-password' when terminating any read password operation might fix that. Likely password visibility should be a property of the specific reading process (aka as buffer-local value of 'read-passwd--hide-password') and not something global. But then we would also have to change the first icon of the mode line too and doing that is more tricky. Currently, all eye icons are the same because 'read-passwd--mode-line-icon' has the same value for them. Probably it might be better to have only one eye icon on any mode line informing about the visibility of the innermost minibuffer's password status. But this becomes tricky when terminating a password operation because we would have to internally (on the C-level) scan all minibuffers to find out whether there's another password operation in progress and remove the eye icon only if there's none. Otherwise we could try giving only the first eye icon the dynamic eval property and have all other icons statically have the hide password property. Less tricky - we'd only have to hide a password when asking for another one. Obviously, we could also inhibit asking for a second password. But I suppose this was always possible and would imply an incompatible change. If anyone has a good idea what to do here, please speak up. Thanks, martin --------------eIA7p0jFnMGMNnhdg2B2CBec Content-Type: text/x-patch; charset=UTF-8; name="read-passwd.diff" Content-Disposition: attachment; filename="read-passwd.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvYXV0aC1zb3VyY2UuZWwgYi9saXNwL2F1dGgtc291cmNlLmVs CmluZGV4IDkwYjU4ZjU2MGMwLi5mNzEzOTM3MjFjYiAxMDA2NDQKLS0tIGEvbGlzcC9hdXRo LXNvdXJjZS5lbAorKysgYi9saXNwL2F1dGgtc291cmNlLmVsCkBAIC0yNDc0LDcgKzI0NzQs NyBAQCByZWFkLXBhc3N3ZC0tbW9kZS1saW5lLWljb24KICAgIlByb3BlcnRpemVkIG1vZGUg bGluZSBpY29uIGZvciBzaG93aW5nL2hpZGluZyBwYXNzd29yZHMuIikKIAogKGRlZnZhciBy ZWFkLXBhc3N3ZC0taGlkZS1wYXNzd29yZCB0Ci0gICJUb2dnbGUgd2hldGhlciBwYXNzd29y ZCBzaG91bGQgYmUgaGlkZGVuIGluIG1pbnVidWZmZXIuIikKKyAgIlRvZ2dsZSB3aGV0aGVy IHBhc3N3b3JkIHNob3VsZCBiZSBoaWRkZW4gaW4gbWluaWJ1ZmZlci4iKQogCiAoZGVmdW4g cmVhZC1wYXNzd2QtLWhpZGUtcGFzc3dvcmQgKCkKICAgIk1ha2UgcGFzc3dvcmQgaW4gbWlu aWJ1ZmZlciBoaWRkZW4gb3IgdmlzaWJsZS4iCkBAIC0yNTM0LDEzICsyNTM0LDE0IEBAIHJl YWQtcGFzc3dkLW1vZGUKICAgOmtleW1hcCByZWFkLXBhc3N3ZC1tYXAKICAgOnZlcnNpb24g IjMwLjEiCiAKLSAgKHNldHEgcmVhZC1wYXNzd2QtLWhpZGUtcGFzc3dvcmQgbmlsCi0gICAg ICAgIDs7IFN0b2xlbiBmcm9tIGBlbGRvYy1taW5pYnVmZmVyLW1lc3NhZ2UnLgotICAgICAg ICByZWFkLXBhc3N3ZC0tbW9kZS1saW5lLWJ1ZmZlcgotICAgICAgICAod2luZG93LWJ1ZmZl cgotICAgICAgICAgKG9yICh3aW5kb3ctaW4tZGlyZWN0aW9uICdhYm92ZSAobWluaWJ1ZmZl ci13aW5kb3cpKQotCSAgICAgKG1pbmlidWZmZXItc2VsZWN0ZWQtd2luZG93KQotCSAgICAg KGdldC1sYXJnZXN0LXdpbmRvdykpKSkKKyAgKHNldHEgcmVhZC1wYXNzd2QtLWhpZGUtcGFz c3dvcmQgbmlsKQorICA7OyBTdG9sZW4gZnJvbSBgZWxkb2MtbWluaWJ1ZmZlci1tZXNzYWdl Jy4KKyAgKHVubGVzcyAoYnVmZmVyLWxpdmUtcCByZWFkLXBhc3N3ZC0tbW9kZS1saW5lLWJ1 ZmZlcikKKyAgICAoc2V0cSByZWFkLXBhc3N3ZC0tbW9kZS1saW5lLWJ1ZmZlcgorICAgICAg ICAgICh3aW5kb3ctYnVmZmVyCisgICAgICAgICAgIChvciAod2luZG93LWluLWRpcmVjdGlv biAnYWJvdmUgKG1pbmlidWZmZXItd2luZG93KSkKKwkgICAgICAgKG1pbmlidWZmZXItc2Vs ZWN0ZWQtd2luZG93KQorCSAgICAgICAoZ2V0LWxhcmdlc3Qtd2luZG93KSkpKSkKIAogICAo aWYgcmVhZC1wYXNzd2QtbW9kZQogICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgcmVhZC1w YXNzd2QtLW1vZGUtbGluZS1idWZmZXIKQEAgLTI1NTEsOCArMjU1MiwxMCBAQCByZWFkLXBh c3N3ZC1tb2RlCiAJICAgICAgICAgICAgICBtb2RlLWxpbmUtZm9ybWF0KSkpKQogICAgICh3 aXRoLWN1cnJlbnQtYnVmZmVyIHJlYWQtcGFzc3dkLS1tb2RlLWxpbmUtYnVmZmVyCiAgICAg ICA7OyBSZW1vdmUgYHJlYWQtcGFzc3dkLS1tb2RlLWxpbmUtaWNvbicuCi0gICAgICAod2hl biAobGlzdHAgbW9kZS1saW5lLWZvcm1hdCkKLSAgICAgICAgKHNldHEgbW9kZS1saW5lLWZv cm1hdCAoY2RyIG1vZGUtbGluZS1mb3JtYXQpKSkpKQorICAgICAgKHdoZW4gKGVxdWFsIChj YXIgbW9kZS1saW5lLWZvcm1hdCkKKwkJICAgJyg6ZXZhbCByZWFkLXBhc3N3ZC0tbW9kZS1s aW5lLWljb24pKQorICAgICAgICAoc2V0cSBtb2RlLWxpbmUtZm9ybWF0IChjZHIgbW9kZS1s aW5lLWZvcm1hdCkpKSkKKyAgICAoc2V0cSByZWFkLXBhc3N3ZC0tbW9kZS1saW5lLWJ1ZmZl ciBuaWwpKQogCiAgICh3aGVuIHJlYWQtcGFzc3dkLW1vZGUKICAgICAocmVhZC1wYXNzd2Qt dG9nZ2xlLXZpc2liaWxpdHkpKSkK --------------eIA7p0jFnMGMNnhdg2B2CBec--