From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David De La Harpe Golden Newsgroups: gmane.emacs.bugs Subject: bug#2833: 23.0.92; Bug in Directory Variables Date: Thu, 09 Apr 2009 12:03:00 +0100 Message-ID: <49DDD5E4.2000500__13916.0614497543$1239276344$gmane$org@harpegolden.net> References: <87fxgicz1b.fsf@cyd.mit.edu> Reply-To: David De La Harpe Golden , 2833@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1239276258 11630 80.91.229.12 (9 Apr 2009 11:24:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Apr 2009 11:24:18 +0000 (UTC) Cc: 2833@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 09 13:25:37 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LrsNr-00043R-9E for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Apr 2009 13:25:27 +0200 Original-Received: from localhost ([127.0.0.1]:40794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrsMS-0003ah-N5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Apr 2009 07:24:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrsMO-0003aR-TL for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:23:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrsMK-0003a3-94 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:23:56 -0400 Original-Received: from [199.232.76.173] (port=49855 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrsMK-0003Zr-07 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:23:52 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37580) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrsMJ-0005xn-Gl for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:23:51 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39BNn7i029982; Thu, 9 Apr 2009 04:23:49 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n39BA6Ln025780; Thu, 9 Apr 2009 04:10:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David De La Harpe Golden Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 11:10:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123927499923072 (code B ref 2833); Thu, 09 Apr 2009 11:10:06 +0000 Original-Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 11:03:19 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from harpegolden.net (harpegolden.net [65.99.215.13]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39B3Ee6023064 for <2833@emacsbugs.donarmstrong.com>; Thu, 9 Apr 2009 04:03:15 -0700 Original-Received: from [87.198.47.25] (87-198-47-25.ptr.magnet.ie [87.198.47.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "David De La Harpe Golden", Issuer "David De La Harpe Golden Personal CA rev 3" (verified OK)) by harpegolden.net (Postfix) with ESMTP id E2CD481E2; Thu, 9 Apr 2009 12:03:13 +0100 (IST) User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) In-Reply-To: <87fxgicz1b.fsf@cyd.mit.edu> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 09 Apr 2009 07:23:56 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27020 Archived-At: Chong Yidong wrote: > The following patch changes the directory local variables code so that > the cache stores the file atime. Before using each cache entry, we > check that against the file modtime. > > This is not an ideal time to make changes of this sort, but I think this > problem (i.e., inability to detect changes in .dir-locals.el files) is > quite a serious one. So please help me review this patch. > I suspect the systems where a problem with the patch will be most noticeable will be windoze, since there's an extra file attributes call? I have a suspicion you almost might as well abandon the caching given the scary timings we've seen for that in the past. I could be wrong though.