From: David De La Harpe Golden <david@harpegolden.net>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 2833@emacsbugs.donarmstrong.com, emacs-devel@gnu.org
Subject: bug#2833: 23.0.92; Bug in Directory Variables
Date: Thu, 09 Apr 2009 12:03:00 +0100 [thread overview]
Message-ID: <49DDD5E4.2000500__13916.0614497543$1239276344$gmane$org@harpegolden.net> (raw)
In-Reply-To: <87fxgicz1b.fsf@cyd.mit.edu>
Chong Yidong wrote:
> The following patch changes the directory local variables code so that
> the cache stores the file atime. Before using each cache entry, we
> check that against the file modtime.
>
> This is not an ideal time to make changes of this sort, but I think this
> problem (i.e., inability to detect changes in .dir-locals.el files) is
> quite a serious one. So please help me review this patch.
>
I suspect the systems where a problem with the patch will be most
noticeable will be windoze, since there's an extra file attributes call?
I have a suspicion you almost might as well abandon the caching given
the scary timings we've seen for that in the past. I could be wrong though.
next prev parent reply other threads:[~2009-04-09 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 2:59 23.0.92; Bug in Directory Variables Chong Yidong
2009-04-09 11:03 ` David De La Harpe Golden [this message]
2009-04-09 11:03 ` David De La Harpe Golden
2009-04-09 14:27 ` bug#2833: " Stefan Monnier
2009-04-09 15:20 ` Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2009-04-11 15:31 Chong Yidong
2009-04-12 13:22 ` Leo
2009-04-09 2:59 Chong Yidong
2009-04-09 11:31 ` Leo
2009-04-02 18:50 Chong Yidong
2009-03-31 14:32 Leo
2009-04-01 1:14 ` Stefan Monnier
2009-04-01 10:01 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='49DDD5E4.2000500__13916.0614497543$1239276344$gmane$org@harpegolden.net' \
--to=david@harpegolden.net \
--cc=2833@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.