From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David De La Harpe Golden Newsgroups: gmane.emacs.devel Subject: Re: 23.0.92; Bug in Directory Variables Date: Thu, 09 Apr 2009 12:03:00 +0100 Message-ID: <49DDD5E4.2000500@harpegolden.net> References: <87fxgicz1b.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1239275018 7973 80.91.229.12 (9 Apr 2009 11:03:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Apr 2009 11:03:38 +0000 (UTC) Cc: 2833@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 09 13:04:55 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lrs3z-00063r-BZ for ged-emacs-devel@m.gmane.org; Thu, 09 Apr 2009 13:04:55 +0200 Original-Received: from localhost ([127.0.0.1]:55729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrs2a-0002Wa-Sg for ged-emacs-devel@m.gmane.org; Thu, 09 Apr 2009 07:03:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lrs2T-0002VD-Re for emacs-devel@gnu.org; Thu, 09 Apr 2009 07:03:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lrs2P-0002Sa-6R for emacs-devel@gnu.org; Thu, 09 Apr 2009 07:03:21 -0400 Original-Received: from [199.232.76.173] (port=58401 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrs2P-0002SW-19 for emacs-devel@gnu.org; Thu, 09 Apr 2009 07:03:17 -0400 Original-Received: from harpegolden.net ([65.99.215.13]:52144) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lrs2O-0003Og-GY for emacs-devel@gnu.org; Thu, 09 Apr 2009 07:03:16 -0400 Original-Received: from [87.198.47.25] (87-198-47-25.ptr.magnet.ie [87.198.47.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "David De La Harpe Golden", Issuer "David De La Harpe Golden Personal CA rev 3" (verified OK)) by harpegolden.net (Postfix) with ESMTP id E2CD481E2; Thu, 9 Apr 2009 12:03:13 +0100 (IST) User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) In-Reply-To: <87fxgicz1b.fsf@cyd.mit.edu> X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110164 Archived-At: Chong Yidong wrote: > The following patch changes the directory local variables code so that > the cache stores the file atime. Before using each cache entry, we > check that against the file modtime. > > This is not an ideal time to make changes of this sort, but I think this > problem (i.e., inability to detect changes in .dir-locals.el files) is > quite a serious one. So please help me review this patch. > I suspect the systems where a problem with the patch will be most noticeable will be windoze, since there's an extra file attributes call? I have a suspicion you almost might as well abandon the caching given the scary timings we've seen for that in the past. I could be wrong though.