From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Chong Yidong <cyd@stupidchicken.com>,
1405@emacsbugs.donarmstrong.com,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: bug#1405: detached GTK+ tool bar
Date: Sat, 14 Mar 2009 16:12:53 +0100 [thread overview]
Message-ID: <49BBC975.9060504@swipnet.se> (raw)
In-Reply-To: <873adw498x.fsf@escher.local.home>
Stephen Berman skrev:
> On Mon, 2 Mar 2009 08:01:24 +0100 "Jan D." <jan.h.d@swipnet.se> wrote:
>
>> How does this work when the button is a menu, i.e. help?
>>
>> I will be travelling for 2 weeks. I can't test it until then.
>>
>> Jan D.
>>
>> 1 mar 2009 kl. 18.43 skrev Stephen Berman <stephen.berman@gmx.net>:
>>
> [...]
>>> The patch below (against the current CVS trunk) makes focus return to
>>> the frame regardless of the value of x-gtk-whole-detached-tool-bar
>>> (i.e., it works both with the proxy (arrow) and the whole detached tool
>>> bar). Jan D. or somebody else who's familiar with GTK+ should check to
>>> make sure it does not cause any problems elsewhere.
>
> AFAICT it DTRT; i.e., when I'm in a mode in which clicking the Help
> button opens a menu when the tool bar is attached to the frame, the same
> thing happens with the detached tool bar, with both the arrow and the
> whole tool bar versions. This is both with and without my patch; the
> only difference is that with my patch, after clicking a Help menu item
> focus returns to the frame with both types of detached tool bar, while
> without my patch, focus returns only with the arrow tool bar. IOW, also
> in this case the patch appears to be OK.
>
It seems to do the trick, checked in.
Jan D.
next prev parent reply other threads:[~2009-03-14 15:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 21:38 detached GTK+ tool bar Chong Yidong
2008-11-23 11:01 ` Jan Djärv
2008-11-23 11:01 ` bug#1405: " Jan Djärv
2008-11-24 0:10 ` Stephen Berman
2008-11-24 8:03 ` Jan D.
2008-11-24 15:58 ` Chong Yidong
2008-11-24 15:58 ` Chong Yidong
2008-11-24 21:41 ` Jan Djärv
2008-11-24 21:41 ` Jan Djärv
2008-11-24 8:03 ` Jan D.
2008-12-18 18:50 ` Jan Djärv
2008-12-18 18:50 ` Jan Djärv
2008-12-18 20:46 ` Stephen Berman
2009-01-17 20:24 ` Stephen Berman
2009-03-01 17:43 ` Stephen Berman
2009-03-01 17:43 ` Stephen Berman
2009-03-02 7:01 ` Jan D.
2009-03-02 8:30 ` Stephen Berman
2009-03-14 15:12 ` Jan Djärv [this message]
2009-03-14 15:12 ` Jan Djärv
2009-03-02 7:01 ` Jan D.
2009-01-17 20:24 ` Stephen Berman
2008-12-18 20:46 ` Stephen Berman
2008-12-19 7:38 ` Jan D.
2008-12-19 7:38 ` Jan D.
2008-11-24 0:10 ` Stephen Berman
2008-11-23 11:02 ` Jan Djärv
2008-11-23 11:02 ` bug#1405: " Jan Djärv
-- strict thread matches above, loose matches on Subject: below --
2008-11-22 21:38 Chong Yidong
2008-11-22 23:08 ` Stephen Berman
2008-11-22 23:08 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BBC975.9060504@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=1405@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.