From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: robert marshall Newsgroups: gmane.emacs.bugs Subject: bug#2388: 23.0.90; wrong-type-argument in vc-dir Date: Wed, 11 Mar 2009 08:44:29 +0000 Message-ID: <49B779ED.5000000@tnei.co.uk> References: <87zlgi1p9f.fsf@tnei.co.uk> <200902201612.n1KGCFvg006453@rodan.ics.uci.edu> <49A2B431.6030302@tnei.co.uk> <18851.37147.636647.611430@kahikatea.snap.net.nz> <18862.21659.153250.510667@snap.net.nz> <49B6361C.8050702@tnei.co.uk> <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> Reply-To: robert marshall , 2388@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1236762348 4199 80.91.229.12 (11 Mar 2009 09:05:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 09:05:48 +0000 (UTC) Cc: 2388@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 11 10:07:03 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhKP0-0004hy-5E for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 10:07:02 +0100 Original-Received: from localhost ([127.0.0.1]:34524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhKNc-0005Rk-1T for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 05:05:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhKLt-00059P-Tn for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 05:03:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhKLr-00058W-QW for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 05:03:49 -0400 Original-Received: from [199.232.76.173] (port=60651 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhKLr-00058Q-LK for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 05:03:47 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41890) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LhKLq-0005oR-OM for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 05:03:47 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2B93fk2028902; Wed, 11 Mar 2009 02:03:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2B8o2x8025366; Wed, 11 Mar 2009 01:50:02 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: robert marshall Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Wed, 11 Mar 2009 08:50:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2388 X-Emacs-PR-Package: emacs,vc-dir X-Emacs-PR-Keywords: Original-Received: via spool by 2388-submit@emacsbugs.donarmstrong.com id=B2388.123676110624356 (code B ref 2388); Wed, 11 Mar 2009 08:50:02 +0000 Original-Received: (at 2388) by emacsbugs.donarmstrong.com; 11 Mar 2009 08:45:06 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.tnei-mail.com (Debian-exim@tnei.co.uk [83.170.102.119]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2B8ixIO024122 for <2388@emacsbugs.donarmstrong.com>; Wed, 11 Mar 2009 01:45:01 -0700 Original-Received: from mangw.ipsa-power.com ([83.138.33.114] helo=[130.88.108.10]) by mail.tnei-mail.com with esmtp (Exim 4.63) (envelope-from ) id 1LhK6l-0000wh-KV; Wed, 11 Mar 2009 08:48:12 +0000 User-Agent: Thunderbird 2.0.0.19 (X11/20090105) In-Reply-To: <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> X-SA-Exim-Connect-IP: 83.138.33.114 X-SA-Exim-Mail-From: robert.marshall@tnei.co.uk X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on mail.tnei-mail.com) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 11 Mar 2009 05:03:49 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26232 Archived-At: Dan Nicolaescu wrote: > robert marshall writes: > > > Nick Roberts wrote: > > > Nick Roberts writes: > > > > > > I can't reproduce this. > > > > > > Can you please post step by step recipe of how you get this, starting > > > > > > with emacs -Q. > > > The output of > > > svn -u status > > > > > > in that directory might be helpful too. > > > > > > > > I can't reproduce this either now :-( > > > > > I have seen this sometimes when files have needed > > > merging/updating. I don't > > > > think it happened earlier because with SVN emacs didn't consult the remote > > > > repository by default: > > > > > > I still see this. Here's a recent backtrace: > > > > > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > > > ewoc-data(nil) > .. > > > vc-dir-update((("." needs-update) ("mydir" needs-update) > > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ... > > > > > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil. > > > > > > > > I'm seeing this, today, the status gives me > > > > svn -u status > > * 7243 tests/compare.py > > * 7243 tests/harm.py > > * 7243 tests/setup-win.py > > * 7243 ipsa.i > > * 7243 Makefile > > * 7243 IscNetComponent.cpp > > * 7243 IscNetComparator.h > > * 7243 IpsaComparator.cpp > > * 7243 IscNetComponent.h > > * 7243 IscNetComparator.cpp > > * IscCompareData.h > > ? ipsa_wrap.cpp > > M * 7243 IscInterface.cpp > > ? ipsa.py > > * IscCompareData.cpp > > * 7243 Scripting.vcproj > > * 7243 . > ^^^^^^^^^^^^^^^^^^^^^^^^ > This might be the cause of the problem. Can you please try thing > patch: > > > Index: vc-svn.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v > retrieving revision 1.112 > diff -u -3 -p -u -p -r1.112 vc-svn.el > --- vc-svn.el 10 Feb 2009 05:59:14 -0000 1.112 > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000 > @@ -176,7 +176,7 @@ want to force an empty list of arguments > ;; FIXME are there other possible combinations? > (cond ((eq state 'edited) (setq state 'needs-merge)) > ((not state) (setq state 'needs-update)))) > - (when state > + (when (and state (not (string= "." filename))) > (setq result (cons (list filename state) result))))) > (funcall callback result))) > Thanks for this, I've installed it and will persuade my colleagues to do a few checkins :-) Not sure why svn should list '.' as needing an update. Unfortunately my svn is now up to date so I can't, currently, replicate this issue. Robert -- Robert A J Marshall, TNEI Services Ltd, 86-90 London Road, Manchester, M1 2PW Registered in England & Wales No. 03891836, Registered office: Milburn House, Dean Street, Newcastle upon Tyne, NE1 1LE tel: +44 161 615 6017; fax: +44 161 615 6001; mobile: +44 7759 688384 web: http://IPSA-Power.com