From: Jason Rumney <jasonr@gnu.org>
To: MJ <mj54590@gmail.com>, 2585@emacsbugs.donarmstrong.com
Cc: emacs-pretest-bug@gnu.org
Subject: bug#2585: 23.0.90; read-file-name with dialog
Date: Sat, 07 Mar 2009 15:50:25 +0800 [thread overview]
Message-ID: <49B22741.3000502@gnu.org> (raw)
In-Reply-To: <18865.28230.516000.264948@MJ.T42.T42>
Whoever did the conversion of read-file-name from C to lisp probably
knows what was meant by this, by my naive impression is that the
following logic is a mistake:
;; If DIR contains a file name, split it.
(let ((file (file-name-nondirectory dir)))
(when (and default-filename (not (zerop (length file))))
(setq default-filename file)
(setq dir (file-name-directory dir)))
The third line makes more sense to me as:
(when (and (not default-filename) (not (zerop (length file))))
ie. if default-filename is specified, then the splitting should NOT be done.
next prev parent reply other threads:[~2009-03-07 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49B51A3D.7040101@gnu.org>
2009-03-06 18:41 ` bug#2585: 23.0.90; read-file-name with dialog MJ
2009-03-07 7:50 ` Jason Rumney [this message]
2009-03-09 13:40 ` bug#2585: marked as done (23.0.90; read-file-name with dialog) Emacs bug Tracking System
2009-03-08 20:05 bug#2585: 23.0.90; read-file-name with dialog Chong Yidong
2009-03-08 20:24 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B22741.3000502@gnu.org \
--to=jasonr@gnu.org \
--cc=2585@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
--cc=mj54590@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.