From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Date: Mon, 21 Sep 2009 14:35:00 -0700 Message-ID: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> Reply-To: Drew Adams , 4510@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1253569642 14903 80.91.229.12 (21 Sep 2009 21:47:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2009 21:47:22 +0000 (UTC) To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 21 23:47:15 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mpqj4-0000oB-OF for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2009 23:47:15 +0200 Original-Received: from localhost ([127.0.0.1]:46271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mpqj3-000643-U5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2009 17:47:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mpqiz-00063n-C4 for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:47:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mpqiw-00063b-1g for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:47:09 -0400 Original-Received: from [199.232.76.173] (port=46292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mpqiv-00063Y-MC for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:47:05 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49655) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mpqiv-0001y7-4f for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:47:05 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LLl2vq028607; Mon, 21 Sep 2009 14:47:03 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8LLjAV7028351; Mon, 21 Sep 2009 14:45:10 -0700 Resent-Date: Mon, 21 Sep 2009 14:45:10 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 21 Sep 2009 21:45:09 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125356891227014 (code B ref -1); Mon, 21 Sep 2009 21:45:09 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 21 Sep 2009 21:35:12 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LLZATf026968 for ; Mon, 21 Sep 2009 14:35:12 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpqXO-0000fp-4t for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpqXI-0000eA-FX for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:09 -0400 Original-Received: from [199.232.76.173] (port=47714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpqXI-0000dx-7r for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Original-Received: from acsinet11.oracle.com ([141.146.126.233]:25110) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpqXH-0008WL-PT for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLaFKn028873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Sep 2009 21:36:16 GMT Original-Received: from abhmt012.oracle.com (abhmt012.oracle.com [141.146.116.21]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLZRIA007701 for ; Mon, 21 Sep 2009 21:35:27 GMT Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2009 14:34:58 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Aco7A18aOl2tGDhiRMCwXNdODwMFfQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt012.oracle.com [141.146.116.21] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4AB7F182.01E3:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 21 Sep 2009 17:47:09 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31326 Archived-At: Emacs 22 introduced face `help-argument-name' and function `help-default-arg-highlight'. The Emacs 22 NEWS says this: To change the default, customize face `help-argument-name' or redefine the function `help-default-arg-highlight'. The problem is that function `help-default-arg-highlight' couples (a) the use of a face to highlight the arguments with (b) downcasing the arguments. These two should be separated, so users can highlight without downcasing (or downcase without highlighting). I, for instance, find lowercase italics (the default, starting with Emacs 22) to be much less readable than uppercase non-italics (the default before Emacs 22). But I would really prefer uppercase italics. There is no way to get this, short of redefining the function `help-default-arg-highlight'. That should not be the only alternative for users. Users should not be expected to redefine basic functions in order to customize such appearances. And in any case, it makes no sense for the face and the letter case to be hard-code-coupled. This is the definition of `help-default-arg-highlight': (defun help-default-arg-highlight (arg) "Default function to highlight arguments in *Help* buffers. It returns ARG in face `help-argument-name'; ARG is also downcased if it displays differently than the default face (according to `face-differs-from-default-p')." (propertize (if (face-differs-from-default-p 'help-argument-name) (downcase arg) arg) 'face 'help-argument-name)) If face `help-argument-name' is different from the default face, then the args are downcased. The logic should simply be to apply the face systematically: if it is the same as the default, then the face would have no effect. And then provide a separate option to control upcasing/downcasing. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)'