From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#14029: 24.2.50; [PATCH] imenu problems with special elements Date: Sat, 23 Mar 2013 09:15:01 -0700 Message-ID: <497E84080AB04CFCBF0170ED70AC58A7@us.oracle.com> References: <87hak4gram.fsf@fh-trier.de><5ABDF35DFCF64DEEAA37AFAE5048578D@us.oracle.com><87ip4iwfoe.fsf@fh-trier.de> <878v5ew1pp.fsf@fh-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1364055363 8015 80.91.229.3 (23 Mar 2013 16:16:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Mar 2013 16:16:03 +0000 (UTC) To: "'Andreas Politz'" , <14029@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 23 17:16:29 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJR7N-0000gK-8i for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 17:16:29 +0100 Original-Received: from localhost ([::1]:60160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJR6z-00061A-Mg for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 12:16:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJR6v-00060u-9R for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 12:16:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJR6t-0007nM-Vj for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 12:16:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJR6t-0007nE-He for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 12:15:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UJR8r-0007Mk-KG for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 12:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2013 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14029-submit@debbugs.gnu.org id=B14029.136405543728262 (code B ref 14029); Sat, 23 Mar 2013 16:18:01 +0000 Original-Received: (at 14029) by debbugs.gnu.org; 23 Mar 2013 16:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:42409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJR89-0007Lm-0T for submit@debbugs.gnu.org; Sat, 23 Mar 2013 12:17:17 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:18904) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJR86-0007Ld-1U for 14029@debbugs.gnu.org; Sat, 23 Mar 2013 12:17:15 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r2NGF93Y010748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 23 Mar 2013 16:15:09 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r2NGF8fx027294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 23 Mar 2013 16:15:08 GMT Original-Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r2NGF8hc016602; Sat, 23 Mar 2013 11:15:08 -0500 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 23 Mar 2013 09:15:08 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 In-Reply-To: <878v5ew1pp.fsf@fh-trier.de> Thread-Index: Ac4n3vGaUJnpGjQ1QeWfDUqpCV6xLwAAMAag X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72836 Archived-At: Ok, thanks for the reply. I don't have time to look into it further - I mainly wanted you to clarify and double-check. Please consider adding some comments to the code to help understanding (e.g. wrt the fixed code). Both Stefan and I have mentioned that the code is not too clear on its own, and I imagine that you feel the same: it could be clearer with a couple of comments. Thx. >> This change looks good, but `cdddr' is in cl.el, so perhaps it is >> better to use (nthcdr 3 index-item). >> >> I'm only a little bit surprised that this one hasn't already been >> reported and fixed - there have been other bugs (e.g. #12717) related >> to special items. I use special items myself, but so far I have not >> used non-nil ARGS, so I have not encountered this one (your last change). > > That, and you probably always used the mouse menu. Actually, I use the keyboard, but my use of special items is limited to adding two special menu items (that toggle sorting and toggle case-sensitive sorting). FWIW, from the keyboard I use the commands described here: http://www.emacswiki.org/emacs/Icicles_-_Other_Search_Commands#IciclesImenu. They let you quickly choose among definitions of a given type, matching either the object name or its full definition.