From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed Date: Sat, 26 Nov 2022 21:58:35 +0100 Message-ID: <495b9dec-013f-5248-8a57-5539f16575d7@secure.kjonigsen.net> References: <87o7st4jid.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------cr0BD8eWqrFqec04vAKHjIC4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: Theodor Thornhill , Stefan Kangas , 59602@debbugs.gnu.org, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 21:59:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz2Gd-00098z-Id for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 21:59:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz2GQ-0000p6-3j; Sat, 26 Nov 2022 15:59:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz2GO-0000os-Ha for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:59:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz2GN-0001gn-St for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz2GL-0007BM-S5 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 15:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59602 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59602-submit@debbugs.gnu.org id=B59602.166949632827599 (code B ref 59602); Sat, 26 Nov 2022 20:59:01 +0000 Original-Received: (at 59602) by debbugs.gnu.org; 26 Nov 2022 20:58:48 +0000 Original-Received: from localhost ([127.0.0.1]:41570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2G8-0007B5-9M for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:58:48 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2G5-0007Az-Sz for 59602@debbugs.gnu.org; Sat, 26 Nov 2022 15:58:46 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CA9815C00A0; Sat, 26 Nov 2022 15:58:40 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 26 Nov 2022 15:58:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669496320; x=1669582720; bh=GZJqYiPovoc/MgODPwtPVgKSWMKGcbr776m ed+uEtZo=; b=yK/6BpGQ1Mj5YWQAaMX6/xRxqX79ub6lhCAHXu0eyWc/OKacngu W5EsBTPnGfajzYK6hDWprKrtwMubM85EhAMQSoIVDDtJdhebbfwJJkBJby/+/Wh5 XAJYINJgzkFMft4BhmY10yUZ+G2VMtEupYUkHk8iVPs0t6GUyo+KiDIntU6mTyiG WDErAa/QzrvAXn5I2vYk4AiEPyUfmujjItcL6uTrdjYe1qlJ+gCxZwlG1QrkGlRY 84gN7YRv7m32xh1WGyeXouWymmB9E4XKu9sByrEdqpr/njy5SdSYUxfwKPCTIVZ6 fTQxLzR3ypTiu6x/iej1g6nkqFRLc6R0qog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669496320; x=1669582720; bh=GZJqYiPovoc/M gODPwtPVgKSWMKGcbr776med+uEtZo=; b=a/7GbQ8j4Jn+BBCJYghGs3AsF38Eg j8JpcFSYx0NNjh41cOoG13ijHZO6diiI4GB68BwC8TY6LdDt/mPwfnaxPkVfnkaT MPrnmQDQXLRopSmyvpJkEqyo+zXiE5klN82yTr4gzW3fpvNQDVN8oX4K8Cyk8eeh zgKEQ9Y7pTb7zqnk1RUD3P8kcc9wF3SMCcRaN3vahZUC2EojYMpNQURxn4WL3xhI gkjIf9k9mZP04FFw6JUtN7oTL4vAwCNb6oG7sVyd1R/7jnhXACmcTO6HyHoSVgKH oACxx0bhYfFC3JROaX+sfq8ZycbzsEpH5rLuebp7HkpKT7UGM2QXWknPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieejgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvfhfhjgesrgdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdefuefhhfdvgfdtheeijedvheel jeeuleejhefhtdfhteffveduudfgheegjeelnecuffhomhgrihhnpehkjhhnihhgshgvnh drnhhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep jhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Nov 2022 15:58:39 -0500 (EST) Content-Language: nb-NO, en-GB In-Reply-To: <87o7st4jid.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249143 Archived-At: This is a multi-part message in MIME format. --------------cr0BD8eWqrFqec04vAKHjIC4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This may be a bit "on the side", but if me and Theodor are going to be maintaining csharp-mode in Emacs core, we currently face the slight "challenge" of not actually having write/push-access to the Emacs git-repo at savannah. That means that at top of our ability, we will be able to email in patches (like Theodor did now!) and hope for someone to review and/or merge them. While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes are taken in, I'm also not sure what the "normal" procedure is in cases like this. Are there someone particular we are recommended to CC in our emails to make sure the patches get picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it to emacs-devel instead? In short: Do you guys have any "onboarding guide" we can follow to make sure everyone is happy, and our patches get reviewed and applied efficiently? :) Any guidance appreciated! -- Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 26.11.2022 20:12, Theodor Thornhill wrote: > Stefan Kangas writes: > >> Severity: wishlist >> >> Is csharp-mode.el intended to be a :core package or should people just >> use the version that comes with Emacs? >> >> If the former, I guess some Version and Package-Requires headers >> are needed. >> >> If the latter, the compat code starting on line 512 could probably be >> removed. > I agree. The compat code should be removed. I don't thing we have much > to gain by maintaining this as a :core package, so here's a patch doing > what you suggest. I don't think that code should be part of Emacs at > all, if not absolutely necessary :-) > > Theo > --------------cr0BD8eWqrFqec04vAKHjIC4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

This may be a bit "on the side", but if me and Theodor are going to be maintaining csharp-mode in Emacs core, we currently face the slight "challenge" of not actually having write/push-access to the Emacs git-repo at savannah.

That means that at top of our ability, we will be able to email in patches (like Theodor did now!) and hope for someone to review and/or merge them.

While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes are taken in, I'm also not sure what the "normal" procedure is in cases like this.

Are there someone particular we are recommended to CC in our emails to make sure the patches get picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it to emacs-devel instead?

In short: Do you guys have any "onboarding guide" we can follow to make sure everyone is happy, and our patches get reviewed and applied efficiently? :)

Any guidance appreciated!

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 26.11.2022 20:12, Theodor Thornhill wrote:
Stefan Kangas <stefankangas@gmail.com> writes:


Severity: wishlist

Is csharp-mode.el intended to be a :core package or should people just
use the version that comes with Emacs?

If the former, I guess some Version and Package-Requires headers
are needed.

If the latter, the compat code starting on line 512 could probably be
removed.

I agree.  The compat code should be removed.  I don't thing we have much
to gain by maintaining this as a :core package, so here's a patch doing
what you suggest.  I don't think that code should be part of Emacs at
all, if not absolutely necessary :-)

Theo
--------------cr0BD8eWqrFqec04vAKHjIC4--