all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* image-file-yank-handler
@ 2008-12-26 11:24 martin rudalics
  2019-08-01 14:19 ` image-file-yank-handler Basil L. Contovounesios
  0 siblings, 1 reply; 2+ messages in thread
From: martin rudalics @ 2008-12-26 11:24 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

I don't use `image-file-yank-handler' but suppose its handling of
`yank-excluded-properties' is wrong and something like the attached
patch is needed.

martin

[-- Attachment #2: image-file.diff --]
[-- Type: text/plain, Size: 913 bytes --]

*** image-file.el.~1.34.~	2008-12-03 07:33:30.468750000 +0100
--- image-file.el	2008-12-26 12:18:42.562500000 +0100
***************
*** 143,149 ****
    "Yank handler for inserting an image into a buffer."
    (let ((len (length string))
  	(image (get-text-property 0 'display string)))
!     (remove-text-properties 0 len yank-excluded-properties string)
      (if (consp image)
  	(add-text-properties 0
  			     (or (next-single-property-change 0 'image-counter string)
--- 143,151 ----
    "Yank handler for inserting an image into a buffer."
    (let ((len (length string))
  	(image (get-text-property 0 'display string)))
!     (if (eq yank-excluded-properties t)
! 	(set-text-properties 0 len nil string)
!       (remove-list-of-text-properties 0 len yank-excluded-properties string))
      (if (consp image)
  	(add-text-properties 0
  			     (or (next-single-property-change 0 'image-counter string)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: image-file-yank-handler
  2008-12-26 11:24 image-file-yank-handler martin rudalics
@ 2019-08-01 14:19 ` Basil L. Contovounesios
  0 siblings, 0 replies; 2+ messages in thread
From: Basil L. Contovounesios @ 2019-08-01 14:19 UTC (permalink / raw)
  To: martin rudalics; +Cc: emacs-devel

martin rudalics <rudalics@gmx.at> writes:

> I don't use `image-file-yank-handler' but suppose its handling of
> `yank-excluded-properties' is wrong and something like the attached
> patch is needed.
>
> martin
>
> *** image-file.el.~1.34.~	2008-12-03 07:33:30.468750000 +0100
> --- image-file.el	2008-12-26 12:18:42.562500000 +0100
> ***************
> *** 143,149 ****
>     "Yank handler for inserting an image into a buffer."
>     (let ((len (length string))
>   	(image (get-text-property 0 'display string)))
> !     (remove-text-properties 0 len yank-excluded-properties string)
>       (if (consp image)
>   	(add-text-properties 0
>   			     (or (next-single-property-change 0 'image-counter string)
> --- 143,151 ----
>     "Yank handler for inserting an image into a buffer."
>     (let ((len (length string))
>   	(image (get-text-property 0 'display string)))
> !     (if (eq yank-excluded-properties t)
> ! 	(set-text-properties 0 len nil string)
> !       (remove-list-of-text-properties 0 len yank-excluded-properties string))
>       (if (consp image)
>   	(add-text-properties 0
>   			     (or (next-single-property-change 0 'image-counter string)

I have now down so on master:

Fix usage of remove-text-properties
2267110b6f 2019-08-01 17:04:53 +0300
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2267110b6f00bbb0ad87f4621e6ecd9dc1bd8581

Fix property stripping in image-file-yank-handler
1aa31b5f89 2019-08-01 17:16:05 +0300
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1aa31b5f8911cc422644916c7652a90add7d5fd5

Thanks,

-- 
Basil



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-01 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-26 11:24 image-file-yank-handler martin rudalics
2019-08-01 14:19 ` image-file-yank-handler Basil L. Contovounesios

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.