all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Geoff Gole <geoffgole@gmail.com>
Cc: 1662@emacsbugs.donarmstrong.com
Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face
Date: Wed, 24 Dec 2008 11:22:16 +0100	[thread overview]
Message-ID: <49520D58.3070006@gmx.at> (raw)
In-Reply-To: <f5bc73230812232155j1fe0233dhc5e183166de0511f@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

 > However, I do think that highlighting prompts in the
 > minibuffer is a good idea even in situations where the minibuffer is
 > not used directly.

Could you try the attached patch?

Thanks, martin.

[-- Attachment #2: prompt.diff --]
[-- Type: text/plain, Size: 2399 bytes --]

*** callint.c.~1.167.~	2008-05-14 09:49:11.000000000 +0200
--- callint.c	2008-12-24 11:09:49.859375000 +0100
***************
*** 45,50 ****
--- 45,51 ----
  
  Lisp_Object Vcommand_debug_status, Qcommand_debug_status;
  Lisp_Object Qenable_recursive_minibuffers;
+ extern Lisp_Object Qface, Qminibuffer_prompt;
  
  /* Non-nil means treat the mark as active
     even if mark_active is 0.  */
***************
*** 541,546 ****
--- 542,550 ----
  	  break;
  
          case 'c':		/* Character */
+ 	  Fput_text_property (make_number (0),
+ 			      make_number (SCHARS (callint_message)),
+ 			      Qface, Qminibuffer_prompt, callint_message);
  	  args[i] = Fread_char (callint_message, Qnil, Qnil);
  	  message1_nolog ((char *) 0);
  	  /* Passing args[i] directly stimulates compiler bug */
***************
*** 594,599 ****
--- 598,606 ----
  	  {
  	    int speccount1 = SPECPDL_INDEX ();
  	    specbind (Qcursor_in_echo_area, Qt);
+ 	    Fput_text_property (make_number (0),
+ 				make_number (SCHARS (callint_message)),
+ 				Qface, Qminibuffer_prompt, callint_message);
  	    args[i] = Fread_key_sequence (callint_message,
  					  Qnil, Qnil, Qnil, Qnil);
  	    unbind_to (speccount1, Qnil);
***************
*** 622,627 ****
--- 629,637 ----
  	  {
  	    int speccount1 = SPECPDL_INDEX ();
  	    specbind (Qcursor_in_echo_area, Qt);
+ 	    Fput_text_property (make_number (0),
+ 				make_number (SCHARS (callint_message)),
+ 				Qface, Qminibuffer_prompt, callint_message);
  	    args[i] = Fread_key_sequence (callint_message,
  					  Qnil, Qt, Qnil, Qnil);
  	    teml = args[i];

*** textprop.c.~1.163.~	2008-11-03 18:21:08.015625000 +0100
--- textprop.c	2008-12-24 11:17:14.859375000 +0100
***************
*** 57,62 ****
--- 57,63 ----
  /* Visual properties text (including strings) may have.  */
  Lisp_Object Qforeground, Qbackground, Qfont, Qunderline, Qstipple;
  Lisp_Object Qinvisible, Qread_only, Qintangible, Qmouse_face;
+ Lisp_Object Qminibuffer_prompt;
  
  /* Sticky properties */
  Lisp_Object Qfront_sticky, Qrear_nonsticky;
***************
*** 2334,2339 ****
--- 2335,2342 ----
    Qrear_nonsticky = intern ("rear-nonsticky");
    staticpro (&Qmouse_face);
    Qmouse_face = intern ("mouse-face");
+   staticpro (&Qminibuffer_prompt);
+   Qminibuffer_prompt = intern ("minibuffer-prompt");
  
    /* Properties that text might use to specify certain actions */
  

  parent reply	other threads:[~2008-12-24 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24  5:55 bug#1662: 23.0.60; Interactive not using minibuffer prompt face Geoff Gole
2008-12-24 10:16 ` Lennart Borgman
2008-12-24 10:22 ` martin rudalics [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-12-24 14:27 Geoff Gole
2008-12-21 21:43 Geoff Gole
2008-12-23  7:59 ` martin rudalics
2008-12-23 20:45   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49520D58.3070006@gmx.at \
    --to=rudalics@gmx.at \
    --cc=1662@emacsbugs.donarmstrong.com \
    --cc=geoffgole@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.