From: richardeng <richardeng@foxmail.com>
To: Andy Stewart <lazycat.manatee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Integrate sr-speedbar.el with speedbar.el
Date: Sun, 21 Dec 2008 12:27:56 +0800 [thread overview]
Message-ID: <494DC5CC.7040608@foxmail.com> (raw)
In-Reply-To: <87abasw1wk.fsf@debian.domain>
Andy Stewart wrote:
> Hi all,
>
> Speedbar is very useful for file browser or other programming.
> But this have a big problem is, speedbar is show in other frame.
> So need switch between two frame, not very convenient.
>
> And have a exist extension sr-speedbar.el (write by "Sebastian Rose")
> can make speedbar show in same frame.
>
> Find it at: http://www.emacswiki.org/emacs/download/sr-speedbar.el
>
> I'm another developer of sr-speedbar.
> I have attached newest version of sr-speedbar.
>
> I want to integrate sr-speedbar with speedbar.
> "Sebastian Rose" and me were sign copyright of FSF.
>
> Any suggestion?
>
> -- Andy
>
>
I love this feature, it's useful in console.
Bug 1:
eval (sr-speedbar-close) twice, then (sr-speedbar-open) got following error:
Window width 0 too small (after splitting)
So, check sr-speedbar before real closing:
-----------------------
diff -c /tmp/sr-speedbar.el\~ /tmp/sr-speedbar.el
--- /tmp/sr-speedbar.el~ 2008-11-06 07:57:08.000000000 -0800
+++ /tmp/sr-speedbar.el 2008-11-06 07:59:21.000000000 -0800
@@ -270,16 +270,17 @@
(interactive)
(let ((current-window (selected-window)))
(if (and sr-speedbar-window
- speedbar-buffer
- (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible
- (buffer-live-p speedbar-buffer)) ;and contain `speedbar-buffer'
- (sr-speedbar-select-window)
- (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value
- (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore same width
- (bury-buffer)
- (if (and current-window
- (window-live-p current-window))
- (select-window current-window)))))
+ speedbar-buffer
+ (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible
+ (buffer-live-p speedbar-buffer)) ;and contain `speedbar-buffer'
+ (progn
+ (sr-speedbar-select-window)
+ (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value
+ (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore same width
+ (bury-buffer)
+ (if (and current-window
+ (window-live-p current-window))
+ (select-window current-window))))))
Bug 2: trivial bug
;;; Installation:
;;
;; Copy sr-speedbar.el to your load-path and add to your ~/.emacs
;;
;; (require 'sr-speedbar)
;; (global-set-key (kbd "s-s") 'sr-speedbar-togge) // --> toggle
;;
;; ... or any key binding you like.
Bug 3: (speedbar) then (sr-speedbar-open) report error "Wrong type argument: stringp, nil"
next prev parent reply other threads:[~2008-12-21 4:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 16:44 Integrate sr-speedbar.el with speedbar.el Andy Stewart
2008-12-20 1:43 ` Chong Yidong
2008-12-20 3:35 ` Re[2]: " Eric M. Ludlam
2008-12-20 3:42 ` Andy Stewart
2008-12-20 13:14 ` Re[1]: " Eric M. Ludlam
2008-12-20 4:32 ` Chong Yidong
2008-12-20 4:36 ` Andy Stewart
2008-12-21 4:27 ` richardeng [this message]
2008-12-21 4:49 ` Andy Stewart
2008-12-21 6:42 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494DC5CC.7040608@foxmail.com \
--to=richardeng@foxmail.com \
--cc=emacs-devel@gnu.org \
--cc=lazycat.manatee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.