ansi-color.el and comint.el

ansi-color.el and comint.el

[Stephan Stahl]

Hi.

ansi-color.el may overwrite comint-output-filter-functions if it is
loaded before comint.el.  That is because ansi-color.el does a simple

(add-hook 'comint-output-filter-functions
	  'ansi-color-process-output)

Now comint-output-filter-functions is defined and when later comint.el
is loaded its own

(defvar comint-output-filter-functions '(comint-postoutput-scroll-to-bottom
comint-watch-for-password-prompt)

does nothing so those two functions may be missing.  I'm not sure how
this is fixed best.  Either have comint.el do:

(defvar comint-output-filter-functions nil)

(add-hook 'comint-output-filter-functions
	  'comint-watch-for-password-prompt)
(add-hook 'comint-output-filter-functions
	  'comint-postoutput-scroll-to-bottom)

or have ansi-color.el require comint.  If anyone else thinks this
should be fixed :)
-- 
Stephan Stahl

Re: ansi-color.el and comint.el

[Luc Teirlinck]

Stephan Stahl wrote:

   ansi-color.el may overwrite comint-output-filter-functions if it is
   loaded before comint.el.  That is because ansi-color.el does a simple

   (add-hook 'comint-output-filter-functions
	     'ansi-color-process-output)

   Now comint-output-filter-functions is defined and when later comint.el
   is loaded its own

   (defvar comint-output-filter-functions '(comint-postoutput-scroll-to-bottom
   comint-watch-for-password-prompt)

   does nothing so those two functions may be missing.  I'm not sure how
   this is fixed best.

Would autoloading comint-output-filter-functions not work?  But the
same problem could happen to any hook whose defvar gives it a non-nil
value.  So I guess that any defvar of such a type that is not in a
preloaded file should be autoloaded,

Sincerely,

Luc.

Re: ansi-color.el and comint.el

[Stephan Stahl]

Luc Teirlinck said:

> Would autoloading comint-output-filter-functions not work?  But the
> same problem could happen to any hook whose defvar gives it a
> non-nil value.  So I guess that any defvar of such a type that is
> not in a preloaded file should be autoloaded,

Yes that would work too.  Using require might have been a nice example
for "check your dependencies".  Not very important.  So autoload seems
like the ideal solution since both files are part of emacs.

Kevin Rodgers said:

> Would it work if ansi-color-for-comint-mode-on added
> ansi-color-process-output to comint-output-filter-functions?  If so,
> should ansi-color-for-comint-mode-off remove it?

No, because this does not change the fact that comint.el may not be
loaded.

When ansi-color.el does that add-hook when comint.el is not already
loaded comint-output-filter-functions is set to
(ansi-color-process-output)

When comint.el is already loaded comint-output-filter-functions is set
to (ansi-color-process-output comint-postoutput-scroll-to-bottom
comint-watch-for-password-prompt)
-- 
Stephan Stahl

Re: ansi-color.el and comint.el

[Kevin Rodgers]

Stephan Stahl wrote:
 > Hi.
 >
 > ansi-color.el may overwrite comint-output-filter-functions if it is
 > loaded before comint.el.  That is because ansi-color.el does a simple
 >
 > (add-hook 'comint-output-filter-functions
 > 	  'ansi-color-process-output)
 >
 > Now comint-output-filter-functions is defined and when later comint.el
 > is loaded its own
 >
 > (defvar comint-output-filter-functions 
'(comint-postoutput-scroll-to-bottom
 > comint-watch-for-password-prompt)
 >
 > does nothing so those two functions may be missing.  I'm not sure how
 > this is fixed best.  Either have comint.el do:
 >
 > (defvar comint-output-filter-functions nil)
 >
 > (add-hook 'comint-output-filter-functions
 > 	  'comint-watch-for-password-prompt)
 > (add-hook 'comint-output-filter-functions
 > 	  'comint-postoutput-scroll-to-bottom)
 >
 > or have ansi-color.el require comint.  If anyone else thinks this
 > should be fixed :)

Would it work if ansi-color-for-comint-mode-on added
ansi-color-process-output to comint-output-filter-functions?  If so,
should ansi-color-for-comint-mode-off remove it?

-- 
Kevin Rodgers