From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Sun, 13 Dec 2020 01:56:13 +0200 Message-ID: <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> References: <87sg8b5k4b.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 29193@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 13 00:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koElD-0007eh-W6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 00:57:11 +0100 Original-Received: from localhost ([::1]:48114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koElD-0001MW-2i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 18:57:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koEl4-0001MH-O0 for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 18:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koEl4-0007PQ-A5 for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 18:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koEl4-00037S-8W for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 18:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Dec 2020 23:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160781738811947 (code B ref 29193); Sat, 12 Dec 2020 23:57:02 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 12 Dec 2020 23:56:28 +0000 Original-Received: from localhost ([127.0.0.1]:47129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koEkW-00036c-87 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 18:56:28 -0500 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:45802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koEkP-00036E-Uy for 29193@debbugs.gnu.org; Sat, 12 Dec 2020 18:56:27 -0500 Original-Received: by mail-wr1-f50.google.com with SMTP id t4so12727582wrr.12 for <29193@debbugs.gnu.org>; Sat, 12 Dec 2020 15:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fKBprFj5wYRe6eAAI2MvS6nXAHfUA1CY6yp+UkAOgF0=; b=pTrU9S3jtV1tA7vMQDh2/b84P9FZyKdlJiceBxpdcNS1wEyWMUfdV3um5Wdy9b8qvU 0K8rL8t1tHMF2ki5vXt2aoWH6MkNEZpWcoB/KOoj9WllPD3gnD1IUlzfYGWNeUoLFJnm 881Gaf3am8E2eAWMWPfHCu6ZOQ21GAxIoSzUGI91tnGg7apwkbmGxj+wp6xbB4f3fPMy AZAjiPXYgETV9ruudTxjAMy83MRFyTwVeu/BcLo5S2V4TTUA93/CNOjTJF1BlVkW1+dn 8NCScjYnsXuaubCwtO25WjrwxeAwVH6EB4JO0FeMxHliD8U/tUDmZvEDz30JV1i6IL6c tvcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fKBprFj5wYRe6eAAI2MvS6nXAHfUA1CY6yp+UkAOgF0=; b=Gh41HbbH94GJTwFVel2OZrQrEWxC7BGLVtM3zX3Ayrb3nTgglBF3raeeTvWLGwKoip 3+j+/T82NQcsPWPKDxit04mVIoH24M8D2oBxTh0be7hw39N4KrbzQWG4KxHWC1OvlJTY j9xB4SkUvqoUvRg8aCQHWF20I7xKuSXLkHao+l4baFH5QHPvESm6H7xDBusx9y9Ko5Nx dpIS2xR1OpFIzAFvwNaHuW9zpwSZpGyJg7EQbZqqheYmS/YwpHDLufvxpDuQZLk2LvpA OtxWiWweX+ig2InITtr43sJxmnL6fAQIyqa13Z8eo6cev4lbxudwncD5HFmU1DmAdQx4 25wA== X-Gm-Message-State: AOAM530w6NJMW6tjXO6j5i2SshWGSTpFHh1O6ujXS/ekgRS1hmR6Nqrn 5ptlQ4VmMcJDa772dX5F50kQ359TvCKkFw== X-Google-Smtp-Source: ABdhPJzqB9jZSoVn8wHm3/bNKBcf48HLx1up/mlL27Y1ohapI/OfWWSTJ3qmjYh3KdUzs4eUAHbMdQ== X-Received: by 2002:adf:9e4c:: with SMTP id v12mr20752040wre.22.1607817375548; Sat, 12 Dec 2020 15:56:15 -0800 (PST) Original-Received: from [192.168.0.5] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j2sm22860478wrt.35.2020.12.12.15.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Dec 2020 15:56:14 -0800 (PST) In-Reply-To: <87sg8b5k4b.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195921 Archived-At: On 12.12.2020 13:39, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> Rubocop can report warning when 'end' is at wrong column. It just >> reports the beginning column, of course. >> >> In ruby-mode, (thing-at-point 'sexp) signals an error at this position. >> I'm not sure exactly whether it's a problem in ruby-mode. >> >> But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the >> whole 'end' token gets highlighted (which is probably what we expect). >> >> In contrast, Flymake only highlights its first character ('e'). > > I had a look at the current `flymake-diag-region', and it does not use > (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), > though. The behavior is the same: when 'end' is misindented, only 'e' in 'end' is highlighted. Whereas the message is: Layout/EndAlignment: ‘end‘ at 23, 3 is not aligned with ‘class‘ at 5, 4. That highlighting is not too hard to interpret, but we could do better, probably.