all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: 62592@debbugs.gnu.org
Subject: bug#62592: Not creating new Tabs with small window
Date: Thu, 18 May 2023 10:30:12 +0200	[thread overview]
Message-ID: <493d0d56-2041-81cf-279e-6d6128b366e7@gmx.at> (raw)
In-Reply-To: <86sfbulwfc.fsf@mail.linkov.net>

 > Thanks for the suggestion.  Empirically I found that
 > '(split-window-horizontally 1)' always fails.
 > So the next patch uses '(split-window-horizontally 2)'.

1 is less than 'window-safe-min-width' (the doc-string of 'split-window'
says in this regard that "this function can make a new window as small
as one line or two columns").  And are you sure you want to copy the
'quit-restore' parameter?  As a rule, in Lisp code never use the
-vertically/-horizontally postfixed forms of 'split-window' unless you
want to mock their interactive behavior.

 >> For Emacs 30 I'd recommend a new routine say 'clean-window' to make its
 >> argument window pristine.  The way you do it now loses all overlays with
 >> a window property in the window's buffer.
 >
 > The purpose of this trick is to change window identity.  So maybe
 > a better name would be 'clone-window'?

Funny - here I use that for a window that can shadow an existing window
for redisplay purposes.  If you want the selected window to change
identity, you should say that in a comment.

martin





  reply	other threads:[~2023-05-18  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01 12:48 bug#62592: Not creating new Tabs with small window Claudio Grondi
2023-04-02  6:52 ` Juri Linkov
2023-04-02 17:49   ` Juri Linkov
2023-04-02 18:02     ` Eli Zaretskii
2023-04-25 17:28       ` Juri Linkov
2023-05-16 17:34     ` Juri Linkov
2023-05-17  7:07       ` martin rudalics
2023-05-17 16:46         ` Juri Linkov
2023-05-18  8:30           ` martin rudalics [this message]
2023-05-18 15:50             ` Juri Linkov
2023-05-19  7:31               ` martin rudalics
2023-05-19 18:04                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493d0d56-2041-81cf-279e-6d6128b366e7@gmx.at \
    --to=rudalics@gmx.at \
    --cc=62592@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.