From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Date: Thu, 04 Dec 2008 18:58:55 +0100 Message-ID: <49381A5F.6070902@gmx.at> References: <87fxl446mr.fsf@escher.local.home> Reply-To: martin rudalics , 1488@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1228414280 2248 80.91.229.12 (4 Dec 2008 18:11:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Dec 2008 18:11:20 +0000 (UTC) Cc: 1488@emacsbugs.donarmstrong.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 04 19:12:23 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L8IgH-0000rt-1w for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2008 19:12:05 +0100 Original-Received: from localhost ([127.0.0.1]:35623 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8If6-0005WR-Hm for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2008 13:10:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L8Ieb-0004wV-Rt for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 13:10:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L8IeY-0004rU-W0 for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 13:10:20 -0500 Original-Received: from [199.232.76.173] (port=42342 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8IeY-0004rF-R4 for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 13:10:18 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44561) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L8IeY-0000ZS-Bz for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 13:10:18 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB4IADVZ014682; Thu, 4 Dec 2008 10:10:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB4IA67j014267; Thu, 4 Dec 2008 10:10:06 -0800 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 04 Dec 2008 18:10:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1488 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1488-submit@emacsbugs.donarmstrong.com id=B1488.122841379712085 (code B ref 1488); Thu, 04 Dec 2008 18:10:06 +0000 Original-Received: (at 1488) by emacsbugs.donarmstrong.com; 4 Dec 2008 18:03:17 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mB4I3DOm012071 for <1488@emacsbugs.donarmstrong.com>; Thu, 4 Dec 2008 10:03:15 -0800 Original-Received: (qmail invoked by alias); 04 Dec 2008 18:03:06 -0000 Original-Received: from 88-117-47-114.adsl.highway.telekom.at (EHLO [88.117.47.114]) [88.117.47.114] by mail.gmx.net (mp063) with SMTP; 04 Dec 2008 19:03:06 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+3Hl1tgZa3+ikxVRpWGAGO8mq98//j9DiucpQ8q9 3eyZ1QMKLSe2eR User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: <87fxl446mr.fsf@escher.local.home> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 04 Dec 2008 13:10:20 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22947 Archived-At: > However, unless I'm missing something, fit-window-to-buffer does what > dired-pop-to-buffer's shrink-to-fit code does, and moreover also handles > header lines. In addition we have the problem that `split-height-threshold' can be now nil in ((and (> (window-height (setq w2 (get-largest-window))) split-height-threshold) > I'm not able to fix the display code to let window-height return > fractional line numbers, so I propose the following patch: If there are no objections, I'll commit that in a couple of days. > (Note that if the frame is shrunk so that not all marked file names fit > in the *Marked Files* window, then without an oversized header line as > is my-mm, dired-pop-to-buffer fails with the error "Attempt to delete > minibuffer or sole ordinary window"; whereas with an oversized header > line, this error is raised only if not even one file name can be shown. > But I see this difference in behavior whether or not the above patch is > applied.) I cannot reproduce that here. That is, marking in a dired buffer more files than there fit on the frame and typing C gives me a single-window frame here with some files not shown - no error. martin