all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 1450@emacsbugs.donarmstrong.com
Subject: bug#1450: w32_reset_fringes
Date: Sun, 30 Nov 2008 10:19:33 +0100	[thread overview]
Message-ID: <49325AA5.8080506@gmx.at> (raw)
In-Reply-To: <878wr2guja.fsf@escher.local.home>

Thanks for testing this.

 > I tried your patch after updating from the current CVS HEAD.  Now
 > starting with emacs -q --eval "(setq default-frame-alist
 > '((minibuffer)))" and trying to delete the minibuffer frame via the
 > window manager does not crash Emacs, but instead results in no deleted
 > frame and the error message "Attempt to delete a surrogate minibuffer
 > frame" (from handle-delete-frame).  Likewise, C-x 5 0 from the
 > minibuffer frame does not delete it, again showing the error message
 > (now from call-interactively).  With a non-minibuffer frame deletion via
 > either the window manager or C-x 5 0 succeeds; then as soon as I click
 > in the minibuffer frame, a new regular frame is created.

I think that's the intended behavior.  At least it was until Emacs 22.
And delete_frame depends on doing so as explained by this comment

	  /* We know that there must be some frame with a minibuffer out
	     there.  If this were not true, all of the frames present
	     would have to be minibufferless, which implies that at some
	     point their minibuffer frames must have been deleted, but
	     that is prohibited at the top; you can't delete surrogate
	     minibuffer frames.  */

 > As for starting with emacs -q and the evalling (delete-frame nil t),
 > this also does not make Emacs crash, but raises the error "Attempt to
 > delete the only frame".

This is new behavior, obviously (it was there in the code, but commented
out).

 > However, I apparently was mistaken in my post
 > cited above: I thought evalling (delete-frame nil t) produced a core
 > dump, like the attempt to delete the minibuffer frame did,

Could you (or someone else on GNU/Linux) post a backtrace for the
minibuffer deletion case?

 > but I cannot
 > reproduce that with the unpatched Emacs, so I must have been confused
 > about the source of the core file (which I since deleted).  Instead,
 > evalling (delete-frame nil t) in the unpatched Emacs simply kills Emacs,
 > verified under gdb ("Program exited normally.").  Sorry for misreporting
 > this yesterday.

That's what Emacs 22 did in that case - exit normally.  But Emacs 22 did
_not_ offer to save any unsaved buffers, so you might have lost some
work.  Does it offer to save buffers on your Emacs 23?

martin







  reply	other threads:[~2008-11-30  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <49509A54.8000403@gmx.at>
2008-11-28 12:52 ` bug#1450: w32_reset_fringes martin rudalics
2008-11-28 13:22   ` martin rudalics
2008-11-28 17:27     ` martin rudalics
2008-11-28 22:04       ` Stephen Berman
2008-11-29 11:43         ` martin rudalics
2008-11-29 20:13           ` Stephen Berman
2008-11-30  9:19             ` martin rudalics [this message]
2008-12-02 14:14               ` Stephen Berman
2008-12-02 15:54                 ` martin rudalics
2008-12-23  8:05   ` bug#1450: marked as done (w32_reset_fringes) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49325AA5.8080506@gmx.at \
    --to=rudalics@gmx.at \
    --cc=1450@emacsbugs.donarmstrong.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.