From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Platon Pronko Newsgroups: gmane.emacs.bugs Subject: bug#34821: discard_input_tty does not discard pending input, resulting in garbage inserted into the buffer Date: Sun, 7 Apr 2019 20:14:21 +0300 Message-ID: <492c723c-6ba9-24da-108f-b25cef0dd54e@gmail.com> References: <6e2317c9-5063-3718-740e-f53c70f5db5b@gmail.com> <83v9zp93gq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65411"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 To: 34821@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 19:15:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDBNy-000Grk-CP for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 19:15:14 +0200 Original-Received: from localhost ([127.0.0.1]:41480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDBNu-0004as-65 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 13:15:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDBNo-0004aR-Aa for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 13:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDBNn-0003n1-EY for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 13:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDBNm-0003mB-FD for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 13:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDBNm-0000K8-7H for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 13:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Platon Pronko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34821 X-GNU-PR-Package: emacs Original-Received: via spool by 34821-submit@debbugs.gnu.org id=B34821.15546572731189 (code B ref 34821); Sun, 07 Apr 2019 17:15:02 +0000 Original-Received: (at 34821) by debbugs.gnu.org; 7 Apr 2019 17:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:48658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDBNJ-0000J7-Bu for submit@debbugs.gnu.org; Sun, 07 Apr 2019 13:14:33 -0400 Original-Received: from mail-lf1-f65.google.com ([209.85.167.65]:41753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDBNH-0000Is-AO for 34821@debbugs.gnu.org; Sun, 07 Apr 2019 13:14:32 -0400 Original-Received: by mail-lf1-f65.google.com with SMTP id 10so7705184lfr.8 for <34821@debbugs.gnu.org>; Sun, 07 Apr 2019 10:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=5Mw5MJxDhneoHs5xtlkiSwOiiZPYMuo3s7B5LDCGfZo=; b=RrF1pVulwbgxUASZ7p6u9VPPp9CbBmBi11BWKlfCJnE0uAN0p/ljYyZrrNB1lBed+d +OzsJr2JTAz3pYbtfuzlvcLQR8mcK69Iso/dV31QMAb8PQIlUyGraKSbY6qHfeh1aTbM kfAP/WbVzneHDUxwMXKxbp7JaBG6gKCKDN7m0LreN0P95rEr4SgADgvXf62QU8HUgr/2 qzOES/Y+ER+X2nUiNtfoPMB5MQj7M81uVs5DQho5ZHfyJtikqSbk4oFlyRAheI/3zm4S nfPrl8hKctWag8n15DO1l3d/c8Uur/mBGa8V2QCmZ3OqvVVlHP/BA+YoSkTCZlJp3bXE mDNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5Mw5MJxDhneoHs5xtlkiSwOiiZPYMuo3s7B5LDCGfZo=; b=i273vOHdYyJBV0EViSZ4qV7Xmy9ZRCsHEwmAchwlt59Ucvr/dmXadM6CMYvy+84sFl 9qz17VeA872LYEcO4TwsWcr9ClvYXV3rYdl88+fiDUgWRmZMJXBoDSxgj8F6L3OmCnzI d+yt8UFj+mUVQx4XRPQjiXtYM94v1tcAiczhbQP1fS1FOtCDQ8mN2sPgfvBiitu68Aml nWMomBfYFBpGxnW5vaoXHi2tctmiTjOtpqhcNC1i3sY1qGaQ+cFEOyeSHzj4jqgxCug7 j82ih2ZMjuLtZCpXhzqTVJmxAUJAxADILTEKDFCZnh7s45M1MER7JYc99gSp9eyWNJTk JC8w== X-Gm-Message-State: APjAAAWMvsG2K3vWJ3PV8kGCg52ekM1va+40o/lnRykobdyYpbqDN9Ek LuLmIbtv6WCxB+QfD2bHnVHWFOWk X-Google-Smtp-Source: APXvYqxLzO+3hvnZAisJxuQEqglJ7TnO7XPWkHKIrYC6mhH9f1mxu+kmPQlUc2N2vBitjWNS8dh9TQ== X-Received: by 2002:ac2:4421:: with SMTP id w1mr13349627lfl.97.1554657264886; Sun, 07 Apr 2019 10:14:24 -0700 (PDT) Original-Received: from [192.168.1.65] (109-252-80-126.nat.spd-mgts.ru. [109.252.80.126]) by smtp.gmail.com with ESMTPSA id i66sm5881781lji.43.2019.04.07.10.14.23 for <34821@debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 10:14:24 -0700 (PDT) In-Reply-To: <83v9zp93gq.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157315 Archived-At: I guess that something in (terminal-init-xterm) hooks results in some buffer switch event being fired, that triggers the second return from read_char(). But since (terminal-init-xterm) and read_key_sequence() run concurrently, we have a race condition - if the terminal responds quickly enough, second buffer switch does not trigger quick enough and this problem happens. I verified this by adding (sleep-for 0.1) to (defun xterm--query) or (defun terminal-init-xterm) - this resulted in 100% reproduction of the bug (thanks for the directions, by the way - my hands already hurt after trying to trigger that 1-in-10 bug so many times). Maybe trying to rely on terminal being slow with the response is not the best solution? Even if I find a cause of the buffer switch event, we won't have a way to ensure that it always arrives before the response to SDA query (because multithreading).