Bug: appt-display makes point back to buffer.

Bug: appt-display makes point back to buffer.

[anhnmncb]

When point is in minibuffer, a pop-up of appointment window will make
point back to the buffer. I have to use C-x o to switch back to it.

GNU Emacs 23.0.60.1 (i386-mingw-nt5.0.2195) of 2008-11-18 on mybox.

Re: Bug: appt-display makes point back to buffer.

[martin rudalics]

 > When point is in minibuffer, a pop-up of appointment window will make
 > point back to the buffer. I have to use C-x o to switch back to it.
 >
 > GNU Emacs 23.0.60.1 (i386-mingw-nt5.0.2195) of 2008-11-18 on mybox.

Could you please make a bug report with a precise recipe to reproduce
this with emacs -Q?

Thanks in advance, martin.

Re: Bug: appt-display makes point back to buffer.

[anhnmncb]

martin rudalics <rudalics@gmx.at> writes:

>> When point is in minibuffer, a pop-up of appointment window will make
>> point back to the buffer. I have to use C-x o to switch back to it.
>>
>> GNU Emacs 23.0.60.1 (i386-mingw-nt5.0.2195) of 2008-11-18 on mybox.
>
> Could you please make a bug report with a precise recipe to reproduce
> this with emacs -Q?
>
> Thanks in advance, martin.
yes, here we go:

emacs -Q

eval (appt-activate 1) in *scratch* buffer.

Use M-x appt-add to add a time to appt. Then C-x C-f to enter the
minibuf area, waits for the appt activates.

When activates, the point moves from minibuf to buffer(maybe call
window?). Now I have to C-x o to enter the minibuf.

emacs version:
GNU Emacs 23.0.60.1 (i386-mingw-nt5.0.2195) of 2008-11-18 on mybox

Re: Bug: appt-display makes point back to buffer.

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

> emacs -Q
> 
> eval (appt-activate 1) in *scratch* buffer.
> 
> Use M-x appt-add to add a time to appt. Then C-x C-f to enter the
> minibuf area, waits for the appt activates.
> 
> When activates, the point moves from minibuf to buffer(maybe call
> window?). Now I have to C-x o to enter the minibuf.

I suppose the attached patch should fix this.  But it might break
something else.  Glenn?

martin



[-- Attachment #2: appt.diff --]
[-- Type: text/plain, Size: 1291 bytes --]

*** calendar/appt.el.~1.92.~	2008-08-31 09:48:52.453125000 +0200
--- calendar/appt.el	2008-11-23 18:55:59.125000000 +0100
***************
*** 410,420 ****
  message APPT-MSG in a separate buffer."
    ;; Make sure we're not in the minibuffer before splitting the window.
    ;; FIXME this seems needlessly complicated?
-   (when (minibufferp)
-     (other-window 1)
-     (and (minibufferp) (display-multi-frame-p) (other-frame 1)))
    (let ((this-window (selected-window))
!         (appt-disp-buf (set-buffer (get-buffer-create appt-buffer-name))))
      (if (cdr (assq 'unsplittable (frame-parameters)))
          ;; In an unsplittable frame, use something somewhere else.
          (display-buffer appt-disp-buf)
--- 410,420 ----
  message APPT-MSG in a separate buffer."
    ;; Make sure we're not in the minibuffer before splitting the window.
    ;; FIXME this seems needlessly complicated?
    (let ((this-window (selected-window))
!         (appt-disp-buf (get-buffer-create appt-buffer-name)))
!     (when (minibufferp)
!       (other-window 1)
!       (and (minibufferp) (display-multi-frame-p) (other-frame 1)))
      (if (cdr (assq 'unsplittable (frame-parameters)))
          ;; In an unsplittable frame, use something somewhere else.
          (display-buffer appt-disp-buf)

Re: Bug: appt-display makes point back to buffer.

[Glenn Morris]

martin rudalics wrote:

> I suppose the attached patch should fix this.  But it might break
> something else.  Glenn?

Looks fine to me, thanks. Please install.

Re: Bug: appt-display makes point back to buffer.

[martin rudalics]

 > Please install.

Done.

BTW, could we get rid of the warnings below?

martin


In appt-display-message:
appt.el:232:21:Warning: `appt-msg-window' is an obsolete variable (as of Emacs
     22.1); use `appt-display-format' instead.
appt.el:233:21:Warning: `appt-visible' is an obsolete variable (as of Emacs
     22.1); use `appt-display-format' instead.

In appt-check:
appt.el:356:20:Warning: `appt-issue-message' is an obsolete variable (as of
     Emacs 22.1); use the function `appt-activate', and the variable
     `appt-display-format' instead.

Re: Bug: appt-display makes point back to buffer.

[Glenn Morris]

martin rudalics wrote:

> BTW, could we get rid of the warnings below?

I don't think so, and since they don't happen when bootstrapping, I
don't care much. :)

BTW, I overlooked the set-buffer part of your change till now.
At first sight, there is no longer any change of buffer in the
unsplittable case?

Re: Bug: appt-display makes point back to buffer.

[martin rudalics]

 > BTW, I overlooked the set-buffer part of your change till now.
 > At first sight, there is no longer any change of buffer in the
 > unsplittable case?

At second sight neither.  I hopefully fixed that now.

Thanks, martin.

Re: Bug: appt-display makes point back to buffer.

[anhnmncb]

martin rudalics <rudalics@gmx.at> writes:

>> emacs -Q
>>
>> eval (appt-activate 1) in *scratch* buffer.
>>
>> Use M-x appt-add to add a time to appt. Then C-x C-f to enter the
>> minibuf area, waits for the appt activates.
>>
>> When activates, the point moves from minibuf to buffer(maybe call
>> window?). Now I have to C-x o to enter the minibuf.
>
> I suppose the attached patch should fix this.  But it might break
> something else.  Glenn?
>
> martin
>
>
> *** calendar/appt.el.~1.92.~	2008-08-31 09:48:52.453125000 +0200
> --- calendar/appt.el	2008-11-23 18:55:59.125000000 +0100
> ***************
> *** 410,420 ****
>   message APPT-MSG in a separate buffer."
>     ;; Make sure we're not in the minibuffer before splitting the window.
>     ;; FIXME this seems needlessly complicated?
> -   (when (minibufferp)
> -     (other-window 1)
> -     (and (minibufferp) (display-multi-frame-p) (other-frame 1)))
>     (let ((this-window (selected-window))
> !         (appt-disp-buf (set-buffer (get-buffer-create appt-buffer-name))))
>       (if (cdr (assq 'unsplittable (frame-parameters)))
>           ;; In an unsplittable frame, use something somewhere else.
>           (display-buffer appt-disp-buf)
> --- 410,420 ----
>   message APPT-MSG in a separate buffer."
>     ;; Make sure we're not in the minibuffer before splitting the window.
>     ;; FIXME this seems needlessly complicated?
>     (let ((this-window (selected-window))
> !         (appt-disp-buf (get-buffer-create appt-buffer-name)))
> !     (when (minibufferp)
> !       (other-window 1)
> !       (and (minibufferp) (display-multi-frame-p) (other-frame 1)))
>       (if (cdr (assq 'unsplittable (frame-parameters)))
>           ;; In an unsplittable frame, use something somewhere else.
>           (display-buffer appt-disp-buf)

Thank you too, but I don't know how to install it, so I will wait for
the offical beta version :)