From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sun, 21 Jan 2018 22:52:02 -0800 Organization: UCLA Computer Science Department Message-ID: <4928e09c-e747-8754-973f-7b358ca3f5e7@cs.ucla.edu> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> <83372zryx3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1516603883 24663 195.159.176.226 (22 Jan 2018 06:51:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 06:51:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 07:51:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edVwU-0004je-9H for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 07:50:54 +0100 Original-Received: from localhost ([::1]:50709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edVyU-0004rk-LS for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 01:52:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edVxk-0004rR-Di for emacs-devel@gnu.org; Mon, 22 Jan 2018 01:52:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edVxj-0006xz-Oh for emacs-devel@gnu.org; Mon, 22 Jan 2018 01:52:12 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49070) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1edVxe-0006wX-1U; Mon, 22 Jan 2018 01:52:06 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 59D55160E52; Sun, 21 Jan 2018 22:52:04 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 42ISbdehUh60; Sun, 21 Jan 2018 22:52:02 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 871B2160E97; Sun, 21 Jan 2018 22:52:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IVPsjtXPS6_I; Sun, 21 Jan 2018 22:52:02 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5D556160E52; Sun, 21 Jan 2018 22:52:02 -0800 (PST) In-Reply-To: <83372zryx3.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222132 Archived-At: Eli Zaretskii wrote: > Why doesn't copy-file (or qcopy_acl?) use acl_errno_valid, as we do in > set-file-acl? Is there a reason for this inconsistency? set-file-acl is documented to return t on success, nil on ordinary failur= e, and=20 (this part is undocumented) it signals an error on a serious failure.=20 acl_errno_valid is used to decide whether the error is serious. copy-file simply signals an error on failure; its return value is undocum= ented.=20 So it doesn't have the three possibilities that set-file-acl has. Perhaps copy-file's API should be changed to have those three possibiliti= es, but=20 that'd be a fairly big change to its API.