From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#68054: [PATCH] Add tree-sitter indent rule for lexical decls in js/typescript Date: Mon, 22 Apr 2024 22:07:20 -0700 Message-ID: <49231C5D-E89E-4AA3-AB02-51340994EA20@gmail.com> References: <797AC075-B0C8-4269-B8E3-A1F2C69FA955@gmail.com> <14DD6D3A-B9F5-4E5F-B85B-0A8DF6961723@gmail.com> <5fd5b131-962a-489d-a674-0e199cdfff25@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37058"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 68054@debbugs.gnu.org To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 23 07:08:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz8Nw-0009Pg-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Apr 2024 07:08:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rz8Ng-0003U1-AU; Tue, 23 Apr 2024 01:07:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz8Ne-0003Tj-V9 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 01:07:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rz8Ne-0005Uv-N9 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 01:07:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rz8Nu-0005NX-EW for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2024 01:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2024 05:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68054 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68054-submit@debbugs.gnu.org id=B68054.171384888020655 (code B ref 68054); Tue, 23 Apr 2024 05:08:02 +0000 Original-Received: (at 68054) by debbugs.gnu.org; 23 Apr 2024 05:08:00 +0000 Original-Received: from localhost ([127.0.0.1]:49857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz8Nq-0005Mp-OA for submit@debbugs.gnu.org; Tue, 23 Apr 2024 01:07:59 -0400 Original-Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:60794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz8Nn-0005Lv-5f for 68054@debbugs.gnu.org; Tue, 23 Apr 2024 01:07:57 -0400 Original-Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6ed32341906so5013489b3a.1 for <68054@debbugs.gnu.org>; Mon, 22 Apr 2024 22:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713848853; x=1714453653; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IXuknr/4v4+uq9cEbbP8ay//dgnepy8FCtxHm9nuS7E=; b=hvi5oJMvwfF9z9Rf7Z5UjkiM9U/hHV0x2xhikiioOSn0lT5CAAXP0GjutP/V6gN3fo g3YObTMnCsokuPIk0AsnJWSsxbN3EuYZNCwPgsRTbHLqeihkB0zSThi9Kn1hQRb1ECK7 6q8mWszNkEPbprTxYcYOvkMlMaCKdH4N3M1KjnmVRfUCDLHPSs5ExP0LgRoX4j4LoY7Z B6KUA9731CumYJJphZw821X8mD2K1Fjs5mlZxKzEth26aHfAlfqN/IaskjYH7AXbAaCA g9rxl7oS8uhLiZ2EYF8cU5pOIQgeoE6InSTdbHwurPcL/54WhX0wH356XBWnNLofY1/i Bkyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713848853; x=1714453653; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IXuknr/4v4+uq9cEbbP8ay//dgnepy8FCtxHm9nuS7E=; b=ctTn3GZh7X5fb4BV1AwnhWPRsuGkI72sBvurAvoSCNucU5jPaiQMlQe315g0TTMGUp AeViC2D/jg29dMJGq+iA8bc/ZKjqK32jZWgXiIiLUJQXf6nR6IsKt7+AWKxVFQOdmIIk k1Nup7gYZKlUDBaJtQ6KwgWgS4yxbpEKS0pwfTPA9dxTpjnalyB0uTao8vRxzdBfsiGh Ar8MHTOFGSVXU/F0mE1iwusLG6DJywBVxWT1PaQSn5XT5AMfBFwznVg+iPiQlTfgQwVb 6//3aFwJQ4WkZ10/Uf8it0hKWF2jI3aD9Jc5F5rO8wxUvBguyN+h+gMm+MMYef3cnOUT ks/A== X-Forwarded-Encrypted: i=1; AJvYcCXmvRKMO67teyU+UrZeWBF0AetpC81ylMs0D4ZQGzB1Ygoejf37v4EOjZoTdjOU6Dt+4DwzLAt83Us4sioXhsm+mUGFMwk= X-Gm-Message-State: AOJu0YxyL/vYJ1C0E14CeXulbZUndW9aqlAAOVzClsH4b/Usb5vTqeZf ZwbN7En4Gd5HQINVKZxRoRRaKqGwaLSWvloPkDbcIcF1bqLXL946 X-Google-Smtp-Source: AGHT+IGTjSZVRl3z/sWl/psXY/ef1O8xClq614r0/bg1NHBFgEs9U/sE05fJ8HvlQkG2VJuFnjTqyQ== X-Received: by 2002:a05:6a00:2181:b0:6ee:1508:edd4 with SMTP id h1-20020a056a00218100b006ee1508edd4mr15664906pfi.7.1713848852695; Mon, 22 Apr 2024 22:07:32 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id d2-20020aa78142000000b006ed007b3596sm8757317pfn.69.2024.04.22.22.07.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2024 22:07:32 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283863 Archived-At: > On Apr 17, 2024, at 1:21 PM, Noah Peart = wrote: >=20 > Sorry, I forgot about this. I've just added a rule to align the = variable_declarators > in let, var, and const declarations, but I need some feedback about = the indentation > for values in the variable_declarators following dangling '=3D'. Thanks! >=20 > For example, which of the following would be preferable? >=20 > 1) indent the dangling values with respect to start of the declaration >=20 > const a =3D > (x: string): string =3D> { > return x + x; > }, > bbb =3D > { > "x": 0 > }, > cccc =3D > 1, > ddddd =3D 0; > =20 > 2) indent them with respect to the start of the variable_declarator >=20 > const a =3D > (x: string): string =3D> { > return x + x; > }, > bbb =3D > { > "x": 0 > }, > cccc =3D > 1, > ddddd =3D 0; >=20 > 3) align with the variable declarators (this is the same as js-mode) >=20 > const a =3D > (x: string): string =3D> { > return x + x; > }, > bbb =3D > { > "x": 0 > }, > cccc =3D > 1, > ddddd =3D 0; >=20 > I've attached a patch with with the rules for the 3 options here. I don=E2=80=99t really know what=E2=80=99s the convention, if there is = one. Maybe Dmitry has better idea. Personally I like option 1. Yuan=