From: martin rudalics <rudalics@gmx.at>
To: Glenn Morris <rgm@gnu.org>
Cc: 789@emacsbugs.donarmstrong.com
Subject: bug#789: find-function fails on advised subrs
Date: Sat, 08 Nov 2008 22:54:18 +0100 [thread overview]
Message-ID: <49160A8A.4080406@gmx.at> (raw)
In-Reply-To: <kjod0qt3ec.fsf@fencepost.gnu.org>
> Hi martin, I finally tried this...
... and I've forgotten all about it ;-)
>
>> ! (cond
>> ! ((and (symbolp fun-or-var) (featurep 'advice)
>> ! (ad-get-advice-info fun-or-var))
>> ! (setq advised t))
>> ! ((not type)
>> ! (setq fun-or-var (indirect-function fun-or-var))))
>
> This fails if I have an alias to an advised function.
>
>> ! ;; Get the real definition.
>> ! (def (if (symbolp real-function)
>> ! (symbol-function real-function)
>> ! function))
>> ! file-name string aliases)
>
> file-name and string seem unused.
>
>> ! (cond
>> ! (advised
>> ! (message "This function is advised"))
>
> Should this function be printing if something is advised?
> Again, what about aliases to advised functions?
If you can think of an easy fix for these, please go ahead. Otherwise,
I'll look into this next week.
martin
next prev parent reply other threads:[~2008-11-08 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 15:33 bug#789: find-function fails on advised subrs martin rudalics
2008-11-08 19:37 ` Glenn Morris
2008-11-08 21:54 ` martin rudalics [this message]
2008-11-14 6:19 ` Glenn Morris
2008-11-15 10:00 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49160A8A.4080406@gmx.at \
--to=rudalics@gmx.at \
--cc=789@emacsbugs.donarmstrong.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.