From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1276: 23.0.60; select_window_norecord chokes on dead window Date: Thu, 30 Oct 2008 12:39:58 +0100 Message-ID: <49099D0E.8040008@gmx.at> Reply-To: martin rudalics , 1276@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000408010302030800090607" X-Trace: ger.gmane.org 1225367426 5932 80.91.229.12 (30 Oct 2008 11:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Oct 2008 11:50:26 +0000 (UTC) To: emacs-pretest-bug Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 30 12:51:27 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KvW3d-0007sP-KR for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Oct 2008 12:51:21 +0100 Original-Received: from localhost ([127.0.0.1]:33813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvW2X-0007Id-2A for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Oct 2008 07:50:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvW2S-0007IX-It for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2008 07:50:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvW2R-0007IL-2Z for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2008 07:50:08 -0400 Original-Received: from [199.232.76.173] (port=53924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvW2R-0007II-01 for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2008 07:50:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35333) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KvW2Q-0001eL-GW for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2008 07:50:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9UBo3nM029480; Thu, 30 Oct 2008 04:50:03 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9UBo3LG029463; Thu, 30 Oct 2008 04:50:03 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 30 Oct 2008 11:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1276 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122536691528077 (code B ref -1); Thu, 30 Oct 2008 11:50:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 30 Oct 2008 11:41:55 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9UBfqe6028065 for ; Thu, 30 Oct 2008 04:41:53 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:60615 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KvVrg-0001zd-TH for emacs-pretest-bug@gnu.org; Thu, 30 Oct 2008 07:39:00 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KvVuP-0006mF-MX for emacs-pretest-bug@gnu.org; Thu, 30 Oct 2008 07:41:52 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:49646) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KvVuP-0006fl-5r for emacs-pretest-bug@gnu.org; Thu, 30 Oct 2008 07:41:49 -0400 Original-Received: (qmail invoked by alias); 30 Oct 2008 11:41:36 -0000 Original-Received: from 62-47-57-155.adsl.highway.telekom.at (EHLO [62.47.57.155]) [62.47.57.155] by mail.gmx.net (mp002) with SMTP; 30 Oct 2008 12:41:36 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18ejgk7D7geOtfE44lK6KwnX37mz5Z5YTiB9z3+n8 wSF3z/29XiCkUn User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6899999999999999,0.66 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 30 Oct 2008 07:50:08 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22036 gmane.emacs.pretest.bugs:23320 Archived-At: This is a multi-part message in MIME format. --------------000408010302030800090607 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit To reproduce with emacs -Q evaluate the following form (progn (setq debug-on-error t) (set-frame-height (selected-frame) 10) (split-window) (temp-buffer-resize-mode) (setq temp-buffer-max-height 20)) and do C-h v temp-buffer-max-height Gets me Debugger entered--Lisp error: (wrong-type-argument window-live-p #) describe-variable(temp-buffer-max-height) call-interactively(describe-variable nil nil) FWIW, the reason is that `fit-window-to-buffer' deletes prev_window temp_output_buffer_show eventually wants to resurrect after running `temp-buffer-show-hook'. The attached patch fixes this for me. martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ... --------------000408010302030800090607 Content-Type: text/plain; name="select_window_norecord.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="select_window_norecord.diff" *** window.c.~1.631.~ 2008-10-29 10:29:14.718750000 +0100 --- window.c 2008-10-30 11:08:50.406250000 +0100 *************** *** 3643,3649 **** select_window_norecord (window) Lisp_Object window; { ! return Fselect_window (window, Qt); } =0C Lisp_Object --- 3643,3650 ---- select_window_norecord (window) Lisp_Object window; { ! return WINDOW_LIVE_P (window) ! ? Fselect_window (window, Qt) : selected_window; } =0C Lisp_Object --------------000408010302030800090607--