bug#1276: 23.0.60; select_window_norecord chokes on dead window

bug#1276: 23.0.60; select_window_norecord chokes on dead window

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

To reproduce with emacs -Q evaluate the following form

(progn
    (setq debug-on-error t)
    (set-frame-height (selected-frame) 10)
    (split-window)
    (temp-buffer-resize-mode)
    (setq temp-buffer-max-height 20))

and do

    C-h v temp-buffer-max-height

Gets me

Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 3>)
    describe-variable(temp-buffer-max-height)
    call-interactively(describe-variable nil nil)


FWIW, the reason is that `fit-window-to-buffer' deletes prev_window
temp_output_buffer_show eventually wants to resurrect after running
`temp-buffer-show-hook'.  The attached patch fixes this for me.

martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...


[-- Attachment #2: select_window_norecord.diff --]
[-- Type: text/plain, Size: 486 bytes --]

*** window.c.~1.631.~	2008-10-29 10:29:14.718750000 +0100
--- window.c	2008-10-30 11:08:50.406250000 +0100
***************
*** 3643,3649 ****
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return Fselect_window (window, Qt);
  }
  \f
  Lisp_Object
--- 3643,3650 ----
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return WINDOW_LIVE_P (window)
!     ? Fselect_window (window, Qt) : selected_window;
  }
  \f
  Lisp_Object

bug#1276: 23.0.60; select_window_norecord chokes on dead window

[Stefan Monnier]

> martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...

Yes, it looks like a bug.


        Stefan

bug#1276: marked as done (23.0.60; select_window_norecord chokes on dead window)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]


Your message dated Fri, 31 Oct 2008 15:07:41 +0100
with message-id <490B112D.8010403@gmx.at>
and subject line Re: bug#1276: 23.0.60; select_window_norecord chokes on dead window
has caused the Emacs bug report #1276,
regarding 23.0.60; select_window_norecord chokes on dead window
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1276: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1276
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3725 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 727 bytes --]

To reproduce with emacs -Q evaluate the following form

(progn
    (setq debug-on-error t)
    (set-frame-height (selected-frame) 10)
    (split-window)
    (temp-buffer-resize-mode)
    (setq temp-buffer-max-height 20))

and do

    C-h v temp-buffer-max-height

Gets me

Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 3>)
    describe-variable(temp-buffer-max-height)
    call-interactively(describe-variable nil nil)


FWIW, the reason is that `fit-window-to-buffer' deletes prev_window
temp_output_buffer_show eventually wants to resurrect after running
`temp-buffer-show-hook'.  The attached patch fixes this for me.

martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...


[-- Attachment #2.1.2: select_window_norecord.diff --]
[-- Type: text/plain, Size: 486 bytes --]

*** window.c.~1.631.~	2008-10-29 10:29:14.718750000 +0100
--- window.c	2008-10-30 11:08:50.406250000 +0100
***************
*** 3643,3649 ****
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return Fselect_window (window, Qt);
  }
  \f
  Lisp_Object
--- 3643,3650 ----
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return WINDOW_LIVE_P (window)
!     ? Fselect_window (window, Qt) : selected_window;
  }
  \f
  Lisp_Object


[-- Attachment #3: Type: message/rfc822, Size: 1517 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 1276-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1276: 23.0.60; select_window_norecord chokes on dead window
Date: Fri, 31 Oct 2008 15:07:41 +0100
Message-ID: <490B112D.8010403@gmx.at>

Fixed as

2008-10-31  Martin Rudalics  <rudalics@gmx.at>

	* window.c [...]
	(select_window_norecord): Fix return value.  (Bug#1276)

martin