all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: emacs-pretest-bug <emacs-pretest-bug@gnu.org>
Subject: bug#1276: 23.0.60; select_window_norecord chokes on dead window
Date: Thu, 30 Oct 2008 12:39:58 +0100	[thread overview]
Message-ID: <49099D0E.8040008@gmx.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

To reproduce with emacs -Q evaluate the following form

(progn
    (setq debug-on-error t)
    (set-frame-height (selected-frame) 10)
    (split-window)
    (temp-buffer-resize-mode)
    (setq temp-buffer-max-height 20))

and do

    C-h v temp-buffer-max-height

Gets me

Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 3>)
    describe-variable(temp-buffer-max-height)
    call-interactively(describe-variable nil nil)


FWIW, the reason is that `fit-window-to-buffer' deletes prev_window
temp_output_buffer_show eventually wants to resurrect after running
`temp-buffer-show-hook'.  The attached patch fixes this for me.

martin, who thinks that `fit-window-to-buffer' shouldn't delete windows ...


[-- Attachment #2: select_window_norecord.diff --]
[-- Type: text/plain, Size: 486 bytes --]

*** window.c.~1.631.~	2008-10-29 10:29:14.718750000 +0100
--- window.c	2008-10-30 11:08:50.406250000 +0100
***************
*** 3643,3649 ****
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return Fselect_window (window, Qt);
  }
  \f
  Lisp_Object
--- 3643,3650 ----
  select_window_norecord (window)
       Lisp_Object window;
  {
!   return WINDOW_LIVE_P (window)
!     ? Fselect_window (window, Qt) : selected_window;
  }
  \f
  Lisp_Object


             reply	other threads:[~2008-10-30 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <490B112D.8010403@gmx.at>
2008-10-30 11:39 ` martin rudalics [this message]
2008-10-30 18:41   ` bug#1276: 23.0.60; select_window_norecord chokes on dead window Stefan Monnier
2008-10-31 14:15   ` bug#1276: marked as done (23.0.60; select_window_norecord chokes on dead window) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49099D0E.8040008@gmx.at \
    --to=rudalics@gmx.at \
    --cc=1276@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.