From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#27807: 25.2; ido-completing-read handles cons-style initial-input wrong Date: Mon, 15 Jul 2019 12:24:55 -0700 Message-ID: <4900ae91-5242-6549-93fe-319b4e0a96c1@thompsonclan.org> References: <87zhlf86yc.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40119"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 27807@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 15 21:26:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hn6c2-000ABx-S3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jul 2019 21:26:15 +0200 Original-Received: from localhost ([::1]:42218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn6bu-0005JL-KM for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jul 2019 15:26:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43061) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn6br-0005J3-S7 for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 15:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn6bq-0001oE-Pb for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 15:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hn6bq-0001o5-Bt for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hn6bq-0005PG-7Y for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2019 15:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 27807-submit@debbugs.gnu.org id=B27807.156321870920691 (code B ref 27807); Mon, 15 Jul 2019 19:26:02 +0000 Original-Received: (at 27807) by debbugs.gnu.org; 15 Jul 2019 19:25:09 +0000 Original-Received: from localhost ([127.0.0.1]:49159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn6ay-0005Nf-KD for submit@debbugs.gnu.org; Mon, 15 Jul 2019 15:25:08 -0400 Original-Received: from mail-qt1-f173.google.com ([209.85.160.173]:33113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn6ax-0005Mh-9p for 27807@debbugs.gnu.org; Mon, 15 Jul 2019 15:25:08 -0400 Original-Received: by mail-qt1-f173.google.com with SMTP id r6so12694287qtt.0 for <27807@debbugs.gnu.org>; Mon, 15 Jul 2019 12:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=dacfdpagfPHgArg2IrzXgMyObxxq8iBdtz7U8wcplMU=; b=KIdgKifeMMDGHfUGXdCufsTiwtiMN4+ql6NX6Ccjnw1cYMk0BN9UL6wtwc65VWf8KU aLp2Tgbgi05X5T0xjjl3N2ZJta3XFRLFyGhZJEAFzXCt9u/10o18RjhTmVc6lsGYI9nb TZOTBi/QTwKb+9YjE2G3xey8nqtdrM9d9iVT9CdLfBY+QH8jJmlrzens5xvX9ybzWdHK CGT787IsdKi8SuVZOS+fa9gTS8aaXAbuRRMHFmdSX5+h63cgepbwxGX4mGLozCle96HG EZSaFjCYme+3ugHIWlaR+a55ahaZovp6o/dX8/V/R4UDut4CCqhiQw8HnQRT0xyG4JLT CtEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dacfdpagfPHgArg2IrzXgMyObxxq8iBdtz7U8wcplMU=; b=soFyEjZLdNsACnFW3lSUxdhQtIR6AzLQm068liMHTfI0akMULpwaIPG6KeCAq0sVVI PeLPQ0f7QK7ZWiFkBLEpNm/oIYxNLiq2+LzBPh6/246oxndhKFCtLBFpc95Sqyz6R03S mLUCSu4DXgMpZ5v9jPxp/DGc8R29780WqZm37YK8hQ8IeUawNN2zspodHX7TpOMZl4Ly EFEXdlMqQu2OgXIOpHQnJQv0WkjgWY8FjWntsBQWMwhCS629ml/ks3115jXquQI/JRGF GHo7mIVFtpS3DPPk/iMsJV7Bmv3zwHgqG/6zAq4nj3RhM6NkZ1LCJwztCgVpGFZ1c5zf PB4A== X-Gm-Message-State: APjAAAWIlrXMZyHtCR3+ZnTZLsp5TB907l/gFdKPl/QTar00giiVarj3 0oLSweQ3gF4PNTAIGWSSUlPqgkyk X-Google-Smtp-Source: APXvYqx7Rf7ZiwFHlW3WWiRWNOUcVca27g1pUDzKUxn7X1BtMFG6ZfEJ/ithzAATmY/MRW4a4nAtVg== X-Received: by 2002:ac8:2774:: with SMTP id h49mr18579001qth.97.1563218700784; Mon, 15 Jul 2019 12:25:00 -0700 (PDT) Original-Received: from urania.lan ([209.134.95.37]) by smtp.gmail.com with ESMTPSA id r205sm9689834qke.115.2019.07.15.12.24.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 12:24:59 -0700 (PDT) In-Reply-To: <87zhlf86yc.fsf@mouse.gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163163 Archived-At: On 7/15/19 11:54 AM, Lars Ingebrigtsen wrote: > Ryan writes: > >>> `completing-read' uses 0-based index while `read-from-minibuffer' uses >>> 1-based index. >> Looking at "ido-read-internal", it passes the inital-input argument >> directly to "read-from-minibuffer" without incrementing it as >> "completing-read-default" does. Therefore any initial input of the form >> "(STRING . POSITION)" is handled incorrectly by ido, but this can be >> fixed by copying over the logic from "completing-read-default", as in >> this patch: >> https://mneme.dedyn.io/zerobin/?7cd07d73217c68e5#Aynth3YcZDcE7bkq8cxQnBl+uJ0/+d0UGYmB+7PqLT4= > The link is dead now, but I think I've now fixed this for Emacs 27. > So now I need to add a test on the version number in my ido-completing-read+ package to fix the index for older Emacsen while not fixing it for newer ones. Can you tell me which is the first version number this fix will be released in? 27.0? 27.1? Something else?