From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Nicholas Savage" Newsgroups: gmane.emacs.bugs Subject: bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912) Date: Tue, 08 Sep 2020 16:27:56 -0400 Message-ID: <48e2dded-3082-4ed0-96dd-784bb5623782@www.fastmail.com> References: <87v9nkm137.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=30fc667d4a5f47e2bd4ac5811cc34360 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14401"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.3.0-259-g88fbbfa-fm-20200903.003-g88fbbfa3 To: 39912@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 08 22:33:45 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFkJE-0003bs-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 22:33:44 +0200 Original-Received: from localhost ([::1]:41842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFkJD-0001wN-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 16:33:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFkHa-0007E4-HS for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 16:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFkHa-00083p-58 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFkHa-0006y9-2a for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 16:32:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v9nkm137.fsf@betli.tmit.bme.hu> Resent-From: "Nicholas Savage" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39912 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 39912-submit@debbugs.gnu.org id=B39912.159959708226730 (code B ref 39912); Tue, 08 Sep 2020 20:32:02 +0000 Original-Received: (at 39912) by debbugs.gnu.org; 8 Sep 2020 20:31:22 +0000 Original-Received: from localhost ([127.0.0.1]:56547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFkGw-0006x4-GN for submit@debbugs.gnu.org; Tue, 08 Sep 2020 16:31:22 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:41781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFkGu-0006wq-9N for 39912@debbugs.gnu.org; Tue, 08 Sep 2020 16:31:21 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6074512E3 for <39912@debbugs.gnu.org>; Tue, 8 Sep 2020 16:31:14 -0400 (EDT) Original-Received: from imap21 ([10.202.2.71]) by compute1.internal (MEProxy); Tue, 08 Sep 2020 16:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=qYg2zg8w87jmncj6n1Okl0rNJb4oj BReSeMhrU1HtJA=; b=mBcVID64pwZzGmA8+pXNrLFacr4yXrxrYNaXvgyEHwN+y xt6jPruDu9hOK5GbeZhLFvrFRdTFoOZMJERTCLy0/sQNV3LG3FA8qmvYTeefF6QE GW7uGoO8PVSpQB1TGEfbnTwMlzldepahTBUsbFG+g24omt/7h0/pGMOc2auxqo7w uzKNCYNz+DZYlnH8WDmT3aI7YPjDwwSoLZ/x3QSmWBljd60VLe7pHpm72ODg2A50 yF6+mjvpyqagr3EgjcKm8/Bf4IF7zJKW5/fX1nRgBHVnOjYidk3pq3xxu/sFipmy ANJMOyMquOpiZIrcyY2EXLbQEucpN1MAQBuyNoN4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehfedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesmhdtre erreertdenucfhrhhomhepfdfpihgthhholhgrshcuufgrvhgrghgvfdcuoehnihgtkhes nhhitghkshgrvhgrghgvrdgtrgeqnecuggftrfgrthhtvghrnhepuefhudeujeevieeuvd evveefkeeuudeigefhueefveefuefhveejffdutdfhveffnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhhitghksehnihgtkhhsrghvrghgvg drtggr X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id C76F7660069; Tue, 8 Sep 2020 16:31:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187593 Archived-At: --30fc667d4a5f47e2bd4ac5811cc34360 Content-Type: text/plain Hello, I've written a patch for Bug #39912, as discussed in debbugs. I think I have formatted this correctly and have followed CONTRIBUTE as best as I could. I've marked the patch as exempt from copyright assignment as my understanding is that 15 lines of code is the threshold. That being said, I have no problems assigning copyright for this and for future patches, and I would like to get the ball rolling on that now if possible. One thing I should mention is that the thread discussed view-mode for NEWS links in describe-function. I've also changed it so the actual source code link opens in view-mode as well. I don't know if there are ramifications of that, so I'm happy to change it if necessary. My thought process was that describe-function is used as a reference to the code, not as a point of entry for editing functions, so changing that is consistent with changing the NEWS links, but I don't know what I don't know. Thanks, Nick --30fc667d4a5f47e2bd4ac5811cc34360 Content-Disposition: attachment;filename="0001-Open-describe-function-links-in-view-mode-Bug-39912.patch" Content-Type: text/x-patch; name="0001-Open-describe-function-links-in-view-mode-Bug-39912.patch" Content-Transfer-Encoding: BASE64 RnJvbSA2MWJjZWNlYjIxNTVkNDUyMTYyNWY5NDdiZTg4OTc0M2M4ZDNjMjdiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIFNhdmFnZSA8bmlja0BuaWNrc2F2YWdlLmNh PgpEYXRlOiBUdWUsIDggU2VwIDIwMjAgMTY6MDg6MzAgLTA0MDAKU3ViamVjdDogW1BBVENI XSBPcGVuIGRlc2NyaWJlLWZ1bmN0aW9uIGxpbmtzIGluIHZpZXctbW9kZSAoQnVnIzM5OTEy KQoKKiBPcGVuIGRlc2NyaWJlLWZ1bmN0aW9uIGxpbmtzIGluIHZpZXctbW9kZSAoQnVnIzM5 OTEyKSB0byBtYWtlCmJlaGF2aW9yIGNvbnNpc3RlbnQgZGVwZW5kaW5nIG9uIHdoZXRoZXIg b3Igbm90IHVzZXIgaGFzIHBlcm1pc3Npb24KdG8gZWRpdCB0aGUgZmlsZXMuCgpDb3B5cmln aHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQogbGlzcC9oZWxwLW1vZGUuZWwgfCA0ICsr LS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9oZWxwLW1vZGUuZWwgYi9saXNwL2hlbHAtbW9kZS5lbAppbmRl eCA5YzJkMWQ3MjI3Li42NzNlN2JmMzA0IDEwMDY0NAotLS0gYS9saXNwL2hlbHAtbW9kZS5l bAorKysgYi9saXNwL2hlbHAtbW9kZS5lbApAQCAtMjA0LDcgKzIwNCw3IEBAIGhlbHAtZnVu Y3Rpb24tZGVmLS1idXR0b24tZnVuY3Rpb24KICAgICAobGV0KiAoKGxvY2F0aW9uCiAgICAg ICAgICAgICAoZmluZC1mdW5jdGlvbi1zZWFyY2gtZm9yLXN5bWJvbCBmdW4gdHlwZSBmaWxl KSkKICAgICAgICAgICAgKHBvc2l0aW9uIChjZHIgbG9jYXRpb24pKSkKLSAgICAgIChwb3At dG8tYnVmZmVyIChjYXIgbG9jYXRpb24pKQorICAgICAgKHZpZXctYnVmZmVyIChjYXIgbG9j YXRpb24pKQogICAgICAgKHJ1bi1ob29rcyAnZmluZC1mdW5jdGlvbi1hZnRlci1ob29rKQog ICAgICAgKGlmIHBvc2l0aW9uCiAgICAgICAgICAgKHByb2duCkBAIC0zMDgsNyArMzA4LDcg QEAgJ2hlbHAtbmV3cwogICA6c3VwZXJ0eXBlICdoZWxwLXhyZWYKICAgJ2hlbHAtZnVuY3Rp b24KICAgKGxhbWJkYSAoZmlsZSBwb3MpCi0gICAgKHBvcC10by1idWZmZXIgKGZpbmQtZmls ZS1ub3NlbGVjdCBmaWxlKSkKKyAgICAodmlldy1idWZmZXIgKGZpbmQtZmlsZS1ub3NlbGVj dCBmaWxlKSkKICAgICAoZ290by1jaGFyIHBvcykpCiAgICdoZWxwLWVjaG8gKHB1cmVjb3B5 ICJtb3VzZS0yLCBSRVQ6IHNob3cgY29ycmVzcG9uZGluZyBORVdTIGFubm91bmNlbWVudCIp KQogDAotLSAKMi4yMC4xCgo= --30fc667d4a5f47e2bd4ac5811cc34360--