From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: The latest lisp/faces.el changes seem to break color-themes again Date: Fri, 17 Oct 2008 01:09:00 +0200 Message-ID: <48F7C98C.9010402@gmail.com> References: <87skqxw20c.fsf@anzu.internal.golden-gryphon.com> <87od1lvxa9.fsf@anzu.internal.golden-gryphon.com> <87abd4vfyb.fsf@grepfind.mwolson.org> <87tzbcfqfe.fsf@cyd.mit.edu> <87ljwouzln.fsf@cyd.mit.edu> <87ej2ggt9y.fsf@cyd.mit.edu> <48F7C669.7080409@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1224198678 14364 80.91.229.12 (16 Oct 2008 23:11:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2008 23:11:18 +0000 (UTC) Cc: Chming , emacs-devel@gnu.org, Michael Olson , Vivek Dasmohapatra , "Richard M. Stallman" To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 17 01:12:17 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kqc0q-0003hZ-Lr for ged-emacs-devel@m.gmane.org; Fri, 17 Oct 2008 01:12:12 +0200 Original-Received: from localhost ([127.0.0.1]:60522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kqbzl-0006rL-L7 for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 19:11:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kqbzg-0006r6-7j for emacs-devel@gnu.org; Thu, 16 Oct 2008 19:11:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kqbzd-0006qJ-Od for emacs-devel@gnu.org; Thu, 16 Oct 2008 19:10:58 -0400 Original-Received: from [199.232.76.173] (port=53372 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kqbzd-0006qG-Iv for emacs-devel@gnu.org; Thu, 16 Oct 2008 19:10:57 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]:60992) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kqbza-0002sF-SS; Thu, 16 Oct 2008 19:10:55 -0400 Original-Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:60509 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1Kqbyu-0006zo-4r; Fri, 17 Oct 2008 01:10:24 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <48F7C669.7080409@gmail.com> X-Enigmail-Version: 0.95.7 X-Antivirus: avast! (VPS 081015-0, 2008-10-15), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-Scan-Result: No virus found in message 1Kqbyu-0006zo-4r. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1Kqbyu-0006zo-4r 84bcf7158293768b3bdb3053f9cdabf8 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104565 Archived-At: Lennart Borgman (gmail) wrote: > Chong Yidong wrote: >> Could someone try to debug what color-theme does that now breaks? > > I do not know about color-theme, but I just noticed that the > htmlfontify.el I distribute with nXhtml is broken too and I guess it is > the same problem. htmlfontify.el should be included in Emacs, but that > seems to have stalled somewhere. > > I get an error when I try to use htmlfontify-buffer on > list-colors-display output. I think the problem is that the format of > the data that hfy-get-face-at recieves, but I do not remember how it > looked before. Here is how the function look right now: > > (defun hfy-get-face-at (pos) > (if (or (not show-trailing-whitespace) > (not (get-text-property pos 'hfy-show-trailing-whitespace))) > (get-text-property pos 'face) > (list 'trailing-whitespace (get-text-property pos 'face)))) > > In the buffer I mentioned above get-text-property will now return things > like > > (:background "snow") > > There was some discussions before about removing old style face data, > but I do not remember that either, maybe Richard does. Here some more information that might help: In hfy-fact-at in htmlfontify.el the code used to do (let ((overlay-data nil) (face-name (hfy-get-face-at p)) (prop-seen nil) (found-face nil) (extra-props nil) (text-props (text-properties-at p)) ;;(face-names nil) ) (when (listp face-name) (dolist (f face-name) (if (listp f) ;; for things like (variable-pitch (:foreground "red")) (setq extra-props (cons f extra-props)) (setq extra-props (cons :inherit (cons f extra-props))))) (setq face-name nil)) Changing the if clause to (if t ...) now makes htmlfontify-buffer work for list-colors-display, but it may break something else. I remember I struggled a lot with this part of the code when I tried to get htmlfontify to work for all kinds of face specs in the buffer. Is there any documentation now that tells how face specs can look?