From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Aaron D. Ball" Newsgroups: gmane.emacs.bugs Subject: bug#1173: gnus/imap.el should quote quotes in password Date: Wed, 15 Oct 2008 14:11:43 -0400 Organization: Broad Institute of MIT and Harvard Message-ID: <48F6325F.5010107@broad.mit.edu> Reply-To: "Aaron D. Ball" , 1173@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1224132529 12072 80.91.229.12 (16 Oct 2008 04:48:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2008 04:48:49 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 16 06:49:44 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqKnu-00054a-Hn for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Oct 2008 06:49:43 +0200 Original-Received: from localhost ([127.0.0.1]:38916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqKmp-00041W-1d for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Oct 2008 00:48:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqB8H-0001XQ-Ea for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:30:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqB8E-0001Ub-CE for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:30:04 -0400 Original-Received: from [199.232.76.173] (port=42499 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqB8E-0001UN-7m for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:30:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53021) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqB8D-00062p-K3 for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:30:01 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9FITxYO014686; Wed, 15 Oct 2008 11:29:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9FIK3V3012369; Wed, 15 Oct 2008 11:20:03 -0700 X-Loop: don@donarmstrong.com Resent-From: "Aaron D. Ball" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 15 Oct 2008 18:20:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1173 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122409431211114 (code B ref -1); Wed, 15 Oct 2008 18:20:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 15 Oct 2008 18:11:52 +0000 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9FIBnSt011108 for ; Wed, 15 Oct 2008 11:11:50 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqAqa-00046i-El for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqAqX-00044L-3L for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:47 -0400 Original-Received: from [199.232.76.173] (port=33891 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqAqX-00044G-0q for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:45 -0400 Original-Received: from lysine.broad.mit.edu ([18.103.8.101]:59898) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqAqW-0002nK-OE for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:44 -0400 Original-Received: from localhost (phenylalanine.broad.mit.edu [18.103.34.14]) by lysine.broad.mit.edu (Postfix) with ESMTP id 2BB56180FF for ; Wed, 15 Oct 2008 14:11:44 -0400 (EDT) X-Virus-Scanned: amavisd-new at broad.mit.edu Original-Received: from lysine.broad.mit.edu ([18.103.8.101]) by localhost (phenylalanine.broad.mit.edu [18.103.34.14]) (amavisd-new, port 10024) with LMTP id yOU2TBpvOkR4 for ; Wed, 15 Oct 2008 14:11:43 -0400 (EDT) Original-Received: from gm518-ea5.broad.mit.edu (gm518-ea5.broad.mit.edu [18.103.27.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: adb@broad.mit.edu) by lysine.broad.mit.edu (Postfix) with ESMTP id 5BAD8180EA for ; Wed, 15 Oct 2008 14:11:43 -0400 (EDT) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081010 Shredder/3.0b1pre X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 15 Oct 2008 14:30:04 -0400 X-Mailman-Approved-At: Thu, 16 Oct 2008 00:48:18 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21518 Archived-At: When sending a LOGIN command, the imap-login-auth function in imap.el does not quote double quotes in the password string, so passwords containing double quotes result in an error. I'm using stock Emacs 22.3, compiled by our sysadmin team here: GNU Emacs 22.3.2 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-09-26 on node106 Below is the patch I am using, which fixed the problem for me: --- lisp/gnus/imap.el~ 2008-01-06 20:22:42.000000000 -0500 +++ lisp/gnus/imap.el 2008-10-15 13:58:06.124586000 -0400 @@ -922,7 +922,7 @@ (lambda (user passwd) (imap-ok-p (imap-send-command-wait (concat "LOGIN \"" user "\" \"" - passwd "\"")))))) + (replace-regexp-in-string "\"" "\\\"" passwd) "\"")))))) (defun imap-anonymous-p (buffer) t) -- Aaron D. Ball Senior Systems Analyst Broad Institute of MIT and Harvard